From patchwork Tue Mar 12 09:42:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 1055254 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44JVQ72RDsz9s00 for ; Tue, 12 Mar 2019 20:42:55 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725917AbfCLJmz (ORCPT ); Tue, 12 Mar 2019 05:42:55 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:37123 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbfCLJmy (ORCPT ); Tue, 12 Mar 2019 05:42:54 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h3dvw-0005mf-R5; Tue, 12 Mar 2019 10:42:52 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1h3dvw-0007iT-Ac; Tue, 12 Mar 2019 10:42:52 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding Cc: linux-pwm@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH] pwm: poke users of legacy drivers with a warning Date: Tue, 12 Mar 2019 10:42:49 +0100 Message-Id: <20190312094249.27806-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pwm@vger.kernel.org Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org As it is hard to convert a given driver from the legacy functions (.enable, .disable, .config) to the atomic stuff (.apply) without testing make users aware that there is something to do with a warning to eventually get rid of the legacy drivers. Signed-off-by: Uwe Kleine-König --- drivers/pwm/core.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index e547c3217fca..1a871cf8f7ee 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -236,16 +236,20 @@ void *pwm_get_chip_data(struct pwm_device *pwm) } EXPORT_SYMBOL_GPL(pwm_get_chip_data); -static bool pwm_ops_check(const struct pwm_ops *ops) +static bool pwm_ops_check(const struct pwm_chip *chip) { - /* driver supports legacy, non-atomic operation */ - if (ops->config && ops->enable && ops->disable) - return true; + const struct pwm_ops *ops = chip->ops; /* driver supports atomic operation */ if (ops->apply) return true; + /* driver supports legacy, non-atomic operation */ + if (ops->config && ops->enable && ops->disable) { + dev_warn(chip->dev, "registering PWM driver with legacy API, driver needs updating"); + return true; + } + return false; } @@ -270,7 +274,7 @@ int pwmchip_add_with_polarity(struct pwm_chip *chip, if (!chip || !chip->dev || !chip->ops || !chip->npwm) return -EINVAL; - if (!pwm_ops_check(chip->ops)) + if (!pwm_ops_check(chip)) return -EINVAL; mutex_lock(&pwm_lock);