Message ID | 1552323335-46779-20-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Bxfjbsf+"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44J4Vj2Hbhz9s00 for <incoming@patchwork.ozlabs.org>; Tue, 12 Mar 2019 04:15:23 +1100 (AEDT) Received: from localhost ([127.0.0.1]:37072 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1h3OWG-0006Fu-E2 for incoming@patchwork.ozlabs.org; Mon, 11 Mar 2019 13:15:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>) id 1h3ODb-00077I-9n for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:56:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>) id 1h3ODa-0003FD-BL for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:56:03 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:46621) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>) id 1h3ODZ-00034g-Ch for qemu-devel@nongnu.org; Mon, 11 Mar 2019 12:56:02 -0400 Received: by mail-wr1-x42d.google.com with SMTP id i16so5927269wrs.13 for <qemu-devel@nongnu.org>; Mon, 11 Mar 2019 09:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FFXjAL/gQYc05qKrBvN/6j5CEt0yJyVBFP7GqI7giz8=; b=Bxfjbsf+aOMvpfcHN6FecgNtOnX9Sr733hI6l3XlwZ8WrXbsq3aI91qHSFnm7LL0mG R5pVX9RW6m92mTKWPdhOH1QxzJ74i980PaRqfmL0Bmt3rarAZGJviu+e3lHGA8SfyD3U VLkPkT98eA4Zuwki36lKpIIUTFMWSNbH9hTkzbVxtp+b8TwnaYArhsnMQgPtrkB8/Inn 4Ywed6v7s7jRDs0Yga4PSl/FN7KjR+MRMj/crICMcbkapd5+ZfTVr1/owWfMCd4MgQKx i7eh1U6W4nNb0y6O+AbvErbxNe1BVsmLbIVVyGN+LS3EhNmifUmiSTEZ/qeNHBhfIpSl nwiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=FFXjAL/gQYc05qKrBvN/6j5CEt0yJyVBFP7GqI7giz8=; b=Sg12hmi0bUtoqk3RQV7X4SZ2pVYq0t97Rr/2CqvynEaOJ7awM1IdMXg2k4h23LZBj9 eKxvggWtH2uNfQy8dzevYvP5Wy+HwQfQvdM0XO7JCM67jaCk4wjMKOZYJpW1tlZuIWn7 4/yee1w46MVBCJGffUGXY5XEVqfjGVIVdg7PIl9yYOG2/gQGH0r3e/Tj29r5fDHdgXGu ZZbkJ/MMte52LpEODZk+tYHM3cieYYJYI2+ejGbm1eGrZJ7azT7i/hXyIt/R0WSVq1ID 31W2+Cern/RnFNxgyt5Pq49A9IA0FNI5hv5H6gxuXMcLCvOccvtG2mjuG1LMzd4qsPhB Cvuw== X-Gm-Message-State: APjAAAUj0mgZdithV8HBJC6hC7iiRyJQq9NVvc5g1RC3zE8qsrMrg5uz WNKcTIp/+s5+tP1gjPpuDzoaNaU4 X-Google-Smtp-Source: APXvYqwhAr5hQroXNsCdXGJGQcc0wbBQe/0cUJWiQTTR2IWc8XIEbIHWJ16njPy3l5WjEbS3PIY/dQ== X-Received: by 2002:adf:f14f:: with SMTP id y15mr5185626wro.223.1552323359243; Mon, 11 Mar 2019 09:55:59 -0700 (PDT) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id e12sm6484836wrs.91.2019.03.11.09.55.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Mar 2019 09:55:58 -0700 (PDT) From: Paolo Bonzini <pbonzini@redhat.com> To: qemu-devel@nongnu.org Date: Mon, 11 Mar 2019 17:55:23 +0100 Message-Id: <1552323335-46779-20-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1552323335-46779-1-git-send-email-pbonzini@redhat.com> References: <1552323335-46779-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42d Subject: [Qemu-devel] [PULL v2 19/31] oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@redhat.com> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
Series |
[PULL,v2,01/31] memory: Do not update coalesced IO range in the case of NOP
|
expand
|
diff --git a/util/oslib-posix.c b/util/oslib-posix.c index 37c5854..326d92d 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -244,7 +244,19 @@ void qemu_set_nonblock(int fd) f = fcntl(fd, F_GETFL); assert(f != -1); f = fcntl(fd, F_SETFL, f | O_NONBLOCK); +#ifdef __OpenBSD__ + if (f == -1) { + /* + * Previous to OpenBSD 6.3, fcntl(F_SETFL) is not permitted on + * memory devices and sets errno to ENODEV. + * It's OK if we fail to set O_NONBLOCK on devices like /dev/null, + * because they will never block anyway. + */ + assert(errno == ENODEV); + } +#else assert(f != -1); +#endif } int socket_set_fast_reuse(int fd)