| Message ID | 20190311104429.31044-1-axel.lin@ingics.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] gpio: adnp: Fix testing wrong value in adnp_gpio_direction_input | expand |
pon., 11 mar 2019 o 11:44 Axel Lin <axel.lin@ingics.com> napisał(a): > > Current code test wrong value so it does not verify if the written > data is correctly read back. Fix it. > Also make it return -EPERM if read value does not match written bit, > just like it done for adnp_gpio_direction_output(). > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > Reviewed-by: Thierry Reding <thierry.reding@gmail.com> Missing Fixes tag. Bart > --- > v2: > Address Thierry's comment: > Also make it return -EPERM if read value does not match written bit, > just like it done for adnp_gpio_direction_output(). > > drivers/gpio/gpio-adnp.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-adnp.c b/drivers/gpio/gpio-adnp.c > index 91b90c0cea73..12acdac85820 100644 > --- a/drivers/gpio/gpio-adnp.c > +++ b/drivers/gpio/gpio-adnp.c > @@ -132,8 +132,10 @@ static int adnp_gpio_direction_input(struct gpio_chip *chip, unsigned offset) > if (err < 0) > goto out; > > - if (err & BIT(pos)) > - err = -EACCES; > + if (value & BIT(pos)) { > + err = -EPERM; > + goto out; > + } > > err = 0; > > -- > 2.17.1 >
diff --git a/drivers/gpio/gpio-adnp.c b/drivers/gpio/gpio-adnp.c index 91b90c0cea73..12acdac85820 100644 --- a/drivers/gpio/gpio-adnp.c +++ b/drivers/gpio/gpio-adnp.c @@ -132,8 +132,10 @@ static int adnp_gpio_direction_input(struct gpio_chip *chip, unsigned offset) if (err < 0) goto out; - if (err & BIT(pos)) - err = -EACCES; + if (value & BIT(pos)) { + err = -EPERM; + goto out; + } err = 0;