| Message ID | 20190311083234.20841-1-richardw.yang@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | qom: use object_new_with_type in object_new_with_propv | expand |
Hi On Mon, Mar 11, 2019 at 9:34 AM Wei Yang <richardw.yang@linux.intel.com> wrote: > > Function object_new_with_propv already get the Type of the object, so we > could leverage object_new_with_type here. > > [make check test pass] > > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > --- > qom/object.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qom/object.c b/qom/object.c > index 05a8567041..76d2f1eb2f 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -640,7 +640,7 @@ Object *object_new_with_propv(const char *typename, > error_setg(errp, "object type '%s' is abstract", typename); > return NULL; > } > - obj = object_new(typename); > + obj = object_new_with_type(klass->type); > > if (object_set_propv(obj, &local_err, vargs) < 0) { > goto error; > -- > 2.19.1 > > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
On Mon, Mar 11, 2019 at 06:08:10PM +0100, Marc-André Lureau wrote: >Hi > >On Mon, Mar 11, 2019 at 9:34 AM Wei Yang <richardw.yang@linux.intel.com> wrote: >> >> Function object_new_with_propv already get the Type of the object, so we >> could leverage object_new_with_type here. >> >> [make check test pass] >> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> >> --- >> qom/object.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/qom/object.c b/qom/object.c >> index 05a8567041..76d2f1eb2f 100644 >> --- a/qom/object.c >> +++ b/qom/object.c >> @@ -640,7 +640,7 @@ Object *object_new_with_propv(const char *typename, >> error_setg(errp, "object type '%s' is abstract", typename); >> return NULL; >> } >> - obj = object_new(typename); >> + obj = object_new_with_type(klass->type); >> >> if (object_set_propv(obj, &local_err, vargs) < 0) { >> goto error; >> -- >> 2.19.1 >> >> > >Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > Thanks :-) >-- >Marc-André Lureau
On Mon, Mar 11, 2019 at 04:32:34PM +0800, Wei Yang wrote: > Function object_new_with_propv already get the Type of the object, so we > could leverage object_new_with_type here. > > [make check test pass] > > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > --- > qom/object.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM. Just a note for future patches: I think that info like "[make check test pass]" should go after the three dashes to avoid to store it in the commit message. Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Thanks, Stefano
On Tue, Mar 12, 2019 at 09:43:13AM +0100, Stefano Garzarella wrote: >On Mon, Mar 11, 2019 at 04:32:34PM +0800, Wei Yang wrote: >> Function object_new_with_propv already get the Type of the object, so we >> could leverage object_new_with_type here. >> >> [make check test pass] >> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> >> --- >> qom/object.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > >LGTM. Just a note for future patches: >I think that info like "[make check test pass]" should go after the >three dashes to avoid to store it in the commit message. > Thanks for reminding :-) >Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > >Thanks, >Stefano
Stefano Garzarella <sgarzare@redhat.com> writes: > On Mon, Mar 11, 2019 at 04:32:34PM +0800, Wei Yang wrote: >> Function object_new_with_propv already get the Type of the object, so we >> could leverage object_new_with_type here. >> >> [make check test pass] >> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> >> --- >> qom/object.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > LGTM. Just a note for future patches: > I think that info like "[make check test pass]" should go after the > three dashes to avoid to store it in the commit message. Yes. Whoever applies should delete this line. > Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Cc: qemu-trivial for merging.
On 02/04/2019 08:27, Markus Armbruster wrote: > Stefano Garzarella <sgarzare@redhat.com> writes: > >> On Mon, Mar 11, 2019 at 04:32:34PM +0800, Wei Yang wrote: >>> Function object_new_with_propv already get the Type of the object, so we >>> could leverage object_new_with_type here. >>> >>> [make check test pass] >>> >>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> >>> --- >>> qom/object.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> LGTM. Just a note for future patches: >> I think that info like "[make check test pass]" should go after the >> three dashes to avoid to store it in the commit message. > > Yes. Whoever applies should delete this line. > >> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > > Cc: qemu-trivial for merging. > Applied to my trivial-patches branch with updated commit message. Thanks, Laurent
diff --git a/qom/object.c b/qom/object.c index 05a8567041..76d2f1eb2f 100644 --- a/qom/object.c +++ b/qom/object.c @@ -640,7 +640,7 @@ Object *object_new_with_propv(const char *typename, error_setg(errp, "object type '%s' is abstract", typename); return NULL; } - obj = object_new(typename); + obj = object_new_with_type(klass->type); if (object_set_propv(obj, &local_err, vargs) < 0) { goto error;
Function object_new_with_propv already get the Type of the object, so we could leverage object_new_with_type here. [make check test pass] Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> --- qom/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)