From patchwork Tue Jul 19 04:02:15 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongqiang Yang X-Patchwork-Id: 105386 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 336E4B6F69 for ; Tue, 19 Jul 2011 14:06:48 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751104Ab1GSEGr (ORCPT ); Tue, 19 Jul 2011 00:06:47 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:48758 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032Ab1GSEGq (ORCPT ); Tue, 19 Jul 2011 00:06:46 -0400 Received: by mail-iy0-f174.google.com with SMTP id 12so3708338iyb.19 for ; Mon, 18 Jul 2011 21:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=8ULNV+cgtd0MPrYFC/12rMoeRuWfWnytqJtVZPa0uPU=; b=wEZPxymb6reI9Fdi+EUzgIcJifticGNn7/oxACdz3Bo5grGhZIsl07nJssSu6LGdJ6 HaHjax0uN0qfo+B2/1AcdBYcAzOjF4uRyVilWAm0cVcJR0j8vfYDooP+jHUHgW+uRUo0 BZEv3R6Ru7xyM/Q0DlrCoieAEGZZpnn7+uvHk= Received: by 10.42.74.130 with SMTP id w2mr7526991icj.462.1311048406684; Mon, 18 Jul 2011 21:06:46 -0700 (PDT) Received: from localhost.localdomain ([159.226.43.42]) by mx.google.com with ESMTPS id vj5sm5701144icb.11.2011.07.18.21.06.44 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 18 Jul 2011 21:06:46 -0700 (PDT) From: Yongqiang Yang To: linux-ext4@vger.kernel.org Cc: adilger@dilger.ca, amir73il@gmail.com, tm@tao.ma, Yongqiang Yang Subject: [PATCH v2 09/11] ext4: remove lock_buffer in bclean() and setup_new_group_blocks() Date: Tue, 19 Jul 2011 12:02:15 +0800 Message-Id: <1311048137-16400-10-git-send-email-xiaoqiangnk@gmail.com> X-Mailer: git-send-email 1.7.5.1 In-Reply-To: <1311048137-16400-1-git-send-email-xiaoqiangnk@gmail.com> References: <1311048137-16400-1-git-send-email-xiaoqiangnk@gmail.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Nobody touchs blocks beyond the filesystem, there is no need to lock the buffers. Signed-off-by: Yongqiang Yang --- fs/ext4/resize.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) v1->v2: nothing changed. diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 5b423f8..65e5cb6 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -147,10 +147,8 @@ static struct buffer_head *bclean(handle_t *handle, struct super_block *sb, brelse(bh); bh = ERR_PTR(err); } else { - lock_buffer(bh); memset(bh->b_data, 0, sb->s_blocksize); set_buffer_uptodate(bh); - unlock_buffer(bh); } return bh; @@ -229,10 +227,8 @@ static int setup_new_group_blocks(struct super_block *sb, brelse(gdb); goto exit_journal; } - lock_buffer(gdb); memcpy(gdb->b_data, sbi->s_group_desc[i]->b_data, gdb->b_size); set_buffer_uptodate(gdb); - unlock_buffer(gdb); err = ext4_handle_dirty_metadata(handle, NULL, gdb); if (unlikely(err)) { brelse(gdb);