diff mbox

[pph] Fix c1builtin-integral (issue4761045)

Message ID 20110719005455.0774B1C3720@gchare.mtv.corp.google.com
State New
Headers show

Commit Message

Gab Charette July 19, 2011, 12:54 a.m. UTC 
The issue was that we were compiling the pph with some flags and weren't doing so in the rest of the compilation (pph and non-pph), resulting in different outputs.

The fact that pph would let this happen is potentially a problem and I opened a separate thread "Flags and pph..." to discuss this.

We potentially want to store which flags were on at the pph compile time and make sure the same flags are on when doing the real compile (otherwise recompile the pph or some other soltution...??)

How we decide to handle this is beyond the scope of just fixing this test, so here is the patch for now (and I just realized I forgot to add the ChangeLog, but will add it as part of the commit...)

Gab


--
This patch is available for review at http://codereview.appspot.com/4761045

Comments

Diego Novillo July 19, 2011, 1 a.m. UTC | #1 
On Mon, Jul 18, 2011 at 20:54, Gabriel Charette <gchare@google.com> wrote:

> We potentially want to store which flags were on at the pph compile time and make sure the same flags
> are on when doing the real compile (otherwise recompile the pph or some other soltution...??)

That's up to the build system.  Different flags will generate
different code, so dependency tracking needs to deal with these
issues.

> diff --git a/gcc/testsuite/g++.dg/pph/c1builtin-integral.cc b/gcc/testsuite/g++.dg/pph/c1builtin-integral.cc
> index 6887b11..ae33f8d 100644
> --- a/gcc/testsuite/g++.dg/pph/c1builtin-integral.cc
> +++ b/gcc/testsuite/g++.dg/pph/c1builtin-integral.cc
> @@ -1,2 +1,2 @@
> -// pph asm xdiff 52758
> +/* { dg-options "-ffinite-math-only -fno-math-errno" } */
>  #include "c0builtin-integral.h"

OK with a ChangeLog entry.


Diego.
diff mbox

Patch

diff --git a/gcc/testsuite/g++.dg/pph/c1builtin-integral.cc b/gcc/testsuite/g++.dg/pph/c1builtin-integral.cc
index 6887b11..ae33f8d 100644
--- a/gcc/testsuite/g++.dg/pph/c1builtin-integral.cc
+++ b/gcc/testsuite/g++.dg/pph/c1builtin-integral.cc
@@ -1,2 +1,2 @@ 
-// pph asm xdiff 52758
+/* { dg-options "-ffinite-math-only -fno-math-errno" } */
 #include "c0builtin-integral.h"