Message ID | 20190307151141.6483-1-kraxel@redhat.com |
---|---|
State | New |
Headers | show |
On Thu, 7 Mar 2019 at 15:23, Gerd Hoffmann <kraxel@redhat.com> wrote: > > The following changes since commit 32694e98b8d7a246345448a8f707d2e11d6c65e2: > > Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2019-03-06 18:52:19 +0000) > > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/ui-20190307-pull-request > > for you to fetch changes up to 9b3c34835094760732c65a829bf0c07512126496: > > monitor: deprecate acl_show, acl_reset, acl_policy, acl_add, acl_remove (2019-03-07 14:23:22 +0100) > > ---------------------------------------------------------------- > curses: better wide char support. > vnc: acl update, stall fix. > > ---------------------------------------------------------------- Hi; this fails to build on FreeBSD; linking the qemu-system-* binaries fails with: /usr/bin/ld: undefined reference to symbol `libiconv_open' (try adding -liconv) //usr/local/lib/libiconv.so.2: could not read symbols: Bad value c++: error: linker command failed with exit code 1 (use -v to see invocation) (This is with the FreeBSD test setup from tests/vm/freebsd). thanks -- PMM
> > curses: better wide char support. > > vnc: acl update, stall fix. > Hi; this fails to build on FreeBSD; linking the qemu-system-* > binaries fails with: > > /usr/bin/ld: undefined reference to symbol `libiconv_open' (try adding -liconv) > //usr/local/lib/libiconv.so.2: could not read symbols: Bad value > c++: error: linker command failed with exit code 1 (use -v to see invocation) > (This is with the FreeBSD test setup from tests/vm/freebsd). Hmm, not obvious why configure finds iconv but the build doesn't. Samuel, can you check please? Dropped the two iconv patches, sent a v2 pull. cheers, Gerd
Gerd Hoffmann, le lun. 11 mars 2019 09:33:40 +0100, a ecrit: > > > curses: better wide char support. > > > vnc: acl update, stall fix. > > > Hi; this fails to build on FreeBSD; linking the qemu-system-* > > binaries fails with: > > > > /usr/bin/ld: undefined reference to symbol `libiconv_open' (try adding -liconv) > > //usr/local/lib/libiconv.so.2: could not read symbols: Bad value > > c++: error: linker command failed with exit code 1 (use -v to see invocation) > > > (This is with the FreeBSD test setup from tests/vm/freebsd). > > Hmm, not obvious why configure finds iconv but the build doesn't. > Samuel, can you check please? Mmm, that's because on the freebsd vm there is a libiconv installed in /usr/local, and that path gets pulled in include flags after the system's iconv is detected not to need -liconv. In PATCHv3 I have added detection in /usr/local before /usr Samuel