Patchwork [U-Boot] am3517evm: remove rootfstype kernel parameter for MMC boot device

login
register
mail settings
Submitter Yegor Yefremov
Date July 18, 2011, 1:51 p.m.
Message ID <4E243A4E.9070904@visionsystems.de>
Download mbox | patch
Permalink /patch/105283/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Yegor Yefremov - July 18, 2011, 1:51 p.m.
From 53afd3a38abbaed8890ca1ba36439e0c93b69969 Mon Sep 17 00:00:00 2001
From: Yegor Yefremov <yegorslists@googlemail.com>
Date: Mon, 18 Jul 2011 15:44:42 +0200
Subject: [PATCH] am3517evm: remove rootfstype kernel parameter for MMC boot device

it is not necessary to define rootfstype for mass storage devices.
Kernel detects it automatically.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 include/configs/am3517_evm.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
Yegor Yefremov - Jan. 25, 2012, 8:06 a.m.
Am 18.07.2011 15:51, schrieb Yegor Yefremov:
> From 53afd3a38abbaed8890ca1ba36439e0c93b69969 Mon Sep 17 00:00:00 2001
> From: Yegor Yefremov <yegorslists@googlemail.com>
> Date: Mon, 18 Jul 2011 15:44:42 +0200
> Subject: [PATCH] am3517evm: remove rootfstype kernel parameter for MMC boot device
> 
> it is not necessary to define rootfstype for mass storage devices.
> Kernel detects it automatically.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  include/configs/am3517_evm.h |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h
> index 18aaadf..8b8c80b 100644
> --- a/include/configs/am3517_evm.h
> +++ b/include/configs/am3517_evm.h
> @@ -192,8 +192,7 @@
>  	"loadaddr=0x82000000\0" \
>  	"console=ttyO2,115200n8\0" \
>  	"mmcargs=setenv bootargs console=${console} " \
> -		"root=/dev/mmcblk0p2 rw " \
> -		"rootfstype=ext3 rootwait\0" \
> +		"root=/dev/mmcblk0p2 rw rootwait\0" \
>  	"nandargs=setenv bootargs console=${console} " \
>  		"root=/dev/mtdblock4 rw " \
>  		"rootfstype=jffs2\0" \

Could you please review this patch? It is very annoying when using Buildroot as it creates ext2 images.

Thanks.

Yegor
Tom Rini - Jan. 25, 2012, 9:31 p.m.
On Wed, Jan 25, 2012 at 1:06 AM, Yegor Yefremov
<yegor_sub1@visionsystems.de> wrote:
> Am 18.07.2011 15:51, schrieb Yegor Yefremov:
>> From 53afd3a38abbaed8890ca1ba36439e0c93b69969 Mon Sep 17 00:00:00 2001
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>> Date: Mon, 18 Jul 2011 15:44:42 +0200
>> Subject: [PATCH] am3517evm: remove rootfstype kernel parameter for MMC boot device
>>
>> it is not necessary to define rootfstype for mass storage devices.
>> Kernel detects it automatically.
>>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>> ---
>>  include/configs/am3517_evm.h |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h
>> index 18aaadf..8b8c80b 100644
>> --- a/include/configs/am3517_evm.h
>> +++ b/include/configs/am3517_evm.h
>> @@ -192,8 +192,7 @@
>>       "loadaddr=0x82000000\0" \
>>       "console=ttyO2,115200n8\0" \
>>       "mmcargs=setenv bootargs console=${console} " \
>> -             "root=/dev/mmcblk0p2 rw " \
>> -             "rootfstype=ext3 rootwait\0" \
>> +             "root=/dev/mmcblk0p2 rw rootwait\0" \
>>       "nandargs=setenv bootargs console=${console} " \
>>               "root=/dev/mtdblock4 rw " \
>>               "rootfstype=jffs2\0" \
>
> Could you please review this patch? It is very annoying when using Buildroot as it creates ext2 images.

Reworked to apply again and applied to u-boot-ti/master, thanks for
the reminder.

Patch

diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h
index 18aaadf..8b8c80b 100644
--- a/include/configs/am3517_evm.h
+++ b/include/configs/am3517_evm.h
@@ -192,8 +192,7 @@ 
 	"loadaddr=0x82000000\0" \
 	"console=ttyO2,115200n8\0" \
 	"mmcargs=setenv bootargs console=${console} " \
-		"root=/dev/mmcblk0p2 rw " \
-		"rootfstype=ext3 rootwait\0" \
+		"root=/dev/mmcblk0p2 rw rootwait\0" \
 	"nandargs=setenv bootargs console=${console} " \
 		"root=/dev/mtdblock4 rw " \
 		"rootfstype=jffs2\0" \