diff mbox series

[D/linux-kvm,SRU,1/1] UBUNTU: [Config]: disable CONFIG_SECURITY_SELINUX_DISABLE

Message ID 20190307070706.7607-3-po-hsu.lin@canonical.com
State New
Headers show
Series [D/linux-kvm,SRU,1/1] UBUNTU: [Config]: disable CONFIG_SECURITY_SELINUX_DISABLE | expand

Commit Message

Po-Hsu Lin March 7, 2019, 7:07 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1812153

CONFIG_SECURITY_SELINUX_DISABLE is expected to be disabled.

This option allows disabling selinux after boot and it will conflict
with read-only LSM structures. Since Ubuntu is primarily using AppArmor
for its LSM, it makes sense to drop this feature in favor of the
protections offered by __ro_after_init markings on the LSM structures.
(LP: #1680315)

Disable it to match the requirement in the kernel-security test suite.

Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
---
 debian.kvm/config/config.common.ubuntu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Seth Forshee March 27, 2019, 3:41 p.m. UTC | #1
On Thu, Mar 07, 2019 at 03:07:06PM +0800, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1812153
> 
> CONFIG_SECURITY_SELINUX_DISABLE is expected to be disabled.
> 
> This option allows disabling selinux after boot and it will conflict
> with read-only LSM structures. Since Ubuntu is primarily using AppArmor
> for its LSM, it makes sense to drop this feature in favor of the
> protections offered by __ro_after_init markings on the LSM structures.
> (LP: #1680315)
> 
> Disable it to match the requirement in the kernel-security test suite.
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>

Applied, thanks!
diff mbox series

Patch

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index 681f52c..253ea6a 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -2083,7 +2083,7 @@  CONFIG_SECURITY_SELINUX_BOOTPARAM=y
 CONFIG_SECURITY_SELINUX_BOOTPARAM_VALUE=0
 CONFIG_SECURITY_SELINUX_CHECKREQPROT_VALUE=0
 CONFIG_SECURITY_SELINUX_DEVELOP=y
-CONFIG_SECURITY_SELINUX_DISABLE=y
+# CONFIG_SECURITY_SELINUX_DISABLE is not set
 CONFIG_SECURITY_SMACK=y
 # CONFIG_SECURITY_SMACK_APPEND_SIGNALS is not set
 # CONFIG_SECURITY_SMACK_BRINGUP is not set