package/musl: remove rcrt1.o from target installation

Message ID 20190306163316.6117-1-norbert.lange@andritz.com
State Accepted
Headers show
Series
  • package/musl: remove rcrt1.o from target installation
Related show

Commit Message

Norbert Lange March 6, 2019, 4:33 p.m.
From: Norbert Lange <nolange79@gmail.com>

Signed-off-by: Norbert Lange <norbert.lange@andritz.com>
---
 package/musl/musl.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni March 6, 2019, 4:48 p.m. | #1
Hello Norbert,

Thanks for your patch!

On Wed,  6 Mar 2019 17:33:16 +0100
Norbert Lange <nolange79@gmail.com> wrote:

> From: Norbert Lange <nolange79@gmail.com>
> 
> Signed-off-by: Norbert Lange <norbert.lange@andritz.com>

Could you give some more details ?

In fact, your patch does not remove rcrt1.o from target installation:
it ensures that the target installation does *NOT* remove it from
TARGET_DIR.

Thanks!

Thomas
Norbert Lange March 6, 2019, 5:09 p.m. | #2
>
> Could you give some more details ?


 rcrt1.o is a new startup for "static-pie" apps, and only needed for building,
should not end up in the target filesystem

>
> In fact, your patch does not remove rcrt1.o from target installation:
> it ensures that the target installation does *NOT* remove it from
> TARGET_DIR.

One of us is eligible for a legasthenic fund, either its you or I am
a really badly affected cause I still cant find a fault in the patch.

Norbert
Thomas Petazzoni March 6, 2019, 9:54 p.m. | #3
Hello Norbert,

On Wed, 6 Mar 2019 18:09:19 +0100
Norbert Lange <nolange79@gmail.com> wrote:

> > Could you give some more details ?  
> 
> 
>  rcrt1.o is a new startup for "static-pie" apps, and only needed for building,
> should not end up in the target filesystem

OK.

> > In fact, your patch does not remove rcrt1.o from target installation:
> > it ensures that the target installation does *NOT* remove it from
> > TARGET_DIR.  
> 
> One of us is eligible for a legasthenic fund, either its you or I am
> a really badly affected cause I still cant find a fault in the patch.

It was me :-) The patch looks good!

Best regards,

Thomas
Thomas Petazzoni March 14, 2019, 10:13 p.m. | #4
On Wed,  6 Mar 2019 17:33:16 +0100
Norbert Lange <nolange79@gmail.com> wrote:

> From: Norbert Lange <nolange79@gmail.com>
> 
> Signed-off-by: Norbert Lange <norbert.lange@andritz.com>
> ---
>  package/musl/musl.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Patch

diff --git a/package/musl/musl.mk b/package/musl/musl.mk
index 90c753926e..ff807c0cba 100644
--- a/package/musl/musl.mk
+++ b/package/musl/musl.mk
@@ -58,7 +58,7 @@  endef
 define MUSL_INSTALL_TARGET_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
 		DESTDIR=$(TARGET_DIR) install-libs
-	$(RM) $(addprefix $(TARGET_DIR)/lib/,crt1.o crtn.o crti.o Scrt1.o)
+	$(RM) $(addprefix $(TARGET_DIR)/lib/,crt1.o crtn.o crti.o rcrt1.o Scrt1.o)
 endef
 
 $(eval $(generic-package))