| Message ID | 20190306114227.9125-1-dgilbert@redhat.com |
|---|---|
| State | New |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20190306114227.9125-1-dgilbert@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190306114227.9125-1-dgilbert@redhat.com
Subject: [Qemu-devel] [PULL 00/22] migration queue
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20190306114227.9125-1-dgilbert@redhat.com -> patchew/20190306114227.9125-1-dgilbert@redhat.com
Switched to a new branch 'test'
060f501bdc qapi/migration.json: Remove a variable that doesn't exist in example
79985c89a1 Migration/colo.c: Make COLO node running after failover
04fa41f3fe Migration/colo.c: Fix double close bug when occur COLO failover
fad6a7a2fe virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT
ea055843a6 migration/ram.c: add the free page optimization enable flag
04f12f4493 migration/ram.c: add a notifier chain for precopy
acffe8fac2 migration: API to clear bits of guest free pages from the dirty bitmap
28ba7920b5 migration: use bitmap_mutex in migration_bitmap_clear_dirty
50d141e21b bitmap: bitmap_count_one_with_offset
d09d8c34fe bitmap: fix bitmap_count_one
0b3f876f73 tests: Add basic migration precopy tcp test
b9b8858224 migration: Create socket-address parameter
c3e10e38d0 tests: Add migration xbzrle test
9891a178e1 migration: Add capabilities validation
a3ba078ea3 tests/migration-test: Add a test for ignore-shared capability
40a11f6d72 migration: Add an ability to ignore shared RAM blocks
b08a8bcb8f migration: Introduce ignore-shared capability
502f3e7690 exec: Change RAMBlockIterFunc definition
1419fc4f68 migration/rdma: clang compilation fix
af4a8e34f7 migration: Cleanup during exit
6078675984 migration/rdma: Fix qemu_rdma_cleanup null check
f414a0d58c migration: Fix cancel state
=== OUTPUT BEGIN ===
1/22 Checking commit f414a0d58c61 (migration: Fix cancel state)
2/22 Checking commit 60786759846a (migration/rdma: Fix qemu_rdma_cleanup null check)
3/22 Checking commit af4a8e34f76a (migration: Cleanup during exit)
4/22 Checking commit 1419fc4f68a6 (migration/rdma: clang compilation fix)
5/22 Checking commit 502f3e769033 (exec: Change RAMBlockIterFunc definition)
6/22 Checking commit b08a8bcb8f55 (migration: Introduce ignore-shared capability)
7/22 Checking commit 40a11f6d720b (migration: Add an ability to ignore shared RAM blocks)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#149: FILE: migration/ram.c:169:
+#define RAMBLOCK_FOREACH_NOT_IGNORED(block) \
+ INTERNAL_RAMBLOCK_FOREACH(block) \
+ if (ramblock_is_ignored(block)) {} else
ERROR: trailing statements should be on next line
#151: FILE: migration/ram.c:171:
+ if (ramblock_is_ignored(block)) {} else
total: 2 errors, 0 warnings, 386 lines checked
Patch 7/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit a3ba078ea311 (tests/migration-test: Add a test for ignore-shared capability)
ERROR: if this code is redundant consider removing it
#235: FILE: tests/migration-test.c:829:
+#if 0
total: 1 errors, 0 warnings, 255 lines checked
Patch 8/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/22 Checking commit 9891a178e1cb (migration: Add capabilities validation)
10/22 Checking commit c3e10e38d0a5 (tests: Add migration xbzrle test)
11/22 Checking commit b9b885822408 (migration: Create socket-address parameter)
12/22 Checking commit 0b3f876f7352 (tests: Add basic migration precopy tcp test)
13/22 Checking commit d09d8c34fe5f (bitmap: fix bitmap_count_one)
14/22 Checking commit 50d141e21bda (bitmap: bitmap_count_one_with_offset)
15/22 Checking commit 28ba7920b5e4 (migration: use bitmap_mutex in migration_bitmap_clear_dirty)
16/22 Checking commit acffe8fac2f4 (migration: API to clear bits of guest free pages from the dirty bitmap)
17/22 Checking commit 04f12f44931e (migration/ram.c: add a notifier chain for precopy)
18/22 Checking commit ea055843a6f6 (migration/ram.c: add the free page optimization enable flag)
19/22 Checking commit fad6a7a2fe5e (virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT)
20/22 Checking commit 04fa41f3fed6 (Migration/colo.c: Fix double close bug when occur COLO failover)
21/22 Checking commit 79985c89a1be (Migration/colo.c: Make COLO node running after failover)
22/22 Checking commit 060f501bdcb2 (qapi/migration.json: Remove a variable that doesn't exist in example)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190306114227.9125-1-dgilbert@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Wed, 6 Mar 2019 at 11:44, Dr. David Alan Gilbert (git) <dgilbert@redhat.com> wrote: > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > > The following changes since commit b5b6b2b912bbcd3953407da938a8f969577ad3a1: > > Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-mar-05-2019' into staging (2019-03-05 21:07:29 +0000) > > are available in the Git repository at: > > git://github.com/dagrh/qemu.git tags/pull-migration-20190306a > > for you to fetch changes up to b5922fc5891261153f1a0f20e814c620aabeb6ac: > > qapi/migration.json: Remove a variable that doesn't exist in example (2019-03-06 10:49:18 +0000) > > ---------------------------------------------------------------- > Migation pull 2019-03-06 > > (This replaces the pull sent yesterday) > > a) 4 small fixes including the cancel problem > that caused the ahci migration test to fail > intermittently > b) Yury's ignore-shared feature > c) Juan's extra tests > d) Wei Wang's free page hinting > e) Some Colo fixes from Zhang Chen > > Diff from yesterdays pull: > 1) A missing fix of mine (cleanup during exit) > 2) Changes from Eric/Markus on 'Create socket-address parameter' > > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0 for any user-visible changes. -- PMM
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> The following changes since commit b5b6b2b912bbcd3953407da938a8f969577ad3a1: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-mar-05-2019' into staging (2019-03-05 21:07:29 +0000) are available in the Git repository at: git://github.com/dagrh/qemu.git tags/pull-migration-20190306a for you to fetch changes up to b5922fc5891261153f1a0f20e814c620aabeb6ac: qapi/migration.json: Remove a variable that doesn't exist in example (2019-03-06 10:49:18 +0000) ---------------------------------------------------------------- Migation pull 2019-03-06 (This replaces the pull sent yesterday) a) 4 small fixes including the cancel problem that caused the ahci migration test to fail intermittently b) Yury's ignore-shared feature c) Juan's extra tests d) Wei Wang's free page hinting e) Some Colo fixes from Zhang Chen Diff from yesterdays pull: 1) A missing fix of mine (cleanup during exit) 2) Changes from Eric/Markus on 'Create socket-address parameter' ---------------------------------------------------------------- Dr. David Alan Gilbert (3): migration: Fix cancel state migration/rdma: Fix qemu_rdma_cleanup null check migration: Cleanup during exit Juan Quintela (3): tests: Add migration xbzrle test migration: Create socket-address parameter tests: Add basic migration precopy tcp test Marcel Apfelbaum (1): migration/rdma: clang compilation fix Wei Wang (7): bitmap: fix bitmap_count_one bitmap: bitmap_count_one_with_offset migration: use bitmap_mutex in migration_bitmap_clear_dirty migration: API to clear bits of guest free pages from the dirty bitmap migration/ram.c: add a notifier chain for precopy migration/ram.c: add the free page optimization enable flag virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Yury Kotov (5): exec: Change RAMBlockIterFunc definition migration: Introduce ignore-shared capability migration: Add an ability to ignore shared RAM blocks tests/migration-test: Add a test for ignore-shared capability migration: Add capabilities validation Zhang Chen (3): Migration/colo.c: Fix double close bug when occur COLO failover Migration/colo.c: Make COLO node running after failover qapi/migration.json: Remove a variable that doesn't exist in example exec.c | 38 ++--- hmp.c | 33 ++++ hw/virtio/virtio-balloon.c | 263 +++++++++++++++++++++++++++++++ include/exec/cpu-common.h | 7 +- include/hw/virtio/virtio-balloon.h | 28 +++- include/migration/misc.h | 24 ++- include/qemu/bitmap.h | 17 ++ migration/colo.c | 2 +- migration/migration.c | 62 +++++++- migration/migration.h | 9 +- migration/postcopy-ram.c | 48 +++--- migration/ram.c | 231 ++++++++++++++++++++++++---- migration/rdma.c | 18 ++- migration/savevm.c | 152 ++++++++++++++++++ migration/socket.c | 11 ++ qapi/migration.json | 13 +- stubs/ram-block.c | 15 ++ tests/migration-test.c | 308 +++++++++++++++++++++++++++++++++---- util/vfio-helpers.c | 6 +- vl.c | 8 +- 20 files changed, 1167 insertions(+), 126 deletions(-)