| Message ID | 20190306111208.7454-5-patrick.havelange@essensium.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | FlexTimer Module Quadrature decoder counter | expand |
On Wed, Mar 06, 2019 at 12:12:05PM +0100, Patrick Havelange wrote: > FlexTimer quadrature decoder driver. > > Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com> > Reviewed-by: Esben Haabendal <esben@haabendal.dk> > --- > Changes v2 > - None > --- > .../bindings/counter/ftm-quaddec.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 Documentation/devicetree/bindings/counter/ftm-quaddec.txt > > diff --git a/Documentation/devicetree/bindings/counter/ftm-quaddec.txt b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt > new file mode 100644 > index 000000000000..4d18cd722074 > --- /dev/null > +++ b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt > @@ -0,0 +1,18 @@ > +FlexTimer Quadrature decoder counter > + > +This driver exposes a simple counter for the quadrature decoder mode. Seems like this is more a mode of a h/w block than describing a h/w block. Bindings should do the latter. > + > +Required properties: > +- compatible: Must be "fsl,ftm-quaddec". > +- reg: Must be set to the memory region of the flextimer. > + > +Optional property: > +- big-endian: Access the device registers in big-endian mode. > + > +Example: > + counter0: counter@29d0000 { > + compatible = "fsl,ftm-quaddec"; > + reg = <0x0 0x29d0000 0x0 0x10000>; > + big-endian; > + status = "disabled"; > + }; > -- > 2.19.1 >
On Tue, 12 Mar 2019 14:09:52 -0500 Rob Herring <robh@kernel.org> wrote: > On Wed, Mar 06, 2019 at 12:12:05PM +0100, Patrick Havelange wrote: > > FlexTimer quadrature decoder driver. > > > > Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com> > > Reviewed-by: Esben Haabendal <esben@haabendal.dk> > > --- > > Changes v2 > > - None > > --- > > .../bindings/counter/ftm-quaddec.txt | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/counter/ftm-quaddec.txt > > > > diff --git a/Documentation/devicetree/bindings/counter/ftm-quaddec.txt b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt > > new file mode 100644 > > index 000000000000..4d18cd722074 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt > > @@ -0,0 +1,18 @@ > > +FlexTimer Quadrature decoder counter > > + > > +This driver exposes a simple counter for the quadrature decoder mode. > > Seems like this is more a mode of a h/w block than describing a h/w > block. Bindings should do the latter. The snag is that we need to dig ourselves out of the hole set by: fsl,vf610-ftm-pwm etc. Documentation/devicetree/bindings/pwm/pwm-fsl-ftm.txt Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt (I'm assuming these are the same IP block). Can probably be sorted out though. One core driver binds against the ftm and deals with instantiating the others depending on the configuration (note that this mode for instance does make sense in DT as it's really reflecting the fact there is a quadrature encoder connected to the ftm). Fiddly though :) J > > > + > > +Required properties: > > +- compatible: Must be "fsl,ftm-quaddec". > > +- reg: Must be set to the memory region of the flextimer. > > + > > +Optional property: > > +- big-endian: Access the device registers in big-endian mode. > > + > > +Example: > > + counter0: counter@29d0000 { > > + compatible = "fsl,ftm-quaddec"; > > + reg = <0x0 0x29d0000 0x0 0x10000>; > > + big-endian; > > + status = "disabled"; > > + }; > > -- > > 2.19.1 > >
[Full disclosure: I'm a colleague of Patrick.] On 2019-03-16 14:21:38, Jonathan Cameron wrote: > On Tue, 12 Mar 2019 14:09:52 -0500 > Rob Herring <robh@kernel.org> wrote: > > > On Wed, Mar 06, 2019 at 12:12:05PM +0100, Patrick Havelange wrote: > > > FlexTimer quadrature decoder driver. > > > > > > Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com> > > > Reviewed-by: Esben Haabendal <esben@haabendal.dk> > > > --- > > > Changes v2 > > > - None > > > --- > > > .../bindings/counter/ftm-quaddec.txt | 18 ++++++++++++++++++ > > > 1 file changed, 18 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/counter/ftm-quaddec.txt > > > > > > diff --git a/Documentation/devicetree/bindings/counter/ftm-quaddec.txt \ > > > b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt new file mode 100644 > > > index 000000000000..4d18cd722074 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt > > > @@ -0,0 +1,18 @@ > > > +FlexTimer Quadrature decoder counter > > > + > > > +This driver exposes a simple counter for the quadrature decoder mode. > > > > Seems like this is more a mode of a h/w block than describing a h/w > > block. Bindings should do the latter. As Jonathan writes below, it really is a "hardware mode", since it is tied very closely to how the device is wired up. Basically, the same block can be used for pretty diverse functions: a PWM where the pins are output, a counter where the pins are input, or a timer where the interrupt or timer value is used purely internally. This smells a bit like an MFD, but IMO it really isn't, because only one of the functions can be enabled. So indeed, it's more like a mode. > The snag is that we need to dig ourselves out of the hole set by: > fsl,vf610-ftm-pwm etc. > > Documentation/devicetree/bindings/pwm/pwm-fsl-ftm.txt > Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt > (I'm assuming these are the same IP block). > > Can probably be sorted out though. One core driver binds against the > ftm and deals with instantiating the others depending on the configuration > (note that this mode for instance does make sense in DT as it's > really reflecting the fact there is a quadrature encoder > connected to the ftm). > > Fiddly though :) The way I see it, there are 3 ways this could be modelled (other than the current way: several nodes with the same address). 1. The SoC's .dtsi defines a single node, and the compatible string (which would be defined by the board .dts) both enables the node and sets the compatible string. The .dtsi would also define the static properties of all the different functions: some "static" properties, e.g. reg, but also some function specific-properties, e.g.#pwm-cells (only for PWM), interrupts (only for timer). The driver (selected through compatible) anyway only uses the properties that it needs, so it doesn't hurt to have those other-function properties there. 2. Like 1, but instead of defining the compatible string in the .dts, use a single compatible string for all the different drivers which is set in the .dtsi, and add a mode property (to be set in the .dts) to select the driver. The selection can be done either by having a top-level driver that calls out to the subsystem-specific one based on the mode, or by having each driver bail out of its probe function if the mode is not as expected. 3. Have a common node that essentially does nothing except occupy the memory resource, and sub-nodes for each function. This can again be combined with a common driver that does the common resource allocation, or each function driver can just look at its parent node to find the resources. A disadvantage of this one is that it is possible to enable several functions in the DT, while only one can actually work. Option 3 is what is used for e.g. stm32-lptimer. It also uses an mfd driver to model the common part. But possibly it actually allows the different functions to operate simultaneously. Option 3 has the additional disadvantage that it requires changes in existing DTs for ftm-pwm and ftm-timer, because some properties are moved one level down. Since we need to retain backward compatibility, we'd need to look for those properties both in the node itself and in the parent node. In particular, the common driver part would be fairly complicated to implement in a backward compatible way because it's not enough to do a simple devm_of_platform_populate(). Personally I don't like the common driver part too much. This common driver does almost nothing (iomap and clock) and it creates dependencies between different drivers. Combined with the backward compatibility problem, I don't see much point to it. I personally like option 2 the most. It's easy to be backward compatible (if mode is not set, revert to the current behaviour, i.e. assume that the compatible string has encoded the mode and that you're the only driver). It doesn't introduce subnodes that have no hardware equivalent. The only messy thing about it is that properties belonging to the different modes are mixed together in a single node. And also, I don't think this kind of model is currently used anywhere else in the kernel. Regards, Arnout
On Tue, Mar 26, 2019 at 10:43 AM Arnout Vandecappelle <arnout@mind.be> wrote: > > [Full disclosure: I'm a colleague of Patrick.] > > On 2019-03-16 14:21:38, Jonathan Cameron wrote: > > > On Tue, 12 Mar 2019 14:09:52 -0500 > > Rob Herring <robh@kernel.org> wrote: > > > > > On Wed, Mar 06, 2019 at 12:12:05PM +0100, Patrick Havelange wrote: > > > > FlexTimer quadrature decoder driver. > > > > > > > > Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com> > > > > Reviewed-by: Esben Haabendal <esben@haabendal.dk> > > > > --- > > > > Changes v2 > > > > - None > > > > --- > > > > .../bindings/counter/ftm-quaddec.txt | 18 ++++++++++++++++++ > > > > 1 file changed, 18 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/counter/ftm-quaddec.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/counter/ftm-quaddec.txt \ > > > > b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt new file mode 100644 > > > > index 000000000000..4d18cd722074 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt > > > > @@ -0,0 +1,18 @@ > > > > +FlexTimer Quadrature decoder counter > > > > + > > > > +This driver exposes a simple counter for the quadrature decoder mode. > > > > > > Seems like this is more a mode of a h/w block than describing a h/w > > > block. Bindings should do the latter. > > > As Jonathan writes below, it really is a "hardware mode", since it is tied > very closely to how the device is wired up. Okay, as it is describing what is attached, I agree. The thing to consider is whether you will need to describe more than just the mode. We often start adding properties of an attached device in the controller node only to realize later that we should have a node for the device itself. Even for something as simple as an LED we've ended up there. > Basically, the same block can be used for pretty diverse functions: a PWM where > the pins are output, a counter where the pins are input, or a timer where the > interrupt or timer value is used purely internally. > > This smells a bit like an MFD, but IMO it really isn't, because only one of the > functions can be enabled. So indeed, it's more like a mode. Agreed. > > The snag is that we need to dig ourselves out of the hole set by: > > fsl,vf610-ftm-pwm etc. > > > > Documentation/devicetree/bindings/pwm/pwm-fsl-ftm.txt > > Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt > > (I'm assuming these are the same IP block). > > > > Can probably be sorted out though. One core driver binds against the > > ftm and deals with instantiating the others depending on the configuration > > (note that this mode for instance does make sense in DT as it's > > really reflecting the fact there is a quadrature encoder > > connected to the ftm). > > > > Fiddly though :) > > > The way I see it, there are 3 ways this could be modelled (other than the > current way: several nodes with the same address). > > > 1. The SoC's .dtsi defines a single node, and the compatible string (which would > be defined by the board .dts) both enables the node and sets the compatible > string. The .dtsi would also define the static properties of all the different > functions: some "static" properties, e.g. reg, but also some function > specific-properties, e.g.#pwm-cells (only for PWM), interrupts (only for timer). > The driver (selected through compatible) anyway only uses the properties that it > needs, so it doesn't hurt to have those other-function properties there. > > > 2. Like 1, but instead of defining the compatible string in the .dts, use a > single compatible string for all the different drivers which is set in the > .dtsi, and add a mode property (to be set in the .dts) to select the driver. The > selection can be done either by having a top-level driver that calls out to the > subsystem-specific one based on the mode, or by having each driver bail out of > its probe function if the mode is not as expected. > > > 3. Have a common node that essentially does nothing except occupy the memory > resource, and sub-nodes for each function. This can again be combined with a > common driver that does the common resource allocation, or each function driver > can just look at its parent node to find the resources. A disadvantage of this > one is that it is possible to enable several functions in the DT, while only one > can actually work. > > > Option 3 is what is used for e.g. stm32-lptimer. It also uses an mfd driver to > model the common part. But possibly it actually allows the different functions > to operate simultaneously. I'm not all that thrilled with how that one ended up. > Option 3 has the additional disadvantage that it requires changes in existing > DTs for ftm-pwm and ftm-timer, because some properties are moved one level down. > Since we need to retain backward compatibility, we'd need to look for those > properties both in the node itself and in the parent node. In particular, the > common driver part would be fairly complicated to implement in a backward > compatible way because it's not enough to do a simple devm_of_platform_populate(). > > > Personally I don't like the common driver part too much. This common driver > does almost nothing (iomap and clock) and it creates dependencies between > different drivers. Combined with the backward compatibility problem, I don't see > much point to it. > > > I personally like option 2 the most. It's easy to be backward compatible (if > mode is not set, revert to the current behaviour, i.e. assume that the > compatible string has encoded the mode and that you're the only driver). It > doesn't introduce subnodes that have no hardware equivalent. The only messy > thing about it is that properties belonging to the different modes are mixed > together in a single node. And also, I don't think this kind of model is > currently used anywhere else in the kernel. Option 2 seems best to me. Rob
diff --git a/Documentation/devicetree/bindings/counter/ftm-quaddec.txt b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt new file mode 100644 index 000000000000..4d18cd722074 --- /dev/null +++ b/Documentation/devicetree/bindings/counter/ftm-quaddec.txt @@ -0,0 +1,18 @@ +FlexTimer Quadrature decoder counter + +This driver exposes a simple counter for the quadrature decoder mode. + +Required properties: +- compatible: Must be "fsl,ftm-quaddec". +- reg: Must be set to the memory region of the flextimer. + +Optional property: +- big-endian: Access the device registers in big-endian mode. + +Example: + counter0: counter@29d0000 { + compatible = "fsl,ftm-quaddec"; + reg = <0x0 0x29d0000 0x0 0x10000>; + big-endian; + status = "disabled"; + };