| Message ID | 1551863246-11656-3-git-send-email-biju.das@bp.renesas.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add USB3.0 and TI HD3SS3220 driver support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Wed, Mar 06, 2019 at 09:07:19AM +0000, Biju Das wrote: > Add support for renesas_usb3 to receive connect and disconnect notification > using extcon framework. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > index d366555..ae35674 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > @@ -21,6 +21,8 @@ Required properties: > Optional properties: > - phys: phandle + phy specifier pair > - phy-names: must be "usb" > + - extcon: phandle for the extcon device renesas usb3 uses to detect > + connect/disconnect events. Please don't use extcon and use usb-connector binding instead. > > Example of R-Car H3 ES1.x: > usb3_peri0: usb@ee020000 { > -- > 2.7.4 >
Hi Rob, Thanks for the feedback. > Subject: Re: [PATCH 2/9] dt-bindings: usb: renesas_usb3: add extcon support > > On Wed, Mar 06, 2019 at 09:07:19AM +0000, Biju Das wrote: > > Add support for renesas_usb3 to receive connect and disconnect > > notification using extcon framework. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > --- > > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > index d366555..ae35674 100644 > > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > @@ -21,6 +21,8 @@ Required properties: > > Optional properties: > > - phys: phandle + phy specifier pair > > - phy-names: must be "usb" > > + - extcon: phandle for the extcon device renesas usb3 uses to detect > > + connect/disconnect events. > > Please don't use extcon and use usb-connector binding instead. I have switched to usb role switch framework instead of extcon and sent V2 based on the below feedback. https://patchwork.kernel.org/patch/10840659/ On V2, I have sent a patch series which uses " usb-connector " binding [1] and "usb-role-switch" property[2] [1] https://patchwork.kernel.org/patch/10852495/ [2] https://patchwork.kernel.org/patch/10852497/ Support for "usb-role-switch" compatible can be found in the below patch set https://patchwork.kernel.org/project/linux-usb/list/?series=97707 Please can you comment, is this approach is acceptable or not? Regards, Biju
diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt b/Documentation/devicetree/bindings/usb/renesas_usb3.txt index d366555..ae35674 100644 --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt @@ -21,6 +21,8 @@ Required properties: Optional properties: - phys: phandle + phy specifier pair - phy-names: must be "usb" + - extcon: phandle for the extcon device renesas usb3 uses to detect + connect/disconnect events. Example of R-Car H3 ES1.x: usb3_peri0: usb@ee020000 {
Add support for renesas_usb3 to receive connect and disconnect notification using extcon framework. Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++ 1 file changed, 2 insertions(+)