From patchwork Tue Mar 5 20:18:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Johnson X-Patchwork-Id: 1051989 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=svenyonson.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="baCxqcjX"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=svenyonson-com.20150623.gappssmtp.com header.i=@svenyonson-com.20150623.gappssmtp.com header.b="eIrqsbop"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44DSsR3Prbz9s4Y for ; Wed, 6 Mar 2019 07:19:07 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Date:Message-Id:Subject:Mime-Version :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=DCMqvP8dstnOhOEhcMy29xVpAAe5ZuHxWaPvk/f5pKg=; b=baCxqcjXC604Ft PP5YibylSvQicfC/47uWwICI9LWeAtP05odhGGwwMXQFTrpKnLPzRnoT2642FI6NrdQR8X1AD2YxA xXQ+/heeLwQ/Ze10KUQEs6Syy54FARxaI3lMF+wCNkMibMfKfhsqwP+ddlggNeOyR1fZyVY9fG6kT A6cuKMLioYVEz7ZlCaoO8eFygfy69W4Ys4Ivgoi6+AS91vN8dwfMVnoEH1DSA47zM4+AIV/EHYlef PM2wSlYIlWoZHZQqiWqRknx1JQpdFFxJIa4TOyCVkqP2V6BPYy+JUZu67dXjMCCiZ9v037k5I4ISY R8gZ9bRxRKLBwasUIe6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1GWZ-0004dj-5C; Tue, 05 Mar 2019 20:18:51 +0000 Received: from mail-it1-x130.google.com ([2607:f8b0:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1GWT-0004dM-Pc for hostap@lists.infradead.org; Tue, 05 Mar 2019 20:18:49 +0000 Received: by mail-it1-x130.google.com with SMTP id l15so6541243iti.4 for ; Tue, 05 Mar 2019 12:18:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenyonson-com.20150623.gappssmtp.com; s=20150623; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=IgAcdutFmKQ5EMowmSpZXGHvw8/dTsRJYTO3fGQw/YY=; b=eIrqsbopvsRUan3g65Bp1kMXnvC9s6EYSERCauyrrdorDIPJdiyeJVZ0u5bgnJSX4I QtLpsh6mNg3+omPr3sedPmewqgl4SPUyWcI1Rl7n4SEO+qMYshktfnbKapyHaJ/CQ/bw Ker7IwQ3b0qq5zFwfhuQj6+eOd0CPO/5VjB6MQsqZQAGPqepM8m0S+gg2EUM2qSNSnXe qFCG+wRt7yAdOP/MubSuc3vzphL6Om92yghB0+bVtL0cagK8ubaW1AAP0HeEYzxV7T4F 0hAH3oFGCWDu08c0V2nrtyr3eJQm8BU3ZlAf316ediDoAibBX1dWxuLxDgnyRa/8dD5q 0J6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=IgAcdutFmKQ5EMowmSpZXGHvw8/dTsRJYTO3fGQw/YY=; b=cC0lrzlakhN/mAxYbJwSZ4UmZM+2taC/z2iMqAaQekiW6UglEsB5HsBDROgRPbxa0P hhrmcwUebBEcpFgKkDaYEBgqyJV6OZkjdfnnHYsATL5YtmCEQIDVhM+CFYJIaLC7aad+ fZyCniGCh1a47jt6RgGHDjuqqvTGP9BQecZPhtoMKSNrhoo1gnxEbXN/uzzDXcw2aq4W 03bWyBUl35Qh0hjJYnHQoIrSXE1ij0sS5FMK1BJJ7V6gBSymAU8R6ulVtDx1FrUioTqs VGQOjxQVFrP9A1K+N5esPnBhUQNGtRnkrUnUF2HIoqmKKY9ASbj/Z/3S+REkXSB26OLt p8Aw== X-Gm-Message-State: APjAAAXLcc7TGAc41k7tzJeVCtFzBo068rsrjRLoSfTEyq5EHeALJPEY V17sapuM26NMz4+lKPZznrovTqILPkM= X-Google-Smtp-Source: APXvYqxfN8VgoXhrp/bTXaV5MRUEx0AxqMdBO18u127wJJERyw7ae5229qKNXyC33Q8eP3IES56ULw== X-Received: by 2002:a02:e04:: with SMTP id 4mr2247130jae.75.1551817124208; Tue, 05 Mar 2019 12:18:44 -0800 (PST) Received: from ?IPv6:2620::2b10:10:7013:91a8:daca:d19c? ([2620:0:2b10:10:7013:91a8:daca:d19c]) by smtp.gmail.com with ESMTPSA id q133sm281658itb.19.2019.03.05.12.18.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Mar 2019 12:18:43 -0800 (PST) From: Steve Johnson Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: wpa_supplicant logfile ignored if syslog specified Message-Id: <089E7295-3D84-43E5-9B07-07C09B78C05C@svenyonson.com> Date: Tue, 5 Mar 2019 13:18:41 -0700 To: hostap@lists.infradead.org X-Mailer: Apple Mail (2.3273) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_121845_882418_8D22965A X-CRM114-Status: GOOD ( 10.18 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:130 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 DKIMWL_WL_MED DKIMwl.org - Whitelisted Medium sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org When wpa_supplicant is invoked via ifup and a logfile is specified in /etc/network/interfaces, the correct logfile switch is generated, but /etc/wpa_supplicant/functions.sh always includes "-s" (syslog) as a default option. When both -f and -s are present, the logfile is opened but never written to and debug output instead goes to syslog. I'm not sure if this is the proper fix, but it is working in my case. diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c index e0ee553..6150c1a 100644 --- a/wpa_supplicant/wpa_supplicant.c +++ b/wpa_supplicant/wpa_supplicant.c @@ -6264,10 +6264,12 @@ struct wpa_global * wpa_supplicant_init(struct wpa_params *params) if (params->wpa_debug_file_path) wpa_debug_open_file(params->wpa_debug_file_path); - else + else { wpa_debug_setup_stdout(); - if (params->wpa_debug_syslog) - wpa_debug_open_syslog(); + // only open syslog if logfile not specified + if (params->wpa_debug_syslog) + wpa_debug_open_syslog(); + } if (params->wpa_debug_tracing) { ret = wpa_debug_open_linux_tracing(); if (ret) {