From patchwork Mon Jul 18 02:52:26 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongqiang Yang X-Patchwork-Id: 105146 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 65837B6F75 for ; Mon, 18 Jul 2011 12:56:52 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752191Ab1GRC4v (ORCPT ); Sun, 17 Jul 2011 22:56:51 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:65169 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751736Ab1GRC4v (ORCPT ); Sun, 17 Jul 2011 22:56:51 -0400 Received: by iyb12 with SMTP id 12so2725572iyb.19 for ; Sun, 17 Jul 2011 19:56:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=JJaQaEFvf+rVlJeracr958JTuxkNWRib87HDLGnsl40=; b=Ujol8gNLuu53HmSEwBDRIOgDpDMiFQyBX31ian6lcXRooJNh3IstmpW+XJQqahVs8l B7yNN1A/OK6vBzxB9SXvAGoqf2FCNwLHWn+VnxBrhbXKGehHTI9G7lTrPpWW9mIc3D2w jOVWKazT26KTklC9ZM3rz0ZIVgk1dGJMvTaO8= Received: by 10.231.83.20 with SMTP id d20mr5319380ibl.152.1310957810535; Sun, 17 Jul 2011 19:56:50 -0700 (PDT) Received: from localhost.localdomain ([159.226.43.42]) by mx.google.com with ESMTPS id y3sm2592761ibc.37.2011.07.17.19.56.48 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 17 Jul 2011 19:56:50 -0700 (PDT) From: Yongqiang Yang To: linux-ext4@vger.kernel.org Cc: aedilger@gmail.com, Yongqiang Yang Subject: [PATCH 03/12] ext4: prevent a fs without journal from being resized Date: Mon, 18 Jul 2011 10:52:26 +0800 Message-Id: <1310957555-15617-4-git-send-email-xiaoqiangnk@gmail.com> X-Mailer: git-send-email 1.7.5.1 In-Reply-To: <1310957555-15617-1-git-send-email-xiaoqiangnk@gmail.com> References: <1310957555-15617-1-git-send-email-xiaoqiangnk@gmail.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org This patch prevents a fs without journal from being resized, because it is easy to detroy the fs. Signed-off-by: Yongqiang Yang --- fs/ext4/resize.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 53d9795..33ab40d 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -33,6 +33,16 @@ int ext4_resize_begin(struct super_block *sb) return -EPERM; } + /* + * We are not allowed to do online-resizing on a filesystem without + * journal, otherwise, it is easy to destroy the filesystem. + */ + if (!EXT4_SB(sb)->s_journal) { + ext4_warning(sb, "There is no journal for the filesystem, " + "so online resizing is not allowed\n"); + return -EPERM; + } + if (test_and_set_bit_lock(EXT4_RESIZING, &EXT4_SB(sb)->s_resize_flags)) ret = -EBUSY;