Message ID | 20190304181813.8075-72-cota@braap.org |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=braap.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=braap.org header.i=@braap.org header.b="TwAEtCsr"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="Hx3kEf44"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44CqQN65XDz9s7h for <incoming@patchwork.ozlabs.org>; Tue, 5 Mar 2019 06:11:56 +1100 (AEDT) Received: from localhost ([127.0.0.1]:59386 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1h0t0E-0002pj-M8 for incoming@patchwork.ozlabs.org; Mon, 04 Mar 2019 14:11:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <cota@braap.org>) id 1h0sBG-0000YG-6y for qemu-devel@nongnu.org; Mon, 04 Mar 2019 13:19:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <cota@braap.org>) id 1h0sBF-0002Ia-DT for qemu-devel@nongnu.org; Mon, 04 Mar 2019 13:19:14 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:40953) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <cota@braap.org>) id 1h0sBF-0001r0-2M for qemu-devel@nongnu.org; Mon, 04 Mar 2019 13:19:13 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id C18A13738; Mon, 4 Mar 2019 13:18:31 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 04 Mar 2019 13:18:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=FucJmeXjUdnO1GReA2eG1lue63n+eBa4SoQQzFUg47I=; b=TwAEtCsrra+1 cmoOAob1qhEKG0mSXbvQdBsWeWGXJW/9MNsCCNdjGWj48rr5MoqGKXNKkNwbXzHt q61Q4/MGVjIuqD3JBtqHzbhNAISWuv7Q4Jii83QbSYJ05bk1tWR5+mNP0ILNfCZ4 yyuaObkH+JSkJ/XDnV7LW912kiBBjyY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=FucJmeXjUdnO1GReA2eG1lue63n+eBa4SoQQzFUg4 7I=; b=Hx3kEf44FkXJm+e94bN3UBqYyireaKTVM52kzEX/s+EnrGaNKQ+kGQ9DL k7U3UAPI9LlmAvcga3QIhJGiJHj+A9rleYvIo69gcDBDokNWeGotnBaYT2TiuR4x XM/594HG9Ec79L6hI/JPnqoqSURwPfSNmizwjIYVn9hafmyxZuDfjazfIUCAd+D4 B4H9Ws5jNIedTYeFhw5yghaqgFDJMDK0zpVIyTw+0DFunN9plaYHoqwGpfwBmE2N iPjjBhRGGPb0P7wESdjW2HsUeSgJCai1VuZ4ftYB4ofUFJfCv0hynMolZSe3GiIl j62d/cvsxzuwwTWCOLE6Y3XArNIdw== X-ME-Sender: <xms:92t9XJDsTsQ8v7Ag_m3p6g5uwjUoVySD-yDm2C8rgWc8YFWH4LqWXQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfedugdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepfdfgmhhi lhhiohcuifdrucevohhtrgdfuceotghothgrsegsrhgrrghprdhorhhgqeenucfkphepud dvkedrheelrddvtddrvdduieenucfrrghrrghmpehmrghilhhfrhhomheptghothgrsegs rhgrrghprdhorhhgnecuvehluhhsthgvrhfuihiivgepgeej X-ME-Proxy: <xmx:92t9XHqadX3F7jglVOD7FrtigrAJBNpiwBo5_0HbF2Z7AKbmIwxDVA> <xmx:92t9XMhrJ7YRUq6jrEH8mgEeJ1suoc-J7yxykit529rTRCdUYPscdg> <xmx:92t9XMBULSlRmlhlyxDAfZFT2KrBN3eb165-4M34NGmcTvvh7xMPNw> <xmx:92t9XABz-B5UEV-YaS4ifTuMB0u2ABKB15unBs-eT5-2GucEB50n_g> Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 1B7E31030F; Mon, 4 Mar 2019 13:18:31 -0500 (EST) From: "Emilio G. Cota" <cota@braap.org> To: qemu-devel@nongnu.org Date: Mon, 4 Mar 2019 13:18:11 -0500 Message-Id: <20190304181813.8075-72-cota@braap.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190304181813.8075-1-cota@braap.org> References: <20190304181813.8075-1-cota@braap.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 64.147.123.25 Subject: [Qemu-devel] [PATCH v7 71/73] cpus-common: release BQL earlier in run_on_cpu X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, Richard Henderson <richard.henderson@linaro.org> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
Series |
[v7,01/73] cpu: convert queued work to a QSIMPLEQ
|
expand
|
diff --git a/cpus-common.c b/cpus-common.c index 62e282bff1..1241024b2c 100644 --- a/cpus-common.c +++ b/cpus-common.c @@ -145,6 +145,11 @@ void run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data) return; } + /* We are going to sleep on the CPU lock, so release the BQL */ + if (has_bql) { + qemu_mutex_unlock_iothread(); + } + wi.func = func; wi.data = data; wi.done = false; @@ -153,21 +158,6 @@ void run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data) cpu_mutex_lock(cpu); queue_work_on_cpu_locked(cpu, &wi); - - /* - * We are going to sleep on the CPU lock, so release the BQL. - * - * During the transition to per-CPU locks, we release the BQL _after_ - * having kicked the destination CPU (from queue_work_on_cpu_locked above). - * This makes sure that the enqueued work will be seen by the CPU - * after being woken up from the kick, since the CPU sleeps on the BQL. - * Once we complete the transition to per-CPU locks, we will release - * the BQL earlier in this function. - */ - if (has_bql) { - qemu_mutex_unlock_iothread(); - } - while (!atomic_mb_read(&wi.done)) { CPUState *self_cpu = current_cpu;