| Message ID | 1551691021-31505-2-git-send-email-ping.bai@nxp.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Mon, Mar 4, 2019 at 3:12 AM Jacky Bai <ping.bai@nxp.com> wrote: > > Add the soc & board binding for i.MX8MM. > > Signed-off-by: Jacky Bai <ping.bai@nxp.com> > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 7e2cd6a..0620896 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -154,6 +154,12 @@ properties: > - const: compulab,cl-som-imx7 > - const: fsl,imx7d > > + - description: i.MX8MM based Boards > + items: The indentation is wrong (and is significant). 'items' should be aligned with 'description'. IOW, it should be 6 spaces. > + - enum: > + - fsl,imx8mm-evk # i.MX8MM EVK Board > + - const: fsl,imx8mm > + > - description: i.MX8QXP based Boards > items: > - enum: > -- > 1.9.1 >
On Mon, Mar 4, 2019 at 9:36 AM Rob Herring <robh+dt@kernel.org> wrote: > > On Mon, Mar 4, 2019 at 3:12 AM Jacky Bai <ping.bai@nxp.com> wrote: > > > > Add the soc & board binding for i.MX8MM. > > > > Signed-off-by: Jacky Bai <ping.bai@nxp.com> > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 7e2cd6a..0620896 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -154,6 +154,12 @@ properties: > > - const: compulab,cl-som-imx7 > > - const: fsl,imx7d > > > > + - description: i.MX8MM based Boards > > + items: > > The indentation is wrong (and is significant). 'items' should be > aligned with 'description'. IOW, it should be 6 spaces. Looking again, items is correct, it is description that needs 2 more spaces. Rob
> Subject: Re: [PATCH 2/3] dt-bindings: arm: imx: Add the soc binding for > imx8mm > > On Mon, Mar 4, 2019 at 9:36 AM Rob Herring <robh+dt@kernel.org> wrote: > > > > On Mon, Mar 4, 2019 at 3:12 AM Jacky Bai <ping.bai@nxp.com> wrote: > > > > > > Add the soc & board binding for i.MX8MM. > > > > > > Signed-off-by: Jacky Bai <ping.bai@nxp.com> > > > --- > > > Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > > index 7e2cd6a..0620896 100644 > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > @@ -154,6 +154,12 @@ properties: > > > - const: compulab,cl-som-imx7 > > > - const: fsl,imx7d > > > > > > + - description: i.MX8MM based Boards > > > + items: > > > > The indentation is wrong (and is significant). 'items' should be > > aligned with 'description'. IOW, it should be 6 spaces. > > Looking again, items is correct, it is description that needs 2 more spaces. > Thanks, will fix it in v2. BR > Rob
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 7e2cd6a..0620896 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -154,6 +154,12 @@ properties: - const: compulab,cl-som-imx7 - const: fsl,imx7d + - description: i.MX8MM based Boards + items: + - enum: + - fsl,imx8mm-evk # i.MX8MM EVK Board + - const: fsl,imx8mm + - description: i.MX8QXP based Boards items: - enum:
Add the soc & board binding for i.MX8MM. Signed-off-by: Jacky Bai <ping.bai@nxp.com> --- Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++ 1 file changed, 6 insertions(+)