From patchwork Sun Jul 17 15:11:22 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tao Ma X-Patchwork-Id: 105072 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3EEC2B6F82 for ; Mon, 18 Jul 2011 01:13:38 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755778Ab1GQPNe (ORCPT ); Sun, 17 Jul 2011 11:13:34 -0400 Received: from oproxy1-pub.bluehost.com ([66.147.249.253]:41915 "HELO oproxy1-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755027Ab1GQPNd (ORCPT ); Sun, 17 Jul 2011 11:13:33 -0400 Received: (qmail 20458 invoked by uid 0); 17 Jul 2011 15:13:32 -0000 Received: from unknown (HELO box585.bluehost.com) (66.147.242.185) by oproxy1.bluehost.com with SMTP; 17 Jul 2011 15:13:32 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=tao.ma; h=Received:From:To:Cc:Subject:Date:Message-Id:X-Mailer:In-Reply-To:References:X-Identified-User; b=oSS7etxUspbGYcSrjpmNMW5Oad2EV7AP0RYHLZaMRe7RsMn6Ox/w404dnRinZJD4gjb4zoSbXtOszpOZf9Izwr6ajLPKP+tdxcb0XBQ3c9inGqM+/n8y8wgLFkKClXh6; Received: from [221.217.31.170] (helo=localhost.localdomain) by box585.bluehost.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1QiT2B-0000dZ-IT; Sun, 17 Jul 2011 09:13:32 -0600 From: Tao Ma To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu Subject: [PATCH] ext4: Don't increase s_mb_buddies_generated in ext4_mb_release. Date: Sun, 17 Jul 2011 23:11:22 +0800 Message-Id: <1310915483-2906-2-git-send-email-tm@tao.ma> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1310915483-2906-1-git-send-email-tm@tao.ma> References: <1310915483-2906-1-git-send-email-tm@tao.ma> X-Identified-User: {1390:box585.bluehost.com:colyli:tao.ma} {sentby:smtp auth 221.217.31.170 authed with tm@tao.ma} Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Tao Ma In ext4_mb_release, we use s_mb_buddies_generated++. Although the output is OK, but I don't think we need this extra ++. Signed-off-by: Tao Ma --- fs/ext4/mballoc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index e7749b7..f56a592 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -2568,7 +2568,7 @@ int ext4_mb_release(struct super_block *sb) atomic_read(&sbi->s_mb_lost_chunks)); printk(KERN_INFO "EXT4-fs: mballoc: %lu generated and it took %Lu\n", - sbi->s_mb_buddies_generated++, + sbi->s_mb_buddies_generated, sbi->s_mb_generation_time); printk(KERN_INFO "EXT4-fs: mballoc: %u preallocated, %u discarded\n",