Patchwork [U-Boot,v2,2/2] add command fitupd to run an update from a FIT image

login
register
mail settings
Submitter Andreas Pretzsch
Date July 16, 2011, 3:51 p.m.
Message ID <1310831460-14450-3-git-send-email-apr@cn-eng.de>
Download mbox | patch
Permalink /patch/104980/
State Accepted
Commit 7130a579fdba5dd1bf99508fb0b1d13317542109
Delegated to: Wolfgang Denk
Headers show

Comments

Andreas Pretzsch - July 16, 2011, 3:51 p.m.
Command calls update_tftp() analogous to automatic update described
in doc/README.update.

Usage:
fitupd [addr]
        - run update from FIT image at addr
          or from tftp 'updatefile'

Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
---
Changes for v2:
   - void update_tftp() => int update_tftp(): return success/fail
---
 common/Makefile     |    1 +
 common/cmd_fitupd.c |   36 ++++++++++++++++++++++++++++++++++++
 doc/README.update   |    5 +++++
 3 files changed, 42 insertions(+), 0 deletions(-)
 create mode 100644 common/cmd_fitupd.c
Wolfgang Denk - July 26, 2011, 2:59 p.m.
Dear Andreas Pretzsch,

In message <1310831460-14450-3-git-send-email-apr@cn-eng.de> you wrote:
> Command calls update_tftp() analogous to automatic update described
> in doc/README.update.
> 
> Usage:
> fitupd [addr]
>         - run update from FIT image at addr
>           or from tftp 'updatefile'
> 
> Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
> ---
> Changes for v2:
>    - void update_tftp() => int update_tftp(): return success/fail
> ---
>  common/Makefile     |    1 +
>  common/cmd_fitupd.c |   36 ++++++++++++++++++++++++++++++++++++
>  doc/README.update   |    5 +++++
>  3 files changed, 42 insertions(+), 0 deletions(-)
>  create mode 100644 common/cmd_fitupd.c

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/common/Makefile b/common/Makefile
index 224b7cc..e92ee5b 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -94,6 +94,7 @@  COBJS-$(CONFIG_CMD_FAT) += cmd_fat.o
 COBJS-$(CONFIG_CMD_FDC)$(CONFIG_CMD_FDOS) += cmd_fdc.o
 COBJS-$(CONFIG_OF_LIBFDT) += cmd_fdt.o fdt_support.o
 COBJS-$(CONFIG_CMD_FDOS) += cmd_fdos.o
+COBJS-$(CONFIG_CMD_FITUPD) += cmd_fitupd.o
 COBJS-$(CONFIG_CMD_FLASH) += cmd_flash.o
 ifdef CONFIG_FPGA
 COBJS-$(CONFIG_CMD_FPGA) += cmd_fpga.o
diff --git a/common/cmd_fitupd.c b/common/cmd_fitupd.c
new file mode 100644
index 0000000..4d1192b
--- /dev/null
+++ b/common/cmd_fitupd.c
@@ -0,0 +1,36 @@ 
+/*
+ * (C) Copyright 2011
+ * Andreas Pretzsch, carpe noctem engineering, apr@cn-eng.de
+ *
+ * This file is released under the terms of GPL v2 and any later version.
+ * See the file COPYING in the root directory of the source tree for details.
+ */
+
+#include <common.h>
+#include <command.h>
+
+#if !defined(CONFIG_UPDATE_TFTP)
+#error "CONFIG_UPDATE_TFTP required"
+#endif
+
+extern int update_tftp(ulong addr);
+
+static int do_fitupd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+{
+	ulong addr = 0UL;
+
+	if (argc > 2)
+		return cmd_usage(cmdtp);
+
+	if (argc == 2)
+		addr = simple_strtoul(argv[1], NULL, 16);
+
+	return update_tftp(addr);
+}
+
+U_BOOT_CMD(fitupd, 2, 0, do_fitupd,
+	"update from FIT image",
+	"[addr]\n"
+	"\t- run update from FIT image at addr\n"
+	"\t  or from tftp 'updatefile'"
+);
diff --git a/doc/README.update b/doc/README.update
index 48f03b7..a7f4d9e 100644
--- a/doc/README.update
+++ b/doc/README.update
@@ -51,6 +51,11 @@  the mkimage tool. dtc tool with support for binary includes, e.g. in version
 to be prepared. Refer to the doc/uImage.FIT/ directory for more details on FIT
 images.
 
+This mechanism can be also triggered by the commmand "fitupd".
+If an optional, non-zero address is provided as argument, the TFTP transfer
+is skipped and the image at this address is used.
+The fitupd command is enabled by CONFIG_CMD_FITUPD.
+
 
 Example .its files
 ------------------