From patchwork Thu Feb 28 07:32:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kavyasree Kotagiri X-Patchwork-Id: 1049326 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=microchip.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="TZqW0vzK"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44945K3YsVz9s1b for ; Thu, 28 Feb 2019 18:32:37 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731688AbfB1Hce (ORCPT ); Thu, 28 Feb 2019 02:32:34 -0500 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:26780 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725905AbfB1Hce (ORCPT ); Thu, 28 Feb 2019 02:32:34 -0500 X-IronPort-AV: E=Sophos;i="5.58,422,1544511600"; d="scan'208";a="25364626" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES128-SHA; 28 Feb 2019 00:32:34 -0700 Received: from NAM05-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.76.37) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 28 Feb 2019 00:32:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector1-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R0WfJl3hh0tDQlFkt1nTXN6gADIaJPysPIuckLokLeY=; b=TZqW0vzK/znT+01PReVdB//1KdP1mskKf7gdhTZAveRL0iQEGbLOvDiGSUSxeT6pG4njYE9+lnWiS0VBg43FP1u272YC3djrrDLk3DUPmIuaJZV24c9I3Xp8ls9uRjK58Bv32dSOqjLioDKaNGo5p7zngcV+8o2OMeOgynrvOk8= Received: from BN6PR11MB4113.namprd11.prod.outlook.com (10.255.130.149) by BN6PR11MB0033.namprd11.prod.outlook.com (10.161.152.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.21; Thu, 28 Feb 2019 07:32:22 +0000 Received: from BN6PR11MB4113.namprd11.prod.outlook.com ([fe80::9d6d:2123:bf8b:ca8a]) by BN6PR11MB4113.namprd11.prod.outlook.com ([fe80::9d6d:2123:bf8b:ca8a%4]) with mapi id 15.20.1643.019; Thu, 28 Feb 2019 07:32:22 +0000 From: To: , CC: , , , , Subject: [PATCH] net: mscc: Enable all ports in QSGMII Thread-Topic: [PATCH] net: mscc: Enable all ports in QSGMII Thread-Index: AQHUzze+V7C8AAaQGkOW/YiW+TjjEw== Date: Thu, 28 Feb 2019 07:32:22 +0000 Message-ID: <1551339098-15939-1-git-send-email-kavyasree.kotagiri@microchip.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MA1PR01CA0126.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:35::20) To BN6PR11MB4113.namprd11.prod.outlook.com (2603:10b6:405:80::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Kavyasree.Kotagiri@microchip.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 1.9.1 x-originating-ip: [182.72.246.220] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5599933d-1711-47c0-aa9b-08d69d4ee05b x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:BN6PR11MB0033; x-ms-traffictypediagnostic: BN6PR11MB0033: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BBN6PR11MB0033=3B23?= =?iso-8859-1?q?=3A1uqxhXqX5VKBPmiMoauCmbVzN1uoICMb68Ro+pEJZHIDM7l9?= =?iso-8859-1?q?xgmPOz3cvpRDKex57blSeBRdNivjPPJH7rsqHOcicuhbyaG2mOs?= =?iso-8859-1?q?FneJ5mR49NpETQzvtnLz5mK0QUu2qdp0XP6qGlIfqNqM0eqcY1f?= =?iso-8859-1?q?3j9+IkLrIgQlB6G66EKCtCbu5uoA/yjc+QfaIGGn16AHv+AbnfB?= =?iso-8859-1?q?PyTYFqczgaqkjS+Rau/qd4h4Y8gT2+n5xF5NUKYRhpPT0utslbE?= =?iso-8859-1?q?TrTygyYurVFyi5sflZh90GBlTmcPwnhYa2+bDGmoyURXMTogICp?= =?iso-8859-1?q?SDw5t+iXZZOJ3HWlUn0D3dIG4wlOY7ZKnwFhBuOJn+pEZQ1Tun+?= =?iso-8859-1?q?+KI3DLos4mfC+GnfyDibIVtCQZDNlKyzO9CeOzEiutGe9vYHDJU?= =?iso-8859-1?q?NzGXQ3cFMZmzhwE3g5S2PGRh52TAKpVHHCg0RDrZa7mMU9is9Sn?= =?iso-8859-1?q?yO0Efl6S6NXd3NRVOyf78/jXG8KPyBGo3EiD6T7xPvk6rbBNbi2?= =?iso-8859-1?q?ta5JUxKuTnO9Enxz4bkIcfxOe2I2ks+xE0IciYPrtPk7GSeZKMq?= =?iso-8859-1?q?tMLXGQdeuh4/SgID6TMtBWiWqTuMBEdYp3gbO95DzXyVl8ctETb?= =?iso-8859-1?q?//0whI+hIYZPZoASUnFZsOuDnBJiBe3DnFd8xkcuLsJuA0gbEID?= =?iso-8859-1?q?Vj8cBLf0R3xD1WYtnz5aQcWqb95CG9A7GEXczJcQlH0baV4Cow1?= =?iso-8859-1?q?I43MUu6RWajJXJbBQiC4Cz7Mxz/hA9xQryChY+4lFvBYz3yypZx?= =?iso-8859-1?q?j36nnDsQJ+r+4irpOwrCdJqFhGcV54iYD73Jpg76zIOebAZ8omP?= =?iso-8859-1?q?F7WNWy70KWeLinhZNIvnvEpxlWw4fLiIs42TOjwkIBsxcz6IBd6?= =?iso-8859-1?q?BoHQQ8btcDjxe0mMXY6OZK2LW86f5zWCEuuXBBWB7nxa5uK2u/8?= =?iso-8859-1?q?XCuu5pwb6IPWXdY1h2vw9YPfVOeDr5gyg0if0brUQ75ccqNMLMk?= =?iso-8859-1?q?96l9xg2dpU0ZyCQsO8+RRSSunziuotSjDNUs9evm7kQDeATphgk?= =?iso-8859-1?q?SfsVfVcNyDkj2t0RGwkH7lH7AyGHkGHW6Y378ZSf+4GlsmLnyjK?= =?iso-8859-1?q?UjXWlCDB3EfnPwUShsMG5oKST89YHNmRBQd0XgtpsGMgtiyoBHJ?= =?iso-8859-1?q?bnbugPL2aX4nOuye/vO6VPycCAydlEs9D+SL5sNLIsTA86bt5SQ?= =?iso-8859-1?q?hBrfZrdPLL/GgW7qzQAL1cEO2Cctd7Dt7XawdRDvW54yf7rMFo0?= =?iso-8859-1?q?HnEtXcFyYgd7K5IYQ=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0962D394D2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39860400002)(136003)(376002)(346002)(199004)(189003)(25786009)(97736004)(36756003)(14454004)(316002)(5660300002)(4326008)(54906003)(105586002)(110136005)(50226002)(2906002)(107886003)(256004)(3846002)(6116002)(478600001)(72206003)(71200400001)(2616005)(476003)(71190400001)(8676002)(52116002)(53936002)(486006)(78486014)(66066001)(81166006)(81156014)(86362001)(8936002)(55236004)(26005)(2501003)(6506007)(386003)(6512007)(102836004)(106356001)(7736002)(186003)(305945005)(68736007)(99286004)(6486002)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR11MB0033; H:BN6PR11MB4113.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: KlIHCOBlmSfQ7Rzinx5c7sGMJvSKKBv7i9zAgzyKoRavMRbXGJbCRVIgmTLTWO9GXIwPLNa3h8xmQDosJCNbBcSViUm5rTYfYo6mFlZtZDlrPv+fdNXoBtIk/JQqYQ0WfU2QbHkN9/3h18mCwXVvFqAhir2HumyZVmAOJtUe44O+gFXJkTCC3Crxeu9rDoWU5HYreHWSfKss/t9XMpSXHffKWPyMCYydFHj+dhzFNPiRrr0c26DvFvhcIFpyYK9bYNAgSgAA9xRMdRNIBETQ76cpTEVw6hhS3J7SIVu7AHhhcSMriSC4kRC6wcec55nnjro5J8xbXsleRuTmK3MlK7F7oxU+q7GfNK3tCt59UmAn4LkFpHZR6UXfM8nwsvS/4MnQjsPtq/q66iz5Q/wUtAtDucg/0LYtJu9sLh05rWY= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5599933d-1711-47c0-aa9b-08d69d4ee05b X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2019 07:32:19.1639 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB0033 X-OriginatorOrg: microchip.com Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Kavya Sree Kotagiri When Ocelot phy-mode is QSGMII, all 4 ports involved in QSGMII shall be kept out of reset and Tx lanes shall be enabled to pass the data. Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") Signed-off-by: Kavya Sree Kotagiri Signed-off-by: Steen Hegelund Co-developed-by: Steen Hegelund --- drivers/net/ethernet/mscc/ocelot_board.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mscc/ocelot_board.c b/drivers/net/ethernet/mscc/ocelot_board.c index ca3ea2f..80d8779 100644 --- a/drivers/net/ethernet/mscc/ocelot_board.c +++ b/drivers/net/ethernet/mscc/ocelot_board.c @@ -267,6 +267,7 @@ static int mscc_ocelot_probe(struct platform_device *pdev) struct phy *serdes; void __iomem *regs; char res_name[8]; + int phy_mode; u32 port; if (of_property_read_u32(portnp, "reg", &port)) @@ -292,11 +293,11 @@ static int mscc_ocelot_probe(struct platform_device *pdev) if (err) return err; - err = of_get_phy_mode(portnp); - if (err < 0) + phy_mode = of_get_phy_mode(portnp); + if (phy_mode < 0) ocelot->ports[port]->phy_mode = PHY_INTERFACE_MODE_NA; else - ocelot->ports[port]->phy_mode = err; + ocelot->ports[port]->phy_mode = phy_mode; switch (ocelot->ports[port]->phy_mode) { case PHY_INTERFACE_MODE_NA: @@ -304,6 +305,13 @@ static int mscc_ocelot_probe(struct platform_device *pdev) case PHY_INTERFACE_MODE_SGMII: break; case PHY_INTERFACE_MODE_QSGMII: + /* Ensure clock signals and speed is set on all + * QSGMII links + */ + ocelot_port_writel(ocelot->ports[port], + DEV_CLOCK_CFG_LINK_SPEED + (OCELOT_SPEED_1000), + DEV_CLOCK_CFG); break; default: dev_err(ocelot->dev,