Patchwork Prevent warning during PMP error recovery

login
register
mail settings
Submitter Gwendal Grignou
Date July 16, 2011, 12:32 a.m.
Message ID <1310776322-12911-1-git-send-email-gwendal@google.com>
Download mbox | patch
Permalink /patch/104925/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Gwendal Grignou - July 16, 2011, 12:32 a.m.
Cleanup sff_pio_task_link when a command is cancel while the
pio_task thread has been scheduled.

Change-Id: I4397bed3ee0878d92933d4897eed025ffaf3a9bd

Signed-off-by: Gwendal Grignou <gwendal@google.com>
---
 drivers/ata/libata-sff.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Tejun Heo - July 21, 2011, 7:24 a.m.
On Fri, Jul 15, 2011 at 05:32:02PM -0700, Gwendal Grignou wrote:
> Cleanup sff_pio_task_link when a command is cancel while the
> pio_task thread has been scheduled.
> 
> Change-Id: I4397bed3ee0878d92933d4897eed025ffaf3a9bd
> 
> Signed-off-by: Gwendal Grignou <gwendal@google.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thank you.
Tejun Heo - July 21, 2011, 7:25 a.m.
On Thu, Jul 21, 2011 at 09:24:20AM +0200, Tejun Heo wrote:
> On Fri, Jul 15, 2011 at 05:32:02PM -0700, Gwendal Grignou wrote:
> > Cleanup sff_pio_task_link when a command is cancel while the
> > pio_task thread has been scheduled.
> > 
> > Change-Id: I4397bed3ee0878d92933d4897eed025ffaf3a9bd
> > 
> > Signed-off-by: Gwendal Grignou <gwendal@google.com>
> 
> Acked-by: Tejun Heo <tj@kernel.org>

Oooh, Jeff isn't cc'd.  Please re-send to jgarzik with Acked-by added.

Thank you.

Patch

diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 996a7a5..c24127d 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -1333,6 +1333,7 @@  void ata_sff_flush_pio_task(struct ata_port *ap)
 
 	cancel_delayed_work_sync(&ap->sff_pio_task);
 	ap->hsm_task_state = HSM_ST_IDLE;
+	ap->sff_pio_task_link = NULL;
 
 	if (ata_msg_ctl(ap))
 		ata_port_dbg(ap, "%s: EXIT\n", __func__);