[pph] Expect checksums for tests marked with pph asm xdiff (issue4744043)

Reviewed in person by Lawrence.

Shortened XFAIL message from previous patch.

Also, quick side note, in the first description of this patch I said I used "exec grep", I meant "exec diff".

Gab

2011-07-15  Gabriel Charette  <gchare@google.com>

	* g++.dg/pph/c1builtin-integral.cc: Add expected diff checksum.
	* g++.dg/pph/c1eabi1.cc: Add expected diff checksum.
	* g++.dg/pph/p4eabi1.cc: Add expected diff checksum.
	* lib/dg-pph.exp (dg-pph-pos): Expect checksums for pph asm xdiff.


--
This patch is available for review at http://codereview.appspot.com/4744043

gchare@google.com (Gabriel Charette) writes:

> +	    set expectedSum [exec tr -d \} << [exec cut -f 4 -d\  << $xdiff_entry]]
> +	    set actualSum [exec cut -f 1 -d\  << [exec sum << $diff_result]]

You don't need cut and tr if you have tcl.

Andreas.

On Sat, Jul 16, 2011 at 12:59 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> gchare@google.com (Gabriel Charette) writes:
>
> > +         set expectedSum [exec tr -d \} << [exec cut -f 4 -d\  << $xdiff_entry]]

$xdiffentry is set to something like {{pph asm diff 123456}}, so i
need tr and cut to extract 123456

(i tried removing the tr and i get "123456}")

>
> > +         set actualSum [exec cut -f 1 -d\  << [exec sum << $diff_result]]

and the sum of $diff_result is something like "123456     12", i'm
ignoring the second number for simplicity; hence why i'm using cut
here.

If there are ways to do this directly in TCL, without using exec
calls, I'd be glad to know.

Gabriel

Gabriel Charette <gchare@google.com> writes:

> On Sat, Jul 16, 2011 at 12:59 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>
>> gchare@google.com (Gabriel Charette) writes:
>>
>> > +         set expectedSum [exec tr -d \} << [exec cut -f 4 -d\  << $xdiff_entry]]
>
> $xdiffentry is set to something like {{pph asm diff 123456}}, so i
> need tr and cut to extract 123456

tcl can everything tr and cut can do (with the above options anyway).

> If there are ways to do this directly in TCL, without using exec
> calls, I'd be glad to know.

Read split(n) and string(n).

Andreas.

On Mon, Jul 18, 2011 at 3:05 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Gabriel Charette <gchare@google.com> writes:
>
>> On Sat, Jul 16, 2011 at 12:59 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>>
>>> gchare@google.com (Gabriel Charette) writes:
>>>
>>> > +         set expectedSum [exec tr -d \} << [exec cut -f 4 -d\  << $xdiff_entry]]
>>
>> $xdiffentry is set to something like {{pph asm diff 123456}}, so i
>> need tr and cut to extract 123456
>
> tcl can everything tr and cut can do (with the above options anyway).
>
>> If there are ways to do this directly in TCL, without using exec
>> calls, I'd be glad to know.
>
> Read split(n) and string(n).
>

Thanks for the suggestion,
suggested changes made as part of issue 4768041.

Gabriel