From patchwork Wed Feb 27 22:18:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Schmutzler X-Patchwork-Id: 1049163 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=adrianschmutzler.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hK3GmfD3"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 448qp92Z31z9sBF for ; Thu, 28 Feb 2019 09:18:41 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=TmqgeiFcAOE9i8MxbnoX1dP+UA+mWmycV9ucyjTwyrc=; b=hK3GmfD3d1rGW2iIcYAsMki/up NjPqWelxu/9wNXZMwnnPbOkdoUz9h69NC+hobl6jzVO02lO3Sn/mGg6Q8wlLaUvTH9bLDeOtUm/F6 +m4z/CFInImSd+vjkBUU/oH7xRz99Ojmg0690ivNtarrH1oiXjau7rcrxg3ywOUqk/u5o38yTMDv/ IV77hxlrvfgoiIFEl5c9bG2kZz07vDHRS3db+kjByp591nNNLWVVybu8LSttCfUUfv9PCosNY9o0D jasYf6wkzDetpna27PZf5LFq38hEXtJjqypz7JJ4III9BxuFP0Ya4u8QSE5NsxJGGDJf6sTa6xua1 BfQ7P4IQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gz7Wu-0003po-6G; Wed, 27 Feb 2019 22:18:20 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gz7Wr-0003o0-2G for openwrt-devel@lists.openwrt.org; Wed, 27 Feb 2019 22:18:18 +0000 Received: from localhost.localdomain ([188.194.105.77]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1M58OQ-1gy1451jxE-0019CS for ; Wed, 27 Feb 2019 23:18:13 +0100 From: Adrian Schmutzler To: openwrt-devel@lists.openwrt.org Date: Wed, 27 Feb 2019 23:18:06 +0100 Message-Id: <20190227221809.1697-4-freifunk@adrianschmutzler.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190227221809.1697-1-freifunk@adrianschmutzler.de> References: <20190227221809.1697-1-freifunk@adrianschmutzler.de> X-Provags-ID: V03:K1:kb7KaA0RkV78Dusg6J7ku8qPHJdHlrMLEAb/ipwrRPSqrne5Y2n 3ZRHA5iDmiHuQAlvpPBQs0gBTaC0mcz+S5lQ3DJt7pv3ZLnUtIe5PQRU6oIBTJJZDwO9NvM Gnc5Go5t+B16UVSy6CtiUtk/nB7sGfB+PfD6V2dTHyU0J9QamuhDFgNcMvZu4Qw95MY+u+E Jf2KZc2AhCYbPsk+IvZXg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:j+eemV+D24g=:d7K2V8ZSp/YGJlZK4NVHXR K2lSbW+YU4ifMKxDlNl9D5q2n8v+CJtPJjEQEwX7aXXJcXtB/3PWnimEPMQdbt6Ticl/fB1kV zJvKlc4jV6RWpLgZPnLF80AcKNPk00rpkCkdTScoyE9yc0P+BLH9XAgDH+PFvOXs1m4JaXEfs GrPf3+SMfnF4Rm7ooatp3R1qe8dTPt73C2gadCVDje15fem0dAualhqNEv8ABvqO33PkepdeM 4hdu0os817xcCNaxyIELILHIz9LTmgGMtudRJa5XMosNwKCyHuOGdWer4ntiS2UyrxhMS6N/j 9CMt3SLIX4V+HFbZzRSs57Xj5FtWZHXRTdZ09F0rkw5vV0VcbHpMDHtnXYBnvM1b4sa4muvQV bF9GgzjQqSBTKj58mywks9XMcmTkGGr/o68AVfgYhlWuFpefgc3uFwKCMPFzXHrFht7VfPwkY SXSZxLf5SSrqb8dq6+RCnp5dNyKuS0nXtYeEyQs6iwlKaWgFQj40oMyd97AHzO/rCrY7kV50z PLnCXuynjwE2RSPhQ4hD4Pn6Z4/3CgDxKTAsTEbnAtarLizoI5dXyvO4559k+2ySN2CGsslXo ilCRHxKWu9Y/NNg0qCKWcq2yHEQsIOijL8l+HIPtyOAPoRAafTo5Pwu1YLs/S2I3V8lOErJ1K rq/zzVwJHsrWeMfNA5FBGpyy/tU1GZjMWZ5j7uaSOz95cXF3MpbO8UQSPstZQWuS+EQZdL+7b yW6giQDTIWzQl/Kvw0gmGwWmFsYvl7EPkF4hgZ7lY1WclJlIfQq2npIewHc= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190227_141817_407434_D07152AA X-CRM114-Status: GOOD ( 10.97 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.24 listed in list.dnswl.org] Subject: [OpenWrt-Devel] [PATCH v3 3/6] ar71xx: Speed up mtd extraction in ar71xx.sh X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Although the amount of data read here is smaller than for the caldata, there still might be some speed gain compared to reading bytewise. And there is no harm... Signed-off-by: Adrian Schmutzler --- Changed in v3: - Changed position of iflag to be consistent --- target/linux/ar71xx/base-files/lib/ar71xx.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/linux/ar71xx/base-files/lib/ar71xx.sh b/target/linux/ar71xx/base-files/lib/ar71xx.sh index 95fa247f4b..f0f6f0398b 100755 --- a/target/linux/ar71xx/base-files/lib/ar71xx.sh +++ b/target/linux/ar71xx/base-files/lib/ar71xx.sh @@ -16,7 +16,7 @@ ar71xx_get_mtd_offset_size_format() { dev=$(find_mtd_part $mtd) [ -z "$dev" ] && return - dd if=$dev bs=1 skip=$offset count=$size 2>/dev/null | hexdump -v -e "1/1 \"$format\"" + dd if=$dev iflag=skip_bytes bs=$size skip=$offset count=1 2>/dev/null | hexdump -v -e "1/1 \"$format\"" } ar71xx_get_mtd_part_magic() { @@ -390,7 +390,7 @@ tplink_pharos_v2_get_model_string() { part=$(find_mtd_part 'product-info') [ -z "$part" ] && return 1 - dd if=$part bs=1 skip=4360 count=64 2>/dev/null | tr -d '\r\0' | head -n 1 + dd if=$part iflag=skip_bytes bs=64 skip=4360 count=1 2>/dev/null | tr -d '\r\0' | head -n 1 } ar71xx_board_detect() {