| Message ID | 20190226022224.21171-1-andrew.donnellan@au1.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] config: Get rid of DEBUG_MALLOC | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | master/apply_patch Successfully applied |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes: > Since the initial release of skiboot, we've #defined DEBUG_MALLOC to 1. > > Also since the initial release of skiboot, DEBUG_MALLOC has been referenced > absolutely nowhere. > > Get rid of it. > > Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > --- > doc/overview.rst | 3 +-- > include/config.h | 3 --- > 2 files changed, 1 insertion(+), 5 deletions(-) Well, this (and the other) patch get rid of solidly dead #defines. Series merged to master as of 647dc4aff7b6a9cbfe2338ae354246650e476bf1.
diff --git a/doc/overview.rst b/doc/overview.rst index 2d09e05801de..63667013e447 100644 --- a/doc/overview.rst +++ b/doc/overview.rst @@ -136,8 +136,7 @@ In the source file include/mem-map.h we include a memory map. This is manually generated, not automatically generated. We use CCAN for a bunch of helper code, turning on things like DEBUG_LOCKS -and DEBUG_MALLOC as these are not a performance issue for us, and we like -to be careful. +as these are not a performance issue for us, and we like to be careful. In include/config.h there are defines for turning on extra tracing. OPAL is what we name the interface from skiboot to OS (Linux). diff --git a/include/config.h b/include/config.h index 6b36590c39f0..e34feae9f011 100644 --- a/include/config.h +++ b/include/config.h @@ -42,9 +42,6 @@ /* Enable lock dependency checker */ #define DEADLOCK_CHECKER 1 -/* Enable malloc debugging */ -#define DEBUG_MALLOC 1 - /* Enable OPAL entry point tracing */ //#define OPAL_TRACE_ENTRY 1
Since the initial release of skiboot, we've #defined DEBUG_MALLOC to 1. Also since the initial release of skiboot, DEBUG_MALLOC has been referenced absolutely nowhere. Get rid of it. Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> --- doc/overview.rst | 3 +-- include/config.h | 3 --- 2 files changed, 1 insertion(+), 5 deletions(-)