Patchwork [U-Boot,v2] Let source cross-reference targets follow symbolic links

login
register
mail settings
Submitter Horst Kronstorfer
Date July 15, 2011, 9:24 a.m.
Message ID <1310721846-7216-1-git-send-email-hkronsto@frequentis.com>
Download mbox | patch
Permalink /patch/104783/
State Superseded
Headers show

Comments

Horst Kronstorfer - July 15, 2011, 9:24 a.m.
From: Horst Kronstorfer <hkronsto@frequentis.com>

Without telling 'find' to follow symbolic links, files under include/asm
and arch/$(ARCH)/include/asm/arch are not added to the indexing file list.

Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>

Changes for v2:
    - Apply this change to all source cross-reference targets
---
 Makefile |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
Detlev Zundel - July 15, 2011, 3:19 p.m.
Hi Horst,

> From: Horst Kronstorfer <hkronsto@frequentis.com>
>
> Without telling 'find' to follow symbolic links, files under include/asm
> and arch/$(ARCH)/include/asm/arch are not added to the indexing file list.
>
> Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
>
> Changes for v2:
>     - Apply this change to all source cross-reference targets

This needs to go below the '---' as it is not part of the git commit
message.

> ---
>  Makefile |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index e56fa02..e86a81a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -471,15 +471,17 @@ TAG_SUBDIRS = $(SUBDIRS)
>  TAG_SUBDIRS += $(dir $(__LIBS))
>  TAG_SUBDIRS += include
>  
> +FIND := find -L

I really dislike this approach.  I would never expect a variable $(FIND)
to already include options.  So if you want to go that way then also
introduce FINDFLAGS.

Thanks
  Detlev

Patch

diff --git a/Makefile b/Makefile
index e56fa02..e86a81a 100644
--- a/Makefile
+++ b/Makefile
@@ -471,15 +471,17 @@  TAG_SUBDIRS = $(SUBDIRS)
 TAG_SUBDIRS += $(dir $(__LIBS))
 TAG_SUBDIRS += include
 
+FIND := find -L
+
 tags ctags:
-		ctags -w -o $(obj)ctags `find $(TAG_SUBDIRS) \
+		ctags -w -o $(obj)ctags `$(FIND) $(TAG_SUBDIRS) \
 						-name '*.[chS]' -print`
 
 etags:
-		etags -a -o $(obj)etags `find $(TAG_SUBDIRS) \
+		etags -a -o $(obj)etags `$(FIND) $(TAG_SUBDIRS) \
 						-name '*.[chS]' -print`
 cscope:
-		find $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files
+		$(FIND) $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files
 		cscope -b -q -k
 
 SYSTEM_MAP = \