| Message ID | 20190225090056.19055-2-himadri18.07@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] arch: powerpc/kexec: Add missing of_node-put() in default_machine_kexec_prepare() | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/build-ppc64le | fail | build failed! |
| snowpatch_ozlabs/build-ppc64be | fail | build failed! |
| snowpatch_ozlabs/build-ppc64e | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-pmac32 | warning | build succeeded but added 17 new sparse warning(s) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
On 02/25/2019 01:00 AM, Himadri Pandya wrote: > Decrement the reference count on device_node "np" while breaking out of > the loop. Issue identified by Coccinelle. > > Signed-off-by: Himadri Pandya <himadri18.07@gmail.com> > --- > Changes in V2: > - Change subject line > --- > arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c > index 8112b39879d6..3ee1404ceef4 100644 > --- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c > +++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c > @@ -220,6 +220,7 @@ void hlwd_pic_probe(void) > irq_set_chained_handler(cascade_virq, > hlwd_pic_irq_cascade); > hlwd_irq_host = host; > + of_node_put(np); > break; > } > } > @@ -237,4 +238,3 @@ void hlwd_quiesce(void) > > __hlwd_quiesce(io_base); > } > - > This line removal at the end of the patch is likely accidental, but really should not be here. Otherwise, Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c index 8112b39879d6..3ee1404ceef4 100644 --- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c +++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c @@ -220,6 +220,7 @@ void hlwd_pic_probe(void) irq_set_chained_handler(cascade_virq, hlwd_pic_irq_cascade); hlwd_irq_host = host; + of_node_put(np); break; } } @@ -237,4 +238,3 @@ void hlwd_quiesce(void) __hlwd_quiesce(io_base); } -
Decrement the reference count on device_node "np" while breaking out of the loop. Issue identified by Coccinelle. Signed-off-by: Himadri Pandya <himadri18.07@gmail.com> --- Changes in V2: - Change subject line --- arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)