Patchwork [1/1] XFS TESTS: Correct extent flag parsing for punch hole tests

login
register
mail settings
Submitter Allison Henderson
Date July 15, 2011, 3:52 a.m.
Message ID <1310701933-18988-1-git-send-email-achender@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/104752/
State Not Applicable
Headers show

Comments

Allison Henderson - July 15, 2011, 3:52 a.m.
The fiemap filters used in the punch hole tests parse the
extent flags in the fiemap to determine the extent type.
They are currently parsing them as decimal values, but
they should be parsing hex values.

Signed-off-by: Allison Henderson <achender@linux.vnet.ibm.com>
---
:100644 100755 0083963... 0083963... M	255
:100644 100644 a48b7ae... 7337298... M	common.punch
 common.punch |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Alex Elder - July 15, 2011, 1:46 p.m.
On Thu, 2011-07-14 at 20:52 -0700, Allison Henderson wrote:
> The fiemap filters used in the punch hole tests parse the
> extent flags in the fiemap to determine the extent type.
> They are currently parsing them as decimal values, but
> they should be parsing hex values.
> 
> Signed-off-by: Allison Henderson <achender@linux.vnet.ibm.com>

Looks good to me.  This may not have a practical
effect but it looks correct now.

I will commit this for you.  Thanks for fixing it.

Reviewed-by: Alex Elder <aelder@sgi.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/255 b/255
old mode 100644
new mode 100755
diff --git a/common.punch b/common.punch
index a48b7ae..7337298 100644
--- a/common.punch
+++ b/common.punch
@@ -208,11 +208,11 @@  _filter_fiemap()
 			print $1, $2, $3;
 			next;
 		}
-		$5 ~ /0x[[:digit:]]*8[[:digit:]]{2}/ {
+		$5 ~ /0x[[:xdigit:]]*8[[:xdigit:]]{2}/ {
 			print $1, $2, "unwritten";
 			next;
 		}
-		$5 ~ /0x[[:digit:]]+/ {
+		$5 ~ /0x[[:xdigit:]]+/ {
 			print $1, $2, "data";
 		}' |
 	_coalesce_extents
@@ -228,7 +228,7 @@  _filter_hole_fiemap()
 			print $1, $2, $3; 
 			next;
 		}   
-		$5 ~ /0x[[:digit:]]+/ {
+		$5 ~ /0x[[:xdigit:]]+/ {
 			print $1, $2, "extent";
 		}' |
 	_coalesce_extents