diff mbox series

net: dsa: Remove documentation for port_fdb_prepare

Message ID 20190222190745.28020-1-hauke@hauke-m.de
State Accepted
Delegated to: David Miller
Headers show
Series net: dsa: Remove documentation for port_fdb_prepare | expand

Commit Message

Hauke Mehrtens Feb. 22, 2019, 7:07 p.m. UTC 
This callback was removed some time ago, also remove the documentation.

Fixes: 1b6dd556c304 ("net: dsa: Remove prepare phase for FDB")
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 Documentation/networking/dsa/dsa.txt | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

Comments

Florian Fainelli Feb. 22, 2019, 7:28 p.m. UTC | #1 
On 2/22/19 11:07 AM, Hauke Mehrtens wrote:
> This callback was removed some time ago, also remove the documentation.
> 
> Fixes: 1b6dd556c304 ("net: dsa: Remove prepare phase for FDB")
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

Not sure if this is worth a Fixes: tag since this is not quite a
functional change, but other than:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
David Miller Feb. 24, 2019, 2:38 a.m. UTC | #2 
From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Fri, 22 Feb 2019 20:07:45 +0100

> This callback was removed some time ago, also remove the documentation.
> 
> Fixes: 1b6dd556c304 ("net: dsa: Remove prepare phase for FDB")
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>

Applied.
diff mbox series

Patch

diff --git a/Documentation/networking/dsa/dsa.txt b/Documentation/networking/dsa/dsa.txt
index 25170ad7d25b..101f2b2c69ad 100644
--- a/Documentation/networking/dsa/dsa.txt
+++ b/Documentation/networking/dsa/dsa.txt
@@ -533,16 +533,12 @@  Bridge VLAN filtering
   function that the driver has to call for each VLAN the given port is a member
   of. A switchdev object is used to carry the VID and bridge flags.
 
-- port_fdb_prepare: bridge layer function invoked when the bridge prepares the
-  installation of a Forwarding Database entry. If the operation is not
-  supported, this function should return -EOPNOTSUPP to inform the bridge code
-  to fallback to a software implementation. No hardware setup must be done in
-  this function. See port_fdb_add for this and details.
-
 - port_fdb_add: bridge layer function invoked when the bridge wants to install a
   Forwarding Database entry, the switch hardware should be programmed with the
   specified address in the specified VLAN Id in the forwarding database
-  associated with this VLAN ID
+  associated with this VLAN ID. If the operation is not supported, this
+  function should return -EOPNOTSUPP to inform the bridge code to fallback to
+  a software implementation.
 
 Note: VLAN ID 0 corresponds to the port private database, which, in the context
 of DSA, would be the its port-based VLAN, used by the associated bridge device.