[B/C/D/Unstable] UBUNTU: d-i: add iscsi_ibft to scsi-modules
diff mbox series

Message ID 20190222134028.21002-1-mfo@canonical.com
State New
Headers show
Series
  • [B/C/D/Unstable] UBUNTU: d-i: add iscsi_ibft to scsi-modules
Related show

Commit Message

Mauricio Faria de Oliveira Feb. 22, 2019, 1:40 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1817321

Add iscsi_ibft to scsi-modules so that d-i can read
system iSCSI Boot Firmware Table (iBFT) information.

Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
---
 debian.master/d-i/modules/scsi-modules | 1 +
 1 file changed, 1 insertion(+)

Comments

Juerg Haefliger Feb. 25, 2019, 12:43 p.m. UTC | #1
On Fri, 22 Feb 2019 10:40:28 -0300
Mauricio Faria de Oliveira <mfo@canonical.com> wrote:

> BugLink: https://bugs.launchpad.net/bugs/1817321
> 
> Add iscsi_ibft to scsi-modules so that d-i can read
> system iSCSI Boot Firmware Table (iBFT) information.
> 
> Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>

Seems sensible.

Acked-by: Juerg Haefliger <juergh@canonical.com>

> ---
>  debian.master/d-i/modules/scsi-modules | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/d-i/modules/scsi-modules b/debian.master/d-i/modules/scsi-modules
> index 002e18b5b115..66923f331d8a 100644
> --- a/debian.master/d-i/modules/scsi-modules
> +++ b/debian.master/d-i/modules/scsi-modules
> @@ -126,6 +126,7 @@ zfcp ?
>  sd_mod ?
>  hisi_sas_v2_hw ?
>  hisi_sas_v3_hw ?
> +iscsi_ibft ?
>  
>  # device handlers
>  scsi_dh_alua ?
Kleber Souza Feb. 25, 2019, 2:30 p.m. UTC | #2
On 2/22/19 2:40 PM, Mauricio Faria de Oliveira wrote:
> BugLink: https://bugs.launchpad.net/bugs/1817321
>
> Add iscsi_ibft to scsi-modules so that d-i can read
> system iSCSI Boot Firmware Table (iBFT) information.
>
> Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
> ---
>  debian.master/d-i/modules/scsi-modules | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/debian.master/d-i/modules/scsi-modules b/debian.master/d-i/modules/scsi-modules
> index 002e18b5b115..66923f331d8a 100644
> --- a/debian.master/d-i/modules/scsi-modules
> +++ b/debian.master/d-i/modules/scsi-modules
> @@ -126,6 +126,7 @@ zfcp ?
>  sd_mod ?
>  hisi_sas_v2_hw ?
>  hisi_sas_v3_hw ?
> +iscsi_ibft ?
>  
>  # device handlers
>  scsi_dh_alua ?

Looks good to me.

Note that I have fixed the nominations on the bug report.

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>


Thanks,
Kleber
Mauricio Faria de Oliveira Feb. 25, 2019, 2:49 p.m. UTC | #3
On Mon, Feb 25, 2019 at 11:31 AM Kleber Souza
<kleber.souza@canonical.com> wrote:
[snip]
> Note that I have fixed the nominations on the bug report.
>
> Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks, Kleber.

For my education, should nominations always be done by the kernel
team, or we're welcome to do them if we can?

cheers,
Kleber Souza Feb. 25, 2019, 3:13 p.m. UTC | #4
On 2/25/19 3:49 PM, Mauricio Faria de Oliveira wrote:
> On Mon, Feb 25, 2019 at 11:31 AM Kleber Souza
> <kleber.souza@canonical.com> wrote:
> [snip]
>> Note that I have fixed the nominations on the bug report.
>>
>> Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
> Thanks, Kleber.
>
> For my education, should nominations always be done by the kernel
> team, or we're welcome to do them if we can?
>
> cheers,
>
Hi Mauricio,

You are more than welcome to add the nominations before sending the SRU
request to the mailing-list. That way it helps us to identify which
series are affected by the patch. The nominations can be added by anyone
but it can be approved only by someone with the required rights. So even
if the nominations need to be approved by someone from our team, it
already helps to have them added.


Thanks!
Kleber
Seth Forshee Feb. 25, 2019, 3:22 p.m. UTC | #5
On Fri, Feb 22, 2019 at 10:40:28AM -0300, Mauricio Faria de Oliveira wrote:
> BugLink: https://bugs.launchpad.net/bugs/1817321
> 
> Add iscsi_ibft to scsi-modules so that d-i can read
> system iSCSI Boot Firmware Table (iBFT) information.
> 
> Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>

Applied to disco and unstable, thanks!
Mauricio Faria de Oliveira Feb. 25, 2019, 3:25 p.m. UTC | #6
On Mon, Feb 25, 2019 at 12:13 PM Kleber Souza
<kleber.souza@canonical.com> wrote:
>
> On 2/25/19 3:49 PM, Mauricio Faria de Oliveira wrote:
> > On Mon, Feb 25, 2019 at 11:31 AM Kleber Souza
> > <kleber.souza@canonical.com> wrote:
> > [snip]
> >> Note that I have fixed the nominations on the bug report.
> >>
> >> Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
> > Thanks, Kleber.
> >
> > For my education, should nominations always be done by the kernel
> > team, or we're welcome to do them if we can?
> >
> > cheers,
> >
> Hi Mauricio,
>
> You are more than welcome to add the nominations before sending the SRU
> request to the mailing-list. That way it helps us to identify which
> series are affected by the patch. The nominations can be added by anyone
> but it can be approved only by someone with the required rights. So even
> if the nominations need to be approved by someone from our team, it
> already helps to have them added.
>

Cool, thanks for explaining it. I'll do that in the future.

>
> Thanks!
> Kleber
>
>
Khaled Elmously March 1, 2019, 1:16 a.m. UTC | #7
On 2019-02-22 10:40:28 , Mauricio Faria de Oliveira wrote:
> BugLink: https://bugs.launchpad.net/bugs/1817321
> 
> Add iscsi_ibft to scsi-modules so that d-i can read
> system iSCSI Boot Firmware Table (iBFT) information.
> 
> Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
> ---
>  debian.master/d-i/modules/scsi-modules | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/d-i/modules/scsi-modules b/debian.master/d-i/modules/scsi-modules
> index 002e18b5b115..66923f331d8a 100644
> --- a/debian.master/d-i/modules/scsi-modules
> +++ b/debian.master/d-i/modules/scsi-modules
> @@ -126,6 +126,7 @@ zfcp ?
>  sd_mod ?
>  hisi_sas_v2_hw ?
>  hisi_sas_v3_hw ?
> +iscsi_ibft ?
>  
>  # device handlers
>  scsi_dh_alua ?
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Patch
diff mbox series

diff --git a/debian.master/d-i/modules/scsi-modules b/debian.master/d-i/modules/scsi-modules
index 002e18b5b115..66923f331d8a 100644
--- a/debian.master/d-i/modules/scsi-modules
+++ b/debian.master/d-i/modules/scsi-modules
@@ -126,6 +126,7 @@  zfcp ?
 sd_mod ?
 hisi_sas_v2_hw ?
 hisi_sas_v3_hw ?
+iscsi_ibft ?
 
 # device handlers
 scsi_dh_alua ?