Patchwork [U-Boot] Let target 'cscope' follow symbolic links

login
register
mail settings
Submitter Horst Kronstorfer
Date July 14, 2011, 11:56 a.m.
Message ID <1310644606-2813-1-git-send-email-hkronsto@frequentis.com>
Download mbox | patch
Permalink /patch/104669/
State Changes Requested
Headers show

Comments

Horst Kronstorfer - July 14, 2011, 11:56 a.m.
Without telling 'find' to follow symbolic links, files under include/asm
and arch/$(ARCH)/include/asm/arch are not added to the cscope file list.

Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Detlev Zundel - July 15, 2011, 7:33 a.m.
Hi Horst,

> Without telling 'find' to follow symbolic links, files under include/asm
> and arch/$(ARCH)/include/asm/arch are not added to the cscope file list.

While your point seems valid, I see three occurrences of such a find
pattern and you fix only one.  May I ask you to fix all of them so users
of tags and etags are not left behind?

Thanks!
  Detlev
KRONSTORFER Horst - July 15, 2011, 8:11 a.m.
> -----Original Message-----
> From: Detlev Zundel [mailto:dzu@denx.de]
> Sent: Freitag, 15. Juli 2011 09:34
> To: KRONSTORFER Horst
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH] Let target 'cscope' follow symbolic links
> 
> Hi Horst,
> 
>> Without telling 'find' to follow symbolic links, files under include/asm
>> and arch/$(ARCH)/include/asm/arch are not added to the cscope file list.
> 
> While your point seems valid, I see three occurrences of such a find
> pattern and you fix only one.  May I ask you to fix all of them so
> users of tags and etags are not left behind?

you're right ... will do!

br
-h

> Thanks!
>   Detlev
> 
> --
> A zen-buddhist walked into a pizza shop and
> said, "Make me one with everything."
> --
> DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu@denx.de

Patch

diff --git a/Makefile b/Makefile
index e56fa02..deff642 100644
--- a/Makefile
+++ b/Makefile
@@ -479,7 +479,7 @@  etags:
 		etags -a -o $(obj)etags `find $(TAG_SUBDIRS) \
 						-name '*.[chS]' -print`
 cscope:
-		find $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files
+		find -L $(TAG_SUBDIRS) -name '*.[chS]' -print > cscope.files
 		cscope -b -q -k
 
 SYSTEM_MAP = \