Patchwork [U-Boot] integratorap: remove hardcoded 32MB memory cmdline

login
register
mail settings
Submitter Linus Walleij
Date July 14, 2011, 10:28 a.m.
Message ID <1310639329-9677-1-git-send-email-linus.walleij@linaro.org>
Download mbox | patch
Permalink /patch/104661/
State Accepted
Commit bc87d7641948ba49e1b9a4a3ce2cb2f922b77599
Headers show

Comments

Linus Walleij - July 14, 2011, 10:28 a.m.
The default configuration for the Integrator AP forces memory to be
32 MB on the command line to the kernel, while we have perfect
information and detection of the actual memory size in the ATAGs.
Delete the confusion.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 include/configs/integratorap.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Wolfgang Denk - July 14, 2011, 11:44 a.m.
Dear Linus Walleij,

In message <1310639329-9677-1-git-send-email-linus.walleij@linaro.org> you wrote:
> The default configuration for the Integrator AP forces memory to be
> 32 MB on the command line to the kernel, while we have perfect
> information and detection of the actual memory size in the ATAGs.
> Delete the confusion.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  include/configs/integratorap.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/integratorap.h b/include/configs/integratorap.h
> index d724c91..7b8aea6 100644
> --- a/include/configs/integratorap.h
> +++ b/include/configs/integratorap.h
> @@ -94,7 +94,7 @@
>  
>  
>  #define CONFIG_BOOTDELAY	2
> -#define CONFIG_BOOTARGS		"root=/dev/mtdblock0 mem=32M console=ttyAM0 console=tty"
> +#define CONFIG_BOOTARGS		"root=/dev/mtdblock0 console=ttyAM0 console=tty"
>  #define CONFIG_BOOTCOMMAND	""

Please make sure to Cc: the board maintainer!

Best regards,

Wolfgang Denk
Linus Walleij - July 14, 2011, 6:03 p.m.
On Thu, Jul 14, 2011 at 1:44 PM, Wolfgang Denk <wd@denx.de> wrote:

>> --- a/include/configs/integratorap.h
>> +++ b/include/configs/integratorap.h
>
> Please make sure to Cc: the board maintainer!

Aw yes, that's one thing. Peter, are you still looking after the Integrator
AP board support in U-boot?

I mailed with Philippe who said ARM dropped support for the Integrator
board, and given the state of the code in U-boot (doesn't compile,
doesn't work) I might be the only one actually looking after it in practice.

I'm happy to take over maintenance of it for a while atleast, if I have
yours and/or Philippe's ACK.

Thanks,
Linus Walleij
Linus Walleij - July 15, 2011, 10:33 a.m.
On Thu, Jul 14, 2011 at 8:03 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Jul 14, 2011 at 1:44 PM, Wolfgang Denk <wd@denx.de> wrote:
>
>>> --- a/include/configs/integratorap.h
>>> +++ b/include/configs/integratorap.h
>>
>> Please make sure to Cc: the board maintainer!
>
> Aw yes, that's one thing. Peter, are you still looking after the Integrator
> AP board support in U-boot?

I got this as autoreply from another conversation, so obviously Peter isn't
working with this anymore, actually if I recall correctly, he has retired from
ARM.

I will attempt to find his private email address but I will propose a
patch taking over as Integrator maintainer since I have the board and I
suspect noone else i likely to be working with it.

--------------------------------
From: StaffLeavers@arm.com
Sender: StaffLeavers@arm.com
Reply-To: StaffLeavers@arm.com
To: Linus Walleij <linus.walleij@linaro.org>
Subject: Re: Re: ARM DMA controllers
X-OriginalArrivalTime: 14 Jul 2011 20:25:56.0600 (UTC)
FILETIME=[3C7EAF80:01CC4264]


peter.pearse no longer works for ARM.

Your email will be forwarded to their line manager.


Please do not reply to this email.
If you need more information, please email real-postmaster@arm.com

Thank you.

-------------------------------

Thanks,
Linus Walleij
Philippe Robin - July 15, 2011, 11:49 a.m.
Hi Linus, Wolfgang,

On Fri, Jul 15, 2011 at 11:34 AM, Linus Walleij <linus.walleij@linaro.org>
wrote:
>> On Thu, Jul 14, 2011 at 8:03 PM, Linus Walleij <linus.walleij@linaro.org>
wrote:
>> > On Thu, Jul 14, 2011 at 1:44 PM, Wolfgang Denk <wd@denx.de> wrote:
>> >
>> >>> --- a/include/configs/integratorap.h
>> >>> +++ b/include/configs/integratorap.h
>> >>
>> >> Please make sure to Cc: the board maintainer!
>> >
>> > Aw yes, that's one thing. Peter, are you still looking after the
Integrator
>> > AP board support in U-boot?
>> 
>> I got this as autoreply from another conversation, so obviously Peter
isn't
>> working with this anymore, actually if I recall correctly, he has retired
from
>> ARM.

This is correct, Peter retired a couple of months ago.

>> I will attempt to find his private email address but I will propose a
>> patch taking over as Integrator maintainer since I have the board and I
>> suspect noone else i likely to be working with it.

This is probably best for this. Many thanks.

Regards,
Philippe

Patch

diff --git a/include/configs/integratorap.h b/include/configs/integratorap.h
index d724c91..7b8aea6 100644
--- a/include/configs/integratorap.h
+++ b/include/configs/integratorap.h
@@ -94,7 +94,7 @@ 
 
 
 #define CONFIG_BOOTDELAY	2
-#define CONFIG_BOOTARGS		"root=/dev/mtdblock0 mem=32M console=ttyAM0 console=tty"
+#define CONFIG_BOOTARGS		"root=/dev/mtdblock0 console=ttyAM0 console=tty"
 #define CONFIG_BOOTCOMMAND	""
 
 /*