bpfilter: re-add header search paths to tools include to fix build error
diff mbox series

Message ID 1550805799-24572-1-git-send-email-yamada.masahiro@socionext.com
State Accepted
Delegated to: David Miller
Headers show
Series
  • bpfilter: re-add header search paths to tools include to fix build error
Related show

Commit Message

Masahiro Yamada Feb. 22, 2019, 3:23 a.m. UTC
I thought header search paths to tools/include(/uapi) were unneeded,
but it looks like a build error occurs depending on the compiler.

Commit 303a339f30a9 ("bpfilter: remove extra header search paths for
bpfilter_umh") reintroduced the build error fixed by commit ae40832e53c3
("bpfilter: fix a build err").

Apology for the breakage, and thanks to Guenter for reporting this.

Fixes: 303a339f30a9 ("bpfilter: remove extra header search paths for bpfilter_umh")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

Guenter,

Sorry for bothering you, but
could you please test this with your compiler?

I am also using GCC 7.3, but my compiler cannot
reproduce the build error.


 net/bpfilter/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Guenter Roeck Feb. 22, 2019, 5:54 a.m. UTC | #1
On 2/21/19 7:23 PM, Masahiro Yamada wrote:
> I thought header search paths to tools/include(/uapi) were unneeded,
> but it looks like a build error occurs depending on the compiler.
> 
> Commit 303a339f30a9 ("bpfilter: remove extra header search paths for
> bpfilter_umh") reintroduced the build error fixed by commit ae40832e53c3
> ("bpfilter: fix a build err").
> 
> Apology for the breakage, and thanks to Guenter for reporting this.
> 
> Fixes: 303a339f30a9 ("bpfilter: remove extra header search paths for bpfilter_umh")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Tested-by: Guenter Roeck <linux@roeck-us.net>

> ---
> 
> Guenter,
> 
> Sorry for bothering you, but
> could you please test this with your compiler?
> 
> I am also using GCC 7.3, but my compiler cannot
> reproduce the build error.
> 
> 
>   net/bpfilter/Makefile | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/net/bpfilter/Makefile b/net/bpfilter/Makefile
> index 5d6c776..854395f 100644
> --- a/net/bpfilter/Makefile
> +++ b/net/bpfilter/Makefile
> @@ -5,6 +5,7 @@
>   
>   hostprogs-y := bpfilter_umh
>   bpfilter_umh-objs := main.o
> +KBUILD_HOSTCFLAGS += -Itools/include/ -Itools/include/uapi
>   HOSTCC := $(CC)
>   
>   ifeq ($(CONFIG_BPFILTER_UMH), y)
>
Masahiro Yamada Feb. 22, 2019, 8:23 a.m. UTC | #2
On Fri, Feb 22, 2019 at 2:55 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 2/21/19 7:23 PM, Masahiro Yamada wrote:
> > I thought header search paths to tools/include(/uapi) were unneeded,
> > but it looks like a build error occurs depending on the compiler.
> >
> > Commit 303a339f30a9 ("bpfilter: remove extra header search paths for
> > bpfilter_umh") reintroduced the build error fixed by commit ae40832e53c3
> > ("bpfilter: fix a build err").
> >
> > Apology for the breakage, and thanks to Guenter for reporting this.
> >
> > Fixes: 303a339f30a9 ("bpfilter: remove extra header search paths for bpfilter_umh")
> > Reported-by: Guenter Roeck <linux@roeck-us.net>
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Tested-by: Guenter Roeck <linux@roeck-us.net>


Thank you!
David Miller Feb. 23, 2019, 9:36 p.m. UTC | #3
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Fri, 22 Feb 2019 12:23:19 +0900

> I thought header search paths to tools/include(/uapi) were unneeded,
> but it looks like a build error occurs depending on the compiler.
> 
> Commit 303a339f30a9 ("bpfilter: remove extra header search paths for
> bpfilter_umh") reintroduced the build error fixed by commit ae40832e53c3
> ("bpfilter: fix a build err").
> 
> Apology for the breakage, and thanks to Guenter for reporting this.
> 
> Fixes: 303a339f30a9 ("bpfilter: remove extra header search paths for bpfilter_umh")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Applied to net-next.

Patch
diff mbox series

diff --git a/net/bpfilter/Makefile b/net/bpfilter/Makefile
index 5d6c776..854395f 100644
--- a/net/bpfilter/Makefile
+++ b/net/bpfilter/Makefile
@@ -5,6 +5,7 @@ 
 
 hostprogs-y := bpfilter_umh
 bpfilter_umh-objs := main.o
+KBUILD_HOSTCFLAGS += -Itools/include/ -Itools/include/uapi
 HOSTCC := $(CC)
 
 ifeq ($(CONFIG_BPFILTER_UMH), y)