From patchwork Thu Jul 14 07:19:16 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gwendal Grignou X-Patchwork-Id: 104634 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 79804B6F69 for ; Thu, 14 Jul 2011 17:19:24 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753711Ab1GNHTX (ORCPT ); Thu, 14 Jul 2011 03:19:23 -0400 Received: from smtp-out.google.com ([216.239.44.51]:53390 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753515Ab1GNHTW (ORCPT ); Thu, 14 Jul 2011 03:19:22 -0400 Received: from hpaq1.eem.corp.google.com (hpaq1.eem.corp.google.com [172.25.149.1]) by smtp-out.google.com with ESMTP id p6E7JIXH013527 for ; Thu, 14 Jul 2011 00:19:19 -0700 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1310627961; bh=fCcz3hpOomeZSSXERiOV7nLJkLM=; h=MIME-Version:In-Reply-To:References:Date:Message-ID:Subject:From: To:Cc:Content-Type; b=bMbcRBnSgEJoRyJIpTF9MHbkj7Xj+8skZ2L534I1SMfySQmzeEwSUo4cGxA+G/BVx J20lUXYFcPPPNd2i0P/BQ== DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=dkim-signature:mime-version:in-reply-to:references:date: message-id:subject:from:to:cc:content-type:x-system-of-record; b=ivb+BqgdJ/nxB4IUQqFVljD0kS0VpkFNKxMhLLjQVyik5rkY2x41fjwwPk90tUn84 aGaFdXg6jKpwegUYSplOA== Received: from ywa8 (ywa8.prod.google.com [10.192.1.8]) by hpaq1.eem.corp.google.com with ESMTP id p6E7IxL9031248 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 14 Jul 2011 00:19:17 -0700 Received: by ywa8 with SMTP id 8so2836410ywa.38 for ; Thu, 14 Jul 2011 00:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9i09BE7FKWWFilHbmk8TFEYMbK4xxrnzlFyy9bRlwrw=; b=kR2DVHvxMlFP1F3wMAs+Ng4l8KnquE60A4x2scd2IXewrIB2462YTWHaT/8cRuSeht FXumWUSsB0MNkbLQYuVw== MIME-Version: 1.0 Received: by 10.91.63.21 with SMTP id q21mr2062512agk.62.1310627957041; Thu, 14 Jul 2011 00:19:17 -0700 (PDT) Received: by 10.91.214.17 with HTTP; Thu, 14 Jul 2011 00:19:16 -0700 (PDT) In-Reply-To: <4E1E1F12.8040100@pobox.com> References: <20110626070820.GC24867@merlins.org> <20110626090309.GA12200@mtj.dyndns.org> <4E076E9E.9080400@pobox.com> <20110629034125.GC32153@merlins.org> <4E0AA1C1.6020406@pobox.com> <20110629050341.GB10580@merlins.org> <20110629150713.GG10580@merlins.org> <4E0B4CC7.5000601@pobox.com> <20110712142938.GB4347@mtj.dyndns.org> <4E1E1F12.8040100@pobox.com> Date: Thu, 14 Jul 2011 00:19:16 -0700 Message-ID: Subject: Re: sata_mv WARNING: at drivers/ata/libata-sff.c:1322 From: Gwendal Grignou To: Mark Lord Cc: Tejun Heo , Marc MERLIN , linux-ide@vger.kernel.org, Larry Li , hbailey@marvell.com X-System-Of-Record: true Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Mark, How PMP support with sata_mv broken for you? I am using marvell 7042 and sil3726 and it works fine, but I am still using 2.6.36. Tejun, Marc, I think what happen is if a command is canceled while waiting for sff_pio_task to fire up, the warning may happen. The following patch should fix it. Marc, can you reproduce the problem easily? Thanks, Gwendal. On Wed, Jul 13, 2011 at 3:41 PM, Mark Lord wrote: > On 11-07-13 04:54 PM, Gwendal Grignou wrote: >> I put the warning because a new pio task should not be queued while >> another one is pending. Therefore, either sff_pio_task_link is NULL >> [no task pending] or sff_pio_task_link is equal to the link of the >> task [assumed to be the task in progress]. >> I must have missed something and did not cleanup sff_pio_task_link >> properly in case of error... > .. > > I wonder if any of those changes are what broke PMP support? > I have a Marvell PMP here that used to work when I finished with sata_mv, > but no longer works with it now. > > ?? > -- > Mark Lord > Real-Time Remedies Inc. > mlord@pobox.com > --- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index 996a7a5..c24127d 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c @@ -1333,6 +1333,7 @@ void ata_sff_flush_pio_task(struct ata_port *ap) cancel_delayed_work_sync(&ap->sff_pio_task); ap->hsm_task_state = HSM_ST_IDLE; + ap->sff_pio_task_link = NULL; if (ata_msg_ctl(ap)) ata_port_dbg(ap, "%s: EXIT\n", __func__);