From patchwork Thu Feb 21 16:44:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seth Forshee X-Patchwork-Id: 1046278 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4450gc06Qrz9s8m; Fri, 22 Feb 2019 03:44:44 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1gwrSg-00042P-Gz; Thu, 21 Feb 2019 16:44:38 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1gwrSd-00040a-Ld for kernel-team@lists.ubuntu.com; Thu, 21 Feb 2019 16:44:35 +0000 Received: from mail-wr1-f70.google.com ([209.85.221.70]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1gwrSd-0007xw-B3 for kernel-team@lists.ubuntu.com; Thu, 21 Feb 2019 16:44:35 +0000 Received: by mail-wr1-f70.google.com with SMTP id j7so7725295wrs.20 for ; Thu, 21 Feb 2019 08:44:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RXMD0TzeIAjbTctU6vCI2Sze/VAWF2n6kp2TY8ieWtc=; b=tQVkQ457Bou6NVtMxHBp+lFukziSHQLq355gUGlLhWzReLDHw7SFpquYmIbl8uo8cp 1vqFoytLEJl5H5//Rk85JSgprChQXIwXvEcsxW/+4T0AhYbjDUq8cmMm1bT18vc117HH 7UvJocMuPzeY9DYaw8Gq1F/pYbAl4V37pg5IthSzdOvMHCnzIzyf9gksAoGmorina8LF k962PlAHDawM9r/rcnqvIlBbTWbzCW9bppds7WZQAlBX/L8EakibY558JVeplQSvllv8 +o+99puCw+CmdLNuoArL+lBCM4XIToiwx3nj8jmy+t33aD+04i+qCIyrN9uZkJ0fdw5B Mhiw== X-Gm-Message-State: AHQUAuYjgT19ta+OVbOuuEJVV8kUYVRI6DokOHJtP2PRfMsczoiH5Adz 0bv6hS9PU2LF/d/sIze8lGNz+AZwdqWDZ4e2OQJRhR5zJM1OAK5py/7+4/SMv+EckPNYhZ/xk7s p32jWV0khw6J3RZTMl8LZdMvs0mtZKzr4XueZUU+BDA== X-Received: by 2002:a5d:4585:: with SMTP id p5mr31657255wrq.178.1550767474653; Thu, 21 Feb 2019 08:44:34 -0800 (PST) X-Google-Smtp-Source: AHgI3Iau/tVSGjoydlM2qe8cwkHlOqRLAEkUuAhBXD1SQhf+OWZUXc0dcwNg8Ub0z3kYythKtvwfdg== X-Received: by 2002:a5d:4585:: with SMTP id p5mr31657228wrq.178.1550767474298; Thu, 21 Feb 2019 08:44:34 -0800 (PST) Received: from localhost ([194.204.107.10]) by smtp.gmail.com with ESMTPSA id j124sm10464351wmb.48.2019.02.21.08.44.33 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 08:44:33 -0800 (PST) From: Seth Forshee To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/2][SRU][C] ALSA: hda/realtek - Headset microphone support for System76 darp5 Date: Thu, 21 Feb 2019 17:44:25 +0100 Message-Id: <20190221164426.17652-4-seth.forshee@canonical.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190221164426.17652-1-seth.forshee@canonical.com> References: <20190221164426.17652-1-seth.forshee@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Jeremy Soller BugLink: https://bugs.launchpad.net/bugs/1815831 On the System76 Darter Pro (darp5), there is a headset microphone input attached to 0x1a that does not have a jack detect. In order to get it working, the pin configuration needs to be set correctly, and the ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is similar to the MIC_NO_PRESENCE fixups for some Dell laptops, except we have a separate microphone jack that is already configured correctly. Signed-off-by: Jeremy Soller Cc: Signed-off-by: Takashi Iwai (backported from commit 89e3a5682edaa4e5bb334719afb180256ac7bf78) [ saf: adjust context ] Signed-off-by: Seth Forshee --- sound/pci/hda/patch_realtek.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 4572b94d9d11..4f9c7bd4e5dc 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5541,6 +5541,7 @@ enum { ALC295_FIXUP_HP_X360, ALC221_FIXUP_HP_HEADSET_MIC, ALC285_FIXUP_LENOVO_HEADPHONE_NOISE, + ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE, }; static const struct hda_fixup alc269_fixups[] = { @@ -6435,6 +6436,15 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_THINKPAD_ACPI }, + [ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x1a, 0x01a1913c }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6605,6 +6615,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x144d, 0xc740, "Samsung Ativ book 8 (NP870Z5G)", ALC269_FIXUP_ATIV_BOOK_8), SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807", ALC283_FIXUP_HEADSET_MIC), SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC), + SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS), SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE), SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),