diff mbox series

[v2,39/52] test-ipmi-hiomap: Add ack-malformed tests

Message ID 20190221062851.21958-40-andrew@aj.id.au
State Accepted
Headers show
Series ipmi-hiomap: Tests and fixes for event handling | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success master/apply_patch Successfully applied
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master

Commit Message

Andrew Jeffery Feb. 21, 2019, 6:28 a.m. UTC 
Cc: stable
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
 libflash/test/test-ipmi-hiomap.c | 60 ++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)
diff mbox series

Patch

diff --git a/libflash/test/test-ipmi-hiomap.c b/libflash/test/test-ipmi-hiomap.c
index 8fbee1f27a49..05e3ecf3c29f 100644
--- a/libflash/test/test-ipmi-hiomap.c
+++ b/libflash/test/test-ipmi-hiomap.c
@@ -43,6 +43,7 @@  struct scenario_cmd {
 	struct scenario_cmd_data req;
 	struct scenario_cmd_data resp;
 	uint8_t cc;
+	size_t resp_size;
 };
 
 struct scenario_sel {
@@ -177,6 +178,9 @@  void ipmi_queue_msg_sync(struct ipmi_msg *msg)
 	msg->cc = cmd->cc;
 	memcpy(msg->data, &cmd->resp, msg->resp_size);
 
+	if (cmd->resp_size)
+		msg->resp_size = cmd->resp_size;
+
 	msg->complete(msg);
 
 	ctx->cursor++;
@@ -1698,6 +1702,60 @@  static void test_hiomap_erase_error(void)
 	scenario_exit();
 }
 
+static const struct scenario_event scenario_hiomap_ack_malformed_small[] = {
+	{
+		.type = scenario_cmd,
+		.c = {
+			.req = {
+				.cmd = HIOMAP_C_ACK,
+				.seq = 1,
+				.args = { [0] = 0x3 },
+			},
+			.cc = IPMI_CC_NO_ERROR,
+			.resp_size = 1
+		},
+	},
+	SCENARIO_SENTINEL,
+};
+
+static void test_hiomap_ack_malformed_small(void)
+{
+	struct blocklevel_device *bl;
+
+	scenario_enter(scenario_hiomap_ack_malformed_small);
+	assert(ipmi_hiomap_init(&bl) > 0);
+	scenario_exit();
+}
+
+static const struct scenario_event scenario_hiomap_ack_malformed_large[] = {
+	{
+		.type = scenario_cmd,
+		.c = {
+			.req = {
+				.cmd = HIOMAP_C_ACK,
+				.seq = 1,
+				.args = { [0] = 0x3 },
+			},
+			.cc = IPMI_CC_NO_ERROR,
+			.resp_size = 3,
+			.resp = {
+				.cmd = HIOMAP_C_ACK,
+				.seq = 1,
+			},
+		},
+	},
+	SCENARIO_SENTINEL,
+};
+
+static void test_hiomap_ack_malformed_large(void)
+{
+	struct blocklevel_device *bl;
+
+	scenario_enter(scenario_hiomap_ack_malformed_large);
+	assert(ipmi_hiomap_init(&bl) > 0);
+	scenario_exit();
+}
+
 struct test_case {
 	const char *name;
 	void (*fn)(void);
@@ -1737,6 +1795,8 @@  struct test_case test_cases[] = {
 	TEST_CASE(test_hiomap_flush_error),
 	TEST_CASE(test_hiomap_ack_error),
 	TEST_CASE(test_hiomap_erase_error),
+	TEST_CASE(test_hiomap_ack_malformed_small),
+	TEST_CASE(test_hiomap_ack_malformed_large),
 	{ NULL, NULL },
 };