diff mbox series

[v2,13/52] libflash/ipmi-hiomap: Remove unused close handling

Message ID 20190221062851.21958-14-andrew@aj.id.au
State Accepted
Headers show
Series ipmi-hiomap: Tests and fixes for event handling | expand

Commit Message

Andrew Jeffery Feb. 21, 2019, 6:28 a.m. UTC 
Issuing a HIOMAP_C_CLOSE is not required by the protocol specification,
rather a close can be implicit in a subsequent
CREATE_{READ,WRITE}_WINDOW request. The implicit close provides an
opportunity to reduce LPC traffic and the implementation takes up that
optimisation, so remove the case from the IPMI callback handler.

Cc: stable
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
 libflash/ipmi-hiomap.c | 5 -----
 1 file changed, 5 deletions(-)
diff mbox series

Patch

diff --git a/libflash/ipmi-hiomap.c b/libflash/ipmi-hiomap.c
index fdd12d5754e2..7a36449a5d0b 100644
--- a/libflash/ipmi-hiomap.c
+++ b/libflash/ipmi-hiomap.c
@@ -204,11 +204,6 @@  static void ipmi_hiomap_cmd_cb(struct ipmi_msg *msg)
 
 		break;
 	}
-	case HIOMAP_C_CLOSE_WINDOW:
-		lock(&ctx->lock);
-		ctx->window_state = closed_window;
-		unlock(&ctx->lock);
-		break;
 	case HIOMAP_C_MARK_DIRTY:
 	case HIOMAP_C_FLUSH:
 	case HIOMAP_C_ACK: