diff mbox series

[U-Boot,v9,06/15] net: macb: Fix clk API usage for RISC-V systems

Message ID 20190221042936.13441-7-anup.patel@wdc.com
State Superseded
Delegated to: Andes
Headers show
Series SiFive FU540 Support | expand

Commit Message

Anup Patel Feb. 21, 2019, 4:30 a.m. UTC 
Don't fail in macb_enable_clk() if clk_enable() returns
-ENOSYS because we get -ENOSYS for fixed-rate clocks.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
 drivers/net/macb.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Comments

Joe Hershberger Feb. 21, 2019, 6:35 p.m. UTC | #1 
On Wed, Feb 20, 2019 at 10:36 PM Anup Patel <Anup.Patel@wdc.com> wrote:
>
> Don't fail in macb_enable_clk() if clk_enable() returns
> -ENOSYS because we get -ENOSYS for fixed-rate clocks.
>
> Signed-off-by: Anup Patel <anup.patel@wdc.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
diff mbox series

Patch

diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index c9ee22279a..0254e211e6 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -1061,14 +1061,13 @@  static int macb_enable_clk(struct udevice *dev)
 		return -EINVAL;
 
 	/*
-	 * Zynq clock driver didn't support for enable or disable
-	 * clock. Hence, clk_enable() didn't apply for Zynq
+	 * If clock driver didn't support enable or disable then
+	 * we get -ENOSYS from clk_enable(). To handle this, we
+	 * don't fail for ret == -ENOSYS.
 	 */
-#ifndef CONFIG_MACB_ZYNQ
 	ret = clk_enable(&clk);
-	if (ret)
+	if (ret && ret != -ENOSYS)
 		return ret;
-#endif
 
 	clk_rate = clk_get_rate(&clk);
 	if (!clk_rate)