From patchwork Wed Jul 13 17:17:03 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 104568 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 3A39CB6F18 for ; Thu, 14 Jul 2011 03:17:53 +1000 (EST) Received: (qmail 12853 invoked by alias); 13 Jul 2011 17:17:51 -0000 Received: (qmail 12843 invoked by uid 22791); 13 Jul 2011 17:17:50 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtprelay03.ispgateway.de (HELO smtprelay03.ispgateway.de) (80.67.31.26) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jul 2011 17:17:34 +0000 Received: from [87.180.39.191] (helo=stokes.schwinge.homeip.net) by smtprelay03.ispgateway.de with esmtpa (Exim 4.68) (envelope-from ) id 1Qh341-0005Fl-3Y for gcc-patches@gcc.gnu.org; Wed, 13 Jul 2011 19:17:33 +0200 Received: (qmail 14761 invoked from network); 13 Jul 2011 17:17:07 -0000 Received: from kepler.schwinge.homeip.net (192.168.111.7) by stokes.schwinge.homeip.net with QMQP; 13 Jul 2011 17:17:07 -0000 Received: (nullmailer pid 28197 invoked by uid 1000); Wed, 13 Jul 2011 17:17:06 -0000 From: Thomas Schwinge To: Paolo Bonzini Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] bash vs. dash: Avoid unportable shell feature in gcc/configure.ac In-Reply-To: <4E1DC696.10102@gnu.org> References: <87mxgi5fch.fsf@kepler.schwinge.homeip.net> <4E1DC696.10102@gnu.org> User-Agent: Notmuch/0.5-77-g335dd52 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Wed, 13 Jul 2011 19:17:03 +0200 Message-ID: <87fwma5cds.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 X-Df-Sender: thomas@schwinge.name Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hallo! On Wed, 13 Jul 2011 18:23:50 +0200, Paolo Bonzini wrote: > On 07/13/2011 06:13 PM, Thomas Schwinge wrote: > > Alternatively, gcc_GAS_CHECK_FEATURE could be changed to emit the > > temporary file by using a shell here-doc, which is what AC_TRY_COMPILE is > > doing, for example. > > Change instead echo ifelse(...) > conftest.s to > > AS_ECHO([m4_if(...)]) > conftest.s > > in gcc_GAS_CHECK_FEATURE. Ah, even better. gcc/ * acinclude.m4 (gcc_GAS_CHECK_FEATURE): Use AS_ECHO instead of echo. * configure: Regenerate. The configure differences are strictly s%echo%$as_echo%. Grüße, Thomas diff --git a/gcc/acinclude.m4 b/gcc/acinclude.m4 index ff38682..f092925 100644 --- a/gcc/acinclude.m4 +++ b/gcc/acinclude.m4 @@ -583,7 +583,7 @@ AC_CACHE_CHECK([assembler for $1], [$2], if test $in_tree_gas = yes; then gcc_GAS_VERSION_GTE_IFELSE($3, [[$2]=yes]) el])if test x$gcc_cv_as != x; then - echo ifelse(m4_substr([$5],0,1),[$], "[$5]", '[$5]') > conftest.s + AS_ECHO([ifelse(m4_substr([$5],0,1),[$], "[$5]", '[$5]')]) > conftest.s if AC_TRY_COMMAND([$gcc_cv_as $gcc_cv_as_flags $4 -o conftest.o conftest.s >&AS_MESSAGE_LOG_FD]) then ifelse([$6],, [$2]=yes, [$6])