[SRU,D,1/2] net: ena: fix race between link up and device initalization
diff mbox series

Message ID 20190220165703.24093-2-kamal@canonical.com
State New
Headers show
  • update ENA driver to 2.0.3K
Related show

Commit Message

Kamal Mostafa Feb. 20, 2019, 4:57 p.m. UTC
From: Arthur Kiyanovski <akiyano@amazon.com>

BugLink: http://bugs.launchpad.net/bugs/1816806

Fix race condition between ena_update_on_link_change() and

This race can occur if link notification arrives while the driver
is performing a reset sequence. In this case link can be set up,
enabling the device, before it is fully restored. If packets are
sent at this time, the driver might access uninitialized data
structures, causing kernel crash.

Move the clearing of ENA_FLAG_ONGOING_RESET and netif_carrier_on()
after ena_up() to ensure the device is ready when link is set up.

Fixes: d18e4f683445 ("net: ena: fix race condition between device reset and link up setup")
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit e1f1bd9bfbedcfce428ee7e1b82a6ec12d4c3863)
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff mbox series

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 05a27496c224..64777516a0e1 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -2663,11 +2663,6 @@  static int ena_restore_device(struct ena_adapter *adapter)
 		goto err_device_destroy;
-	clear_bit(ENA_FLAG_ONGOING_RESET, &adapter->flags);
-	/* Make sure we don't have a race with AENQ Links state handler */
-	if (test_bit(ENA_FLAG_LINK_UP, &adapter->flags))
-		netif_carrier_on(adapter->netdev);
 	rc = ena_enable_msix_and_set_admin_interrupts(adapter,
 	if (rc) {
@@ -2684,6 +2679,11 @@  static int ena_restore_device(struct ena_adapter *adapter)
 	set_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags);
+	clear_bit(ENA_FLAG_ONGOING_RESET, &adapter->flags);
+	if (test_bit(ENA_FLAG_LINK_UP, &adapter->flags))
+		netif_carrier_on(adapter->netdev);
 	mod_timer(&adapter->timer_service, round_jiffies(jiffies + HZ));
 		"Device reset completed successfully, Driver info: %s\n",