diff mbox series

[v5,1/3] dt-bindings: pwm-stm32-lp: document pinctrl sleep state

Message ID 1550668068-9661-2-git-send-email-fabrice.gasnier@st.com
State Superseded
Headers show
Series Add PM support to STM32 LP Timer drivers | expand

Commit Message

Fabrice Gasnier Feb. 20, 2019, 1:07 p.m. UTC 
Add documentation for pinctrl sleep state on STM32 LPTimer PWM.

Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/pwm/pwm-stm32-lp.txt | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Uwe Kleine-König Feb. 20, 2019, 2:26 p.m. UTC | #1 
On Wed, Feb 20, 2019 at 02:07:46PM +0100, Fabrice Gasnier wrote:
> Add documentation for pinctrl sleep state on STM32 LPTimer PWM.
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

nitpick (i.e. no need to resend): Your Signed-off-by should be the last
thing in your commit log. Assuming your patch ends in mainline in the
end with Thierry taking it it should be

	Signed-off-by: Fabrice
	Reviewed-by: Rob
	Signed-off-by: Thierry

if it was Thierry who added Rob's Reviewed-by tag and it should be

	Reviewed-by: Rob
	Signed-off-by: Fabrice
	Signed-off-by: Thierry

if it was you.

Best regards
Uwe
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pwm/pwm-stm32-lp.txt b/Documentation/devicetree/bindings/pwm/pwm-stm32-lp.txt
index bd23302..6521bc4 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-stm32-lp.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm-stm32-lp.txt
@@ -11,8 +11,10 @@  Required parameters:
 			bindings defined in pwm.txt.
 
 Optional properties:
-- pinctrl-names: 	Set to "default".
-- pinctrl-0: 		Phandle pointing to pin configuration node for PWM.
+- pinctrl-names: 	Set to "default". An additional "sleep" state can be
+			defined to set pins in sleep state when in low power.
+- pinctrl-n: 		Phandle(s) pointing to pin configuration node for PWM,
+			respectively for "default" and "sleep" states.
 
 Example:
 	timer@40002400 {
@@ -21,7 +23,8 @@  Example:
 		pwm {
 			compatible = "st,stm32-pwm-lp";
 			#pwm-cells = <3>;
-			pinctrl-names = "default";
+			pinctrl-names = "default", "sleep";
 			pinctrl-0 = <&lppwm1_pins>;
+			pinctrl-1 = <&lppwm1_sleep_pins>;
 		};
 	};