[10/18] defconfig: enable MACsec
diff mbox series

Message ID 20190219134421.663957-11-lkundrak@v3.sk
State New
Headers show
Series
  • defconfig: enable commonly used set of options
Related show

Commit Message

Lubomir Rintel Feb. 19, 2019, 1:44 p.m. UTC
Debian and Fedora enable it, NetworkManager uses it.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 wpa_supplicant/defconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Johannes Berg Feb. 19, 2019, 2:12 p.m. UTC | #1
On Tue, 2019-02-19 at 14:44 +0100, Lubomir Rintel wrote:
> Debian and Fedora enable it, NetworkManager uses it.

Jouni was worried that too many distros still can't compile this due to
missing headers/dependencies?

johannes
Lubomir Rintel Feb. 20, 2019, 10:25 a.m. UTC | #2
On Tue, 2019-02-19 at 15:12 +0100, Johannes Berg wrote:
> On Tue, 2019-02-19 at 14:44 +0100, Lubomir Rintel wrote:
> > Debian and Fedora enable it, NetworkManager uses it.
> 
> Jouni was worried that too many distros still can't compile this due to
> missing headers/dependencies?

Yes. I think it still makes sense to have this enabled by default.
Currently basically all distros roll their own configs, and at the
point they switch their master/devel packages to use the upstream
defconfig, they should also enable MACsec.

If there's anyone who uses a new supplicant with old-ish kernel, it's
trivial to just comment the thing out.

> 
> johannes

Lubo
Jouni Malinen Feb. 25, 2019, 5:26 p.m. UTC | #3
On Wed, Feb 20, 2019 at 11:25:47AM +0100, Lubomir Rintel wrote:
> On Tue, 2019-02-19 at 15:12 +0100, Johannes Berg wrote:
> > On Tue, 2019-02-19 at 14:44 +0100, Lubomir Rintel wrote:
> > > Debian and Fedora enable it, NetworkManager uses it.
> > 
> > Jouni was worried that too many distros still can't compile this due to
> > missing headers/dependencies?
> 
> Yes. I think it still makes sense to have this enabled by default.
> Currently basically all distros roll their own configs, and at the
> point they switch their master/devel packages to use the upstream
> defconfig, they should also enable MACsec.
> 
> If there's anyone who uses a new supplicant with old-ish kernel, it's
> trivial to just comment the thing out.

Having an old kernel is not issue since that gets handled at runtime.
Having an old (and well, not really _that_ old) kernel header files and
libnl is more of an issue since that breaks the build due to missing
linux/if_macsec.h and/or netlink/route/link/macsec.h.

Patch
diff mbox series

diff --git a/wpa_supplicant/defconfig b/wpa_supplicant/defconfig
index 83d12d663..19585da60 100644
--- a/wpa_supplicant/defconfig
+++ b/wpa_supplicant/defconfig
@@ -77,7 +77,7 @@  CONFIG_DRIVER_WIRED=y
 #CONFIG_DRIVER_MACSEC_QCA=y
 
 # Driver interface for Linux MACsec drivers
-#CONFIG_DRIVER_MACSEC_LINUX=y
+CONFIG_DRIVER_MACSEC_LINUX=y
 
 # Driver interface for the Broadcom RoboSwitch family
 #CONFIG_DRIVER_ROBOSWITCH=y
@@ -173,7 +173,7 @@  CONFIG_WPS=y
 #CONFIG_EAP_EKE=y
 
 # MACsec
-#CONFIG_MACSEC=y
+CONFIG_MACSEC=y
 
 # PKCS#12 (PFX) support (used to read private key and certificate file from
 # a file that usually has extension .p12 or .pfx)