[05/18] defconfig: enable DBus
diff mbox series

Message ID 20190219134421.663957-6-lkundrak@v3.sk
State Accepted
Headers show
Series
  • defconfig: enable commonly used set of options
Related show

Commit Message

Lubomir Rintel Feb. 19, 2019, 1:44 p.m. UTC
Acquire both legacy and new name, along with introspection. This is
generally useful for other daemons to integrate with wpa_supplicant,
notably NetworkManager.

Debian and Fedora (and likely any other distro that configured wireless
via NetworkManager) enable this.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 wpa_supplicant/defconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Jouni Malinen Feb. 25, 2019, 5:21 p.m. UTC | #1
On Tue, Feb 19, 2019 at 02:44:08PM +0100, Lubomir Rintel wrote:
> Acquire both legacy and new name, along with introspection. This is
> generally useful for other daemons to integrate with wpa_supplicant,
> notably NetworkManager.
> 
> Debian and Fedora (and likely any other distro that configured wireless
> via NetworkManager) enable this.

>  # Add support for old DBus control interface
>  # (fi.epitest.hostap.WPASupplicant)
> -#CONFIG_CTRL_IFACE_DBUS=y
> +CONFIG_CTRL_IFACE_DBUS=y

Why would this obsolete old interface be needed? I'd much rather remove
this completely than promote it by enabling it in more builds..

>  # Add support for new DBus control interface
>  # (fi.w1.hostap.wpa_supplicant1)
> -#CONFIG_CTRL_IFACE_DBUS_NEW=y
> +CONFIG_CTRL_IFACE_DBUS_NEW=y
>  
>  # Add introspection support for new DBus control interface
> -#CONFIG_CTRL_IFACE_DBUS_INTRO=y
> +CONFIG_CTRL_IFACE_DBUS_INTRO=y

These make sense, though, and I'd hope all current programs would use
the new D-Bus interface since the old one is not really maintained
anymore and is considered obsolete.
Lubomir Rintel Feb. 26, 2019, 9:55 a.m. UTC | #2
On Mon, 2019-02-25 at 19:21 +0200, Jouni Malinen wrote:
> On Tue, Feb 19, 2019 at 02:44:08PM +0100, Lubomir Rintel wrote:
> > Acquire both legacy and new name, along with introspection. This is
> > generally useful for other daemons to integrate with wpa_supplicant,
> > notably NetworkManager.
> > 
> > Debian and Fedora (and likely any other distro that configured wireless
> > via NetworkManager) enable this.
> >  # Add support for old DBus control interface
> >  # (fi.epitest.hostap.WPASupplicant)
> > -#CONFIG_CTRL_IFACE_DBUS=y
> > +CONFIG_CTRL_IFACE_DBUS=y
> 
> Why would this obsolete old interface be needed? I'd much rather remove
> this completely than promote it by enabling it in more builds..

Agreed. According to searchcode [1] not much more than 2010's
NetworkManager 0.8 uses this. Pretty sure it's safe to remove it.

[1] https://searchcode.com/?q=%22fi.epitest.hostap.WPASupplicant%22

I'll follow up with a patch that does the removal.

> >  # Add support for new DBus control interface
> >  # (fi.w1.hostap.wpa_supplicant1)
> > -#CONFIG_CTRL_IFACE_DBUS_NEW=y
> > +CONFIG_CTRL_IFACE_DBUS_NEW=y
> >  
> >  # Add introspection support for new DBus control interface
> > -#CONFIG_CTRL_IFACE_DBUS_INTRO=y
> > +CONFIG_CTRL_IFACE_DBUS_INTRO=y
> 
> These make sense, though, and I'd hope all current programs would use
> the new D-Bus interface since the old one is not really maintained
> anymore and is considered obsolete.

Lubo
Andrej Shadura Feb. 26, 2019, 11:16 a.m. UTC | #3
On Tue, 26 Feb 2019 at 10:55, Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> On Mon, 2019-02-25 at 19:21 +0200, Jouni Malinen wrote:
> > On Tue, Feb 19, 2019 at 02:44:08PM +0100, Lubomir Rintel wrote:
> > > Acquire both legacy and new name, along with introspection. This is
> > > generally useful for other daemons to integrate with wpa_supplicant,
> > > notably NetworkManager.
> > >
> > > Debian and Fedora (and likely any other distro that configured wireless
> > > via NetworkManager) enable this.
> > >  # Add support for old DBus control interface
> > >  # (fi.epitest.hostap.WPASupplicant)
> > > -#CONFIG_CTRL_IFACE_DBUS=y
> > > +CONFIG_CTRL_IFACE_DBUS=y
> >
> > Why would this obsolete old interface be needed? I'd much rather remove
> > this completely than promote it by enabling it in more builds..
>
> Agreed. According to searchcode [1] not much more than 2010's
> NetworkManager 0.8 uses this. Pretty sure it's safe to remove it.
>
> [1] https://searchcode.com/?q=%22fi.epitest.hostap.WPASupplicant%22
>
> I'll follow up with a patch that does the removal.

Indeed. Nothing in Debian really uses it at the moment:

https://codesearch.debian.net/search?q=fi.epitest.hostap.WPASupplicant
Jouni Malinen March 9, 2019, 5:27 p.m. UTC | #4
On Tue, Feb 19, 2019 at 02:44:08PM +0100, Lubomir Rintel wrote:
> Acquire both legacy and new name, along with introspection. This is
> generally useful for other daemons to integrate with wpa_supplicant,
> notably NetworkManager.
> 
> Debian and Fedora (and likely any other distro that configured wireless
> via NetworkManager) enable this.

Thanks, applied with the +CONFIG_CTRL_IFACE_DBUS=y part removed now that
the old D-Bus interface got dropped completely.

Patch
diff mbox series

diff --git a/wpa_supplicant/defconfig b/wpa_supplicant/defconfig
index b7b87d18a..528504423 100644
--- a/wpa_supplicant/defconfig
+++ b/wpa_supplicant/defconfig
@@ -357,14 +357,14 @@  CONFIG_BACKEND=file
 
 # Add support for old DBus control interface
 # (fi.epitest.hostap.WPASupplicant)
-#CONFIG_CTRL_IFACE_DBUS=y
+CONFIG_CTRL_IFACE_DBUS=y
 
 # Add support for new DBus control interface
 # (fi.w1.hostap.wpa_supplicant1)
-#CONFIG_CTRL_IFACE_DBUS_NEW=y
+CONFIG_CTRL_IFACE_DBUS_NEW=y
 
 # Add introspection support for new DBus control interface
-#CONFIG_CTRL_IFACE_DBUS_INTRO=y
+CONFIG_CTRL_IFACE_DBUS_INTRO=y
 
 # Add support for loading EAP methods dynamically as shared libraries.
 # When this option is enabled, each EAP method can be either included