| Message ID | 20190219080622.17312-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: rose: add missing dev_put() on error in rose_bind | expand |
From: YueHaibing <yuehaibing@huawei.com> Date: Tue, 19 Feb 2019 16:06:22 +0800 > when capable check failed, dev_put should > be call before return -EACCES. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied.
diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c index d00a0ef..c96f63f 100644 --- a/net/rose/af_rose.c +++ b/net/rose/af_rose.c @@ -689,8 +689,10 @@ static int rose_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) rose->source_call = user->call; ax25_uid_put(user); } else { - if (ax25_uid_policy && !capable(CAP_NET_BIND_SERVICE)) + if (ax25_uid_policy && !capable(CAP_NET_BIND_SERVICE)) { + dev_put(dev); return -EACCES; + } rose->source_call = *source; }
when capable check failed, dev_put should be call before return -EACCES. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- net/rose/af_rose.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)