| Message ID | 1550548041-32682-2-git-send-email-tien.fong.chee@intel.com |
|---|---|
| State | Superseded |
| Delegated to: | Marek Vasut |
| Headers | show |
| Series | Add support for loading FPGA bitstream | expand |
On 19. 02. 19 4:47, tien.fong.chee@intel.com wrote: > From: Tien Fong Chee <tien.fong.chee@intel.com> > > This patch adds description on properties about file name used for both > peripheral bitstream and core bitstream. > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > > --- > > changes for v8 > - Removed explanation about support for altr,bitstream-core > > changes for v7 > - Provided example of setting FPGA FIT image for both early IO release > and full release FPGA configuration. > --- > .../fpga/altera-socfpga-a10-fpga-mgr.txt | 26 +++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt > index 2fd8e7a..da210bf 100644 > --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt > +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt > @@ -7,8 +7,31 @@ Required properties: > - The second index is for writing FPGA configuration data. > - resets : Phandle and reset specifier for the device's reset. > - clocks : Clocks used by the device. > +- altr,bitstream : Fit image file name for both FPGA peripheral bitstream, > + FPGA core bitstream and full bitstream. > By adding new required property you are automatically saying that you want to break all current users. M
On Tue, 2019-02-26 at 15:06 +0100, Michal Simek wrote: > On 19. 02. 19 4:47, tien.fong.chee@intel.com wrote: > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > This patch adds description on properties about file name used for > > both > > peripheral bitstream and core bitstream. > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > > > > --- > > > > changes for v8 > > - Removed explanation about support for altr,bitstream-core > > > > changes for v7 > > - Provided example of setting FPGA FIT image for both early IO > > release > > and full release FPGA configuration. > > --- > > .../fpga/altera-socfpga-a10-fpga-mgr.txt | 26 > > +++++++++++++++++++++- > > 1 file changed, 25 insertions(+), 1 deletion(-) > > > > diff --git a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- > > mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- > > mgr.txt > > index 2fd8e7a..da210bf 100644 > > --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt > > +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt > > @@ -7,8 +7,31 @@ Required properties: > > - The second index is for writing FPGA > > configuration data. > > - resets : Phandle and reset specifier for the device's reset. > > - clocks : Clocks used by the device. > > +- altr,bitstream : Fit image file name for both FPGA peripheral > > bitstream, > > + FPGA core bitstream and full bitstream. > > > By adding new required property you are automatically saying that you > want to break all current users. This is company's product specific property, that's why with prefix "altr". DT allows that ,right? > > M > >
On 26. 02. 19 15:28, Chee, Tien Fong wrote: > On Tue, 2019-02-26 at 15:06 +0100, Michal Simek wrote: >> On 19. 02. 19 4:47, tien.fong.chee@intel.com wrote: >>> >>> From: Tien Fong Chee <tien.fong.chee@intel.com> >>> >>> This patch adds description on properties about file name used for >>> both >>> peripheral bitstream and core bitstream. >>> >>> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> >>> >>> --- >>> >>> changes for v8 >>> - Removed explanation about support for altr,bitstream-core >>> >>> changes for v7 >>> - Provided example of setting FPGA FIT image for both early IO >>> release >>> and full release FPGA configuration. >>> --- >>> .../fpga/altera-socfpga-a10-fpga-mgr.txt | 26 >>> +++++++++++++++++++++- >>> 1 file changed, 25 insertions(+), 1 deletion(-) >>> >>> diff --git a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- >>> mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- >>> mgr.txt >>> index 2fd8e7a..da210bf 100644 >>> --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt >>> +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt >>> @@ -7,8 +7,31 @@ Required properties: >>> - The second index is for writing FPGA >>> configuration data. >>> - resets : Phandle and reset specifier for the device's reset. >>> - clocks : Clocks used by the device. >>> +- altr,bitstream : Fit image file name for both FPGA peripheral >>> bitstream, >>> + FPGA core bitstream and full bitstream. >>> >> By adding new required property you are automatically saying that you >> want to break all current users. > This is company's product specific property, that's why with prefix > "altr". DT allows that ,right? no issue with altr prefix. Issue is that you add a required property and breaking all current users. It should be optional. M
On Tue, 2019-02-26 at 16:42 +0100, Michal Simek wrote: > On 26. 02. 19 15:28, Chee, Tien Fong wrote: > > On Tue, 2019-02-26 at 15:06 +0100, Michal Simek wrote: > > > On 19. 02. 19 4:47, tien.fong.chee@intel.com wrote: > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > > > This patch adds description on properties about file name used for > > > > both > > > > peripheral bitstream and core bitstream. > > > > > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > > > --- > > > > > > > > changes for v8 > > > > - Removed explanation about support for altr,bitstream-core > > > > > > > > changes for v7 > > > > - Provided example of setting FPGA FIT image for both early IO > > > > release > > > > and full release FPGA configuration. > > > > --- > > > > .../fpga/altera-socfpga-a10-fpga-mgr.txt | 26 > > > > +++++++++++++++++++++- > > > > 1 file changed, 25 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- > > > > mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- > > > > mgr.txt > > > > index 2fd8e7a..da210bf 100644 > > > > --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt > > > > +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt > > > > @@ -7,8 +7,31 @@ Required properties: > > > > - The second index is for writing FPGA > > > > configuration data. > > > > - resets : Phandle and reset specifier for the device's reset. > > > > - clocks : Clocks used by the device. > > > > +- altr,bitstream : Fit image file name for both FPGA peripheral > > > > bitstream, > > > > + FPGA core bitstream and full bitstream. > > > > > > > By adding new required property you are automatically saying that you > > > want to break all current users. > > This is company's product specific property, that's why with prefix > > "altr". DT allows that ,right? > > no issue with altr prefix. Issue is that you add a required property and > breaking all current users. > It should be optional. This parameter is only for Arria10, which at this point is not fully supported in mainline uboot. So this doesnt affect any existing designs, no? --dalon > > M > > >
On Tue, 2019-02-26 at 07:58 -0800, Dalon L Westergreen wrote: > On Tue, 2019-02-26 at 16:42 +0100, Michal Simek wrote: > > > > On 26. 02. 19 15:28, Chee, Tien Fong wrote: > > > > > > On Tue, 2019-02-26 at 15:06 +0100, Michal Simek wrote: > > > > > > > > On 19. 02. 19 4:47, tien.fong.chee@intel.com wrote: > > > > > > > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > > > > > This patch adds description on properties about file name > > > > > used for > > > > > both > > > > > peripheral bitstream and core bitstream. > > > > > > > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > > > > > --- > > > > > > > > > > changes for v8 > > > > > - Removed explanation about support for altr,bitstream-core > > > > > > > > > > changes for v7 > > > > > - Provided example of setting FPGA FIT image for both early > > > > > IO > > > > > release > > > > > and full release FPGA configuration. > > > > > --- > > > > > .../fpga/altera-socfpga-a10-fpga-mgr.txt | 26 > > > > > +++++++++++++++++++++- > > > > > 1 file changed, 25 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/doc/device-tree-bindings/fpga/altera-socfpga- > > > > > a10-fpga- > > > > > mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10- > > > > > fpga- > > > > > mgr.txt > > > > > index 2fd8e7a..da210bf 100644 > > > > > --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- > > > > > mgr.txt > > > > > +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- > > > > > mgr.txt > > > > > @@ -7,8 +7,31 @@ Required properties: > > > > > - The second index is for writing FPGA > > > > > configuration data. > > > > > - resets : Phandle and reset specifier for the device's > > > > > reset. > > > > > - clocks : Clocks used by the device. > > > > > +- altr,bitstream : Fit image file name for both FPGA > > > > > peripheral > > > > > bitstream, > > > > > + FPGA core bitstream and full bitstream. > > > > > > > > > By adding new required property you are automatically saying > > > > that you > > > > want to break all current users. > > > This is company's product specific property, that's why with > > > prefix > > > "altr". DT allows that ,right? > > no issue with altr prefix. Issue is that you add a required > > property and > > breaking all current users. > > It should be optional. > This parameter is only for Arria10, which at this point is not fully > supported > in mainline uboot. So this doesnt affect any existing designs, no? Yeah, how this breaking all current users? This property in only used for the A10 fpga driver with fit implementation. > > --dalon > > > > > > > M > > > > > >
On 27. 02. 19 7:37, Chee, Tien Fong wrote: > On Tue, 2019-02-26 at 07:58 -0800, Dalon L Westergreen wrote: >> On Tue, 2019-02-26 at 16:42 +0100, Michal Simek wrote: >>> >>> On 26. 02. 19 15:28, Chee, Tien Fong wrote: >>>> >>>> On Tue, 2019-02-26 at 15:06 +0100, Michal Simek wrote: >>>>> >>>>> On 19. 02. 19 4:47, tien.fong.chee@intel.com wrote: >>>>>> >>>>>> From: Tien Fong Chee <tien.fong.chee@intel.com> >>>>>> >>>>>> This patch adds description on properties about file name >>>>>> used for >>>>>> both >>>>>> peripheral bitstream and core bitstream. >>>>>> >>>>>> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> >>>>>> >>>>>> --- >>>>>> >>>>>> changes for v8 >>>>>> - Removed explanation about support for altr,bitstream-core >>>>>> >>>>>> changes for v7 >>>>>> - Provided example of setting FPGA FIT image for both early >>>>>> IO >>>>>> release >>>>>> and full release FPGA configuration. >>>>>> --- >>>>>> .../fpga/altera-socfpga-a10-fpga-mgr.txt | 26 >>>>>> +++++++++++++++++++++- >>>>>> 1 file changed, 25 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/doc/device-tree-bindings/fpga/altera-socfpga- >>>>>> a10-fpga- >>>>>> mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10- >>>>>> fpga- >>>>>> mgr.txt >>>>>> index 2fd8e7a..da210bf 100644 >>>>>> --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- >>>>>> mgr.txt >>>>>> +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga- >>>>>> mgr.txt >>>>>> @@ -7,8 +7,31 @@ Required properties: >>>>>> - The second index is for writing FPGA >>>>>> configuration data. >>>>>> - resets : Phandle and reset specifier for the device's >>>>>> reset. >>>>>> - clocks : Clocks used by the device. >>>>>> +- altr,bitstream : Fit image file name for both FPGA >>>>>> peripheral >>>>>> bitstream, >>>>>> + FPGA core bitstream and full bitstream. >>>>>> >>>>> By adding new required property you are automatically saying >>>>> that you >>>>> want to break all current users. >>>> This is company's product specific property, that's why with >>>> prefix >>>> "altr". DT allows that ,right? >>> no issue with altr prefix. Issue is that you add a required >>> property and >>> breaking all current users. >>> It should be optional. >> This parameter is only for Arria10, which at this point is not fully >> supported >> in mainline uboot. So this doesnt affect any existing designs, no? > > Yeah, how this breaking all current users? This property in only used > for the A10 fpga driver with fit implementation. That you use latest u-boot with previous DT(or our of tree DT which doesn't have this property). M
On Wed, 2019-02-27 at 10:13 +0100, Michal Simek wrote: > On 27. 02. 19 7:37, Chee, Tien Fong wrote: > > > > On Tue, 2019-02-26 at 07:58 -0800, Dalon L Westergreen wrote: > > > > > > On Tue, 2019-02-26 at 16:42 +0100, Michal Simek wrote: > > > > > > > > > > > > On 26. 02. 19 15:28, Chee, Tien Fong wrote: > > > > > > > > > > > > > > > On Tue, 2019-02-26 at 15:06 +0100, Michal Simek wrote: > > > > > > > > > > > > > > > > > > On 19. 02. 19 4:47, tien.fong.chee@intel.com wrote: > > > > > > > > > > > > > > > > > > > > > From: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > > > > > > > > > This patch adds description on properties about file name > > > > > > > used for > > > > > > > both > > > > > > > peripheral bitstream and core bitstream. > > > > > > > > > > > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com> > > > > > > > > > > > > > > --- > > > > > > > > > > > > > > changes for v8 > > > > > > > - Removed explanation about support for altr,bitstream- > > > > > > > core > > > > > > > > > > > > > > changes for v7 > > > > > > > - Provided example of setting FPGA FIT image for both > > > > > > > early > > > > > > > IO > > > > > > > release > > > > > > > and full release FPGA configuration. > > > > > > > --- > > > > > > > .../fpga/altera-socfpga-a10-fpga-mgr.txt | 26 > > > > > > > +++++++++++++++++++++- > > > > > > > 1 file changed, 25 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git a/doc/device-tree-bindings/fpga/altera- > > > > > > > socfpga- > > > > > > > a10-fpga- > > > > > > > mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga- > > > > > > > a10- > > > > > > > fpga- > > > > > > > mgr.txt > > > > > > > index 2fd8e7a..da210bf 100644 > > > > > > > --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10- > > > > > > > fpga- > > > > > > > mgr.txt > > > > > > > +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10- > > > > > > > fpga- > > > > > > > mgr.txt > > > > > > > @@ -7,8 +7,31 @@ Required properties: > > > > > > > - The second index is for writing FPGA > > > > > > > configuration data. > > > > > > > - resets : Phandle and reset specifier for the > > > > > > > device's > > > > > > > reset. > > > > > > > - clocks : Clocks used by the device. > > > > > > > +- altr,bitstream : Fit image file name for both FPGA > > > > > > > peripheral > > > > > > > bitstream, > > > > > > > + FPGA core bitstream and full > > > > > > > bitstream. > > > > > > > > > > > > > By adding new required property you are automatically > > > > > > saying > > > > > > that you > > > > > > want to break all current users. > > > > > This is company's product specific property, that's why with > > > > > prefix > > > > > "altr". DT allows that ,right? > > > > no issue with altr prefix. Issue is that you add a required > > > > property and > > > > breaking all current users. > > > > It should be optional. > > > This parameter is only for Arria10, which at this point is not > > > fully > > > supported > > > in mainline uboot. So this doesnt affect any existing designs, > > > no? > > Yeah, how this breaking all current users? This property in only > > used > > for the A10 fpga driver with fit implementation. > That you use latest u-boot with previous DT(or our of tree DT which > doesn't have this property). Sorry, i'm still not getting you. My understanding "breaking" means the existing driver would stop working after A10 DT is applied. May be you can tell us breaking what driver? What you means with previous DT? Which DT you means? This series of patches are the 1st one fully support A10 SDMMC in mainline. How this related to your DT? Thanks, TF
diff --git a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt index 2fd8e7a..da210bf 100644 --- a/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt +++ b/doc/device-tree-bindings/fpga/altera-socfpga-a10-fpga-mgr.txt @@ -7,8 +7,31 @@ Required properties: - The second index is for writing FPGA configuration data. - resets : Phandle and reset specifier for the device's reset. - clocks : Clocks used by the device. +- altr,bitstream : Fit image file name for both FPGA peripheral bitstream, + FPGA core bitstream and full bitstream. -Example: + Full bitstream, consist of peripheral bitstream and core + bitstream. + + FPGA peripheral bitstream is used to initialize FPGA IOs, + PLL, IO48 and DDR. This bitstream is required to get DDR up + running. + + FPGA core bitstream contains FPGA design which is used to + program FPGA CRAM and ERAM. + +Example: Bundles both peripheral bitstream and core bitstream into FIT image + called fit_spl_fpga.itb. This FIT image can be created through running + this command: tools/mkimage + -E -p 400 + -f board/altera/arria10-socdk/fit_spl_fpga.its + fit_spl_fpga.itb + + For details of describing structure and contents of the FIT image, + please refer board/altera/arria10-socdk/fit_spl_fpga.its + +- Examples for booting with full release or booting with early IO release, then + follow by entering early user mode: fpga_mgr: fpga-mgr@ffd03000 { compatible = "altr,socfpga-a10-fpga-mgr"; @@ -16,4 +39,5 @@ Example: 0xffcfe400 0x20>; clocks = <&l4_mp_clk>; resets = <&rst FPGAMGR_RESET>; + altr,bitstream = "fit_spl_fpga.itb"; };