From patchwork Mon Feb 18 19:47:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 1044290 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 443Dt944zXz9s3x; Tue, 19 Feb 2019 06:47:44 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1gvotA-0007Ls-QC; Mon, 18 Feb 2019 19:47:40 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1gvot9-0007Ll-07 for fwts-devel@lists.ubuntu.com; Mon, 18 Feb 2019 19:47:39 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1gvot8-0005BO-K6; Mon, 18 Feb 2019 19:47:38 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] Makefiles: workaround address-of-packed-member warnings with gcc-9 Date: Mon, 18 Feb 2019 19:47:38 +0000 Message-Id: <20190218194738.5201-1-colin.king@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From: Colin Ian King Currently fwts uses a lot of packed structures and taking the address of members of a packed struct is throwing up a lot of warnings with gcc-9. For the moment, let's disable this with -Wno-address-of-packed-member and fix this up for the next release in March. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/Makefile.am | 15 ++++++++------- src/acpica/Makefile.am | 3 ++- src/lib/src/Makefile.am | 3 ++- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 8339f306..62c9ba8f 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -7,14 +7,15 @@ SUBDIRS = acpica/source/compiler lib acpica AM_CPPFLAGS = \ - -I$(top_srcdir)/src/lib/include \ - -I$(top_srcdir)/src/acpica/source/include \ - -I$(top_srcdir)/src/acpica/source/compiler \ - -I$(top_srcdir)/efi_runtime \ - `pkg-config --silence-errors --cflags json` \ - `pkg-config --silence-errors --cflags json-c` \ + -I$(top_srcdir)/src/lib/include \ + -I$(top_srcdir)/src/acpica/source/include \ + -I$(top_srcdir)/src/acpica/source/compiler \ + -I$(top_srcdir)/efi_runtime \ + `pkg-config --silence-errors --cflags json` \ + `pkg-config --silence-errors --cflags json-c` \ -pthread `pkg-config --cflags glib-2.0 gio-2.0` \ - -Wall -Werror -Wextra + -Wall -Werror -Wextra \ + -Wno-address-of-packed-member bin_PROGRAMS = fwts diff --git a/src/acpica/Makefile.am b/src/acpica/Makefile.am index 0753388f..03dd9820 100644 --- a/src/acpica/Makefile.am +++ b/src/acpica/Makefile.am @@ -29,7 +29,8 @@ AM_CPPFLAGS = \ -I$(srcdir)/source/tools/acpiexec \ `pkg-config --silence-errors --cflags json` \ `pkg-config --silence-errors --cflags json-c` \ - -Wall -fno-strict-aliasing + -Wall -fno-strict-aliasing \ + -Wno-address-of-packed-member # # We rename some of the functions so we can override them in fwts. This diff --git a/src/lib/src/Makefile.am b/src/lib/src/Makefile.am index 095a4fd9..6bcf9f86 100644 --- a/src/lib/src/Makefile.am +++ b/src/lib/src/Makefile.am @@ -24,7 +24,8 @@ AM_CPPFLAGS = \ `pkg-config --silence-errors --cflags json-c` \ `pkg-config --cflags glib-2.0 gio-2.0` \ -DDATAROOTDIR=\"$(datarootdir)\" \ - -Wall -Werror -Wextra + -Wall -Werror -Wextra \ + -Wno-address-of-packed-member pkglib_LTLIBRARIES = libfwts.la