diff mbox series

package/kexec: enable powerpc64 platform

Message ID 20190218121508.htf6s7bazcggmozg@gmail.com
State Accepted
Headers show
Series package/kexec: enable powerpc64 platform | expand

Commit Message

Artem Senichev Feb. 18, 2019, 12:15 p.m. UTC
kexec has fully support of ppc64 platform:
https://www.kernel.org/doc/Documentation/kdump/kdump.txt
Added BR2_powerpc64 platform support.

Signed-off-by: Artem Senichev <artemsen@gmail.com>
---
 package/kexec/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Matt Weber Feb. 18, 2019, 1:57 p.m. UTC | #1
Artem,


On Mon, Feb 18, 2019 at 6:17 AM Artem Senichev <artemsen@gmail.com> wrote:
>
> kexec has fully support of ppc64 platform:
> https://www.kernel.org/doc/Documentation/kdump/kdump.txt
> Added BR2_powerpc64 platform support.

Curious, which power arch/sub-arch are you testing?  (Power 5/6/7/8?)
(NXP or IBM)

>
> Signed-off-by: Artem Senichev <artemsen@gmail.com>

Looks like when the arch were last adjusted for support, powerpc64 was
just left off the list but mentioned as a supported. (Commit:
3116742e8f0c45e5ca06b32f91e481763356e03e)

Reviewed-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Artem Senichev Feb. 19, 2019, 8:10 a.m. UTC | #2
On Mon, Feb 18, 2019 at 07:57:20AM -0600, Matthew Weber wrote:
> On Mon, Feb 18, 2019 at 6:17 AM Artem Senichev <artemsen@gmail.com> wrote:
> >
> > kexec has fully support of ppc64 platform:
> > https://www.kernel.org/doc/Documentation/kdump/kdump.txt
> > Added BR2_powerpc64 platform support.
> 
> Curious, which power arch/sub-arch are you testing?  (Power 5/6/7/8?)
> (NXP or IBM)

I have checked kexec on POWER8, Little- and Big-Endian (VESNIN
server).
Linux kernel 5.0-rc6, kexec-tools 2.0.17 (from Buildroot).

Artem
Matthew Weber Feb. 19, 2019, 1:55 p.m. UTC | #3
Artem,

On Tue, Feb 19, 2019 at 2:12 AM Artem Senichev <artemsen@gmail.com> wrote:
>
> On Mon, Feb 18, 2019 at 07:57:20AM -0600, Matthew Weber wrote:
> > On Mon, Feb 18, 2019 at 6:17 AM Artem Senichev <artemsen@gmail.com> wrote:
> > >
> > > kexec has fully support of ppc64 platform:
> > > https://www.kernel.org/doc/Documentation/kdump/kdump.txt
> > > Added BR2_powerpc64 platform support.
> >
> > Curious, which power arch/sub-arch are you testing?  (Power 5/6/7/8?)
> > (NXP or IBM)
>
> I have checked kexec on POWER8, Little- and Big-Endian (VESNIN
> server).
> Linux kernel 5.0-rc6, kexec-tools 2.0.17 (from Buildroot).

Good to know.  Unsure if it warrants mentioning that in the commit
message as someone would find this email thread if there was ever an
issue.

Matt
Peter Korsgaard March 25, 2019, 8:18 p.m. UTC | #4
>>>>> "Artem" == Artem Senichev <artemsen@gmail.com> writes:

 > kexec has fully support of ppc64 platform:
 > https://www.kernel.org/doc/Documentation/kdump/kdump.txt
 > Added BR2_powerpc64 platform support.

 > Signed-off-by: Artem Senichev <artemsen@gmail.com>

Committed to 2019.02.x, thanks.
Thomas Petazzoni March 27, 2019, 8:07 a.m. UTC | #5
On Mon, 18 Feb 2019 15:15:08 +0300
Artem Senichev <artemsen@gmail.com> wrote:

> kexec has fully support of ppc64 platform:
> https://www.kernel.org/doc/Documentation/kdump/kdump.txt
> Added BR2_powerpc64 platform support.
> 
> Signed-off-by: Artem Senichev <artemsen@gmail.com>
> ---
>  package/kexec/Config.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas
Thomas Petazzoni March 27, 2019, 8:08 a.m. UTC | #6
On Mon, 25 Mar 2019 21:18:46 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

> >>>>> "Artem" == Artem Senichev <artemsen@gmail.com> writes:  
> 
>  > kexec has fully support of ppc64 platform:
>  > https://www.kernel.org/doc/Documentation/kdump/kdump.txt
>  > Added BR2_powerpc64 platform support.  
> 
>  > Signed-off-by: Artem Senichev <artemsen@gmail.com>  
> 
> Committed to 2019.02.x, thanks.

No, you didn't apply this one to 2019.02.x, but the "package/kexec:
enable powerpc64le platforms" one. Notice the subtle difference ? :-)

Thomas
Peter Korsgaard March 27, 2019, 8:48 a.m. UTC | #7
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Mon, 25 Mar 2019 21:18:46 +0100
 > Peter Korsgaard <peter@korsgaard.com> wrote:

 >> >>>>> "Artem" == Artem Senichev <artemsen@gmail.com> writes:  
 >> 
 >> > kexec has fully support of ppc64 platform:
 >> > https://www.kernel.org/doc/Documentation/kdump/kdump.txt
 >> > Added BR2_powerpc64 platform support.  
 >> 
 >> > Signed-off-by: Artem Senichev <artemsen@gmail.com>  
 >> 
 >> Committed to 2019.02.x, thanks.

 > No, you didn't apply this one to 2019.02.x, but the "package/kexec:
 > enable powerpc64le platforms" one. Notice the subtle difference ? :-)

Sorry, -ETOOMANYPATCHES ;)
Peter Korsgaard March 28, 2019, 10:13 a.m. UTC | #8
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

>>>>> "Artem" == Artem Senichev <artemsen@gmail.com> writes:
 >> kexec has fully support of ppc64 platform:
 >> https://www.kernel.org/doc/Documentation/kdump/kdump.txt
 >> Added BR2_powerpc64 platform support.

 >> Signed-off-by: Artem Senichev <artemsen@gmail.com>

 > Committed to 2019.02.x, thanks.

And now for real.
diff mbox series

Patch

diff --git a/package/kexec/Config.in b/package/kexec/Config.in
index c4a09be109..410e503d9e 100644
--- a/package/kexec/Config.in
+++ b/package/kexec/Config.in
@@ -2,7 +2,8 @@  config BR2_PACKAGE_KEXEC
 	bool "kexec"
 	depends on BR2_i386 || BR2_x86_64 || BR2_arm || BR2_armeb || \
 		BR2_mips || BR2_mips64 || BR2_mipsel || BR2_mips64el || \
-		BR2_powerpc || BR2_powerpc64le || BR2_sh4 || BR2_sh4a || BR2_aarch64
+		BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
+		BR2_sh4 || BR2_sh4a || BR2_aarch64
 	help
 	  Kexec is a user space utility for loading another kernel
 	  and asking the currently running kernel to do something with