| Message ID | 20190218091425.11067-1-liuhangbin@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net: vrf: remove MTU limits for vrf device | expand |
On Mon, Feb 18, 2019 at 05:14:25PM +0800, Hangbin Liu wrote:
> Similiar to commit e94cd8113ce63 ("net: remove MTU limits for dummy and
Similar...
Thanks Davide help point it out.
Regards
Hangbin
On 2/18/19 2:14 AM, Hangbin Liu wrote: > Similiar to commit e94cd8113ce63 ("net: remove MTU limits for dummy and > ifb device"), MTU is irrelevant for VRF device. We init it as 64K while > limit it to [68, 1500] may make users feel confused. > > Reported-by: Jianlin Shi <jishi@redhat.com> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > --- > drivers/net/vrf.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c > index 95909e262ba4..7c1430ed0244 100644 > --- a/drivers/net/vrf.c > +++ b/drivers/net/vrf.c > @@ -1273,6 +1273,9 @@ static void vrf_setup(struct net_device *dev) > > /* default to no qdisc; user can add if desired */ > dev->priv_flags |= IFF_NO_QUEUE; > + > + dev->min_mtu = 0; > + dev->max_mtu = 0; > } > > static int vrf_validate(struct nlattr *tb[], struct nlattr *data[], > Reviewed-by: David Ahern <dsahern@gmail.com>
From: Hangbin Liu <liuhangbin@gmail.com> Date: Mon, 18 Feb 2019 17:14:25 +0800 > Similiar to commit e94cd8113ce63 ("net: remove MTU limits for dummy and > ifb device"), MTU is irrelevant for VRF device. We init it as 64K while > limit it to [68, 1500] may make users feel confused. > > Reported-by: Jianlin Shi <jishi@redhat.com> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> Applied.
diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 95909e262ba4..7c1430ed0244 100644 --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -1273,6 +1273,9 @@ static void vrf_setup(struct net_device *dev) /* default to no qdisc; user can add if desired */ dev->priv_flags |= IFF_NO_QUEUE; + + dev->min_mtu = 0; + dev->max_mtu = 0; } static int vrf_validate(struct nlattr *tb[], struct nlattr *data[],
Similiar to commit e94cd8113ce63 ("net: remove MTU limits for dummy and ifb device"), MTU is irrelevant for VRF device. We init it as 64K while limit it to [68, 1500] may make users feel confused. Reported-by: Jianlin Shi <jishi@redhat.com> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> --- drivers/net/vrf.c | 3 +++ 1 file changed, 3 insertions(+)