diff mbox series

[1/1] Add libvirt (KVM) support

Message ID 20190215173607.13773-1-christopher@lecroq.be
State Changes Requested
Headers show
Series [1/1] Add libvirt (KVM) support | expand

Commit Message

Christopher Peeters Feb. 15, 2019, 5:36 p.m. UTC
Signed-off-by: Christopher Peeters <christopher@lecroq.be>
---
 support/misc/Vagrantfile | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Thomas Petazzoni April 13, 2019, 8:21 p.m. UTC | #1
Hello Christopher,

Sorry for the very long delay in replying. I am not an expert with the
Vagrant stuff, so I'm adding Angelo in Cc who hopefully will be able to
comment further. Still, I have a few comments.

First, the commit title should be:

	support/misc/Vagrantfile: add libvirt/kvm support

On Fri, 15 Feb 2019 18:36:07 +0100
Christopher Peeters <christopher@lecroq.be> wrote:

> Signed-off-by: Christopher Peeters <christopher@lecroq.be>
> ---
>  support/misc/Vagrantfile | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/support/misc/Vagrantfile b/support/misc/Vagrantfile
> index 1ca5edc647..48f01a5807 100644
> --- a/support/misc/Vagrantfile
> +++ b/support/misc/Vagrantfile
> @@ -29,6 +29,12 @@ Vagrant.configure('2') do |config|
>  		end
>  	end
>  
> +  config.vm.provider :libvirt do |v, override|
> +    override.vm.box = 'generic/ubuntu1804'

Why are you overriding the distribution being used? It seems odd that
depending on the virtualization technology, a different distribution
gets installed inside the VM.

> +    v.memory = VM_MEMORY
> +    v.cpus = VM_CORES
> +  end 

The indentation is also bogus: the file uses tabs, and you used two
spaces. Could you fix that up ?

Thanks,

Thomas
Christopher Peeters April 15, 2019, 7:46 a.m. UTC | #2
Hi Thomas,

Thank you for your email. I wasn't aware about the commit title
conventions so I will fix this.

The reason why I selected a different distribution is the lack of
support for Libvirt by the original distribution. When you do `vagrant
up` with the original Vagrantfile and KVM/Libvirt as default vagrant
provider, vagrant will quit with the error that the current box can't be
found / isn't supported. Please check the snippet below for more
information. The "generic/ubuntu1804" is also a Ubuntu Bionic machine
which is well-supported so I selected this one to be able to use
Buildroot on Vagrant on Libvirt.

```

$ vagrant up
==> vagrant: A new version of Vagrant is available: 2.2.4!
==> vagrant: To upgrade visit: https://www.vagrantup.com/downloads.html

Bringing machine 'default' up with 'libvirt' provider...
==> default: Box 'ubuntu/bionic64' could not be found. Attempting to
find and install...
    default: Box Provider: libvirt
    default: Box Version: >= 0
==> default: Loading metadata for box 'ubuntu/bionic64'
    default: URL: https://vagrantcloud.com/ubuntu/bionic64
The box you're attempting to add doesn't support the provider
you requested. Please find an alternate box or use an alternate
provider. Double-check your requested provider to verify you didn't
simply misspell it.

If you're adding a box from HashiCorp's Vagrant Cloud, make sure the box is
released.

Name: ubuntu/bionic64
Address: https://vagrantcloud.com/ubuntu/bionic64
Requested provider: [:libvirt]

```

You can also search for boxes on the Vagrant website. They also show
which providers are supported:

https://app.vagrantup.com/ubuntu/boxes/bionic64

https://app.vagrantup.com/generic/boxes/ubuntu1804

I will also contact Ubuntu to ask them if they're willing to support
Libvirt, but in the mean time I suggest to choose a different box for
Buildroot on Vagrant using the Libvirt provider.

I will also fix the indentation as requested. This is probably due to my
vim settings.

Best regards,

Christopher

On 13/04/2019 22:21, Thomas Petazzoni wrote:
> Hello Christopher,
>
> Sorry for the very long delay in replying. I am not an expert with the
> Vagrant stuff, so I'm adding Angelo in Cc who hopefully will be able to
> comment further. Still, I have a few comments.
>
> First, the commit title should be:
>
> 	support/misc/Vagrantfile: add libvirt/kvm support
>
> On Fri, 15 Feb 2019 18:36:07 +0100
> Christopher Peeters <christopher@lecroq.be> wrote:
>
>> Signed-off-by: Christopher Peeters <christopher@lecroq.be>
>> ---
>>  support/misc/Vagrantfile | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/support/misc/Vagrantfile b/support/misc/Vagrantfile
>> index 1ca5edc647..48f01a5807 100644
>> --- a/support/misc/Vagrantfile
>> +++ b/support/misc/Vagrantfile
>> @@ -29,6 +29,12 @@ Vagrant.configure('2') do |config|
>>  		end
>>  	end
>>  
>> +  config.vm.provider :libvirt do |v, override|
>> +    override.vm.box = 'generic/ubuntu1804'
> Why are you overriding the distribution being used? It seems odd that
> depending on the virtualization technology, a different distribution
> gets installed inside the VM.
>
>> +    v.memory = VM_MEMORY
>> +    v.cpus = VM_CORES
>> +  end 
> The indentation is also bogus: the file uses tabs, and you used two
> spaces. Could you fix that up ?
>
> Thanks,
>
> Thomas
Arnout Vandecappelle April 15, 2019, 12:23 p.m. UTC | #3
Hi Christopher,

 Plese don't top-post, but reply inline like I do below.

On 15/04/2019 09:46, Christopher Peeters wrote:
> Hi Thomas,
> 
> Thank you for your email. I wasn't aware about the commit title
> conventions so I will fix this.
> 
> The reason why I selected a different distribution is the lack of
> support for Libvirt by the original distribution.

 I would prefer in that case that we always use this other distribution (which
is actually the same distribution, right? bionic == ubuntu1804...).

> When you do `vagrant
> up` with the original Vagrantfile and KVM/Libvirt as default vagrant
> provider, vagrant will quit with the error that the current box can't be
> found / isn't supported. Please check the snippet below for more
> information. The "generic/ubuntu1804" is also a Ubuntu Bionic machine
> which is well-supported so I selected this one to be able to use
> Buildroot on Vagrant on Libvirt.
> 
> ```
> 
> $ vagrant up
> ==> vagrant: A new version of Vagrant is available: 2.2.4!
> ==> vagrant: To upgrade visit: https://www.vagrantup.com/downloads.html
> 
> Bringing machine 'default' up with 'libvirt' provider...
> ==> default: Box 'ubuntu/bionic64' could not be found. Attempting to
> find and install...
>     default: Box Provider: libvirt
>     default: Box Version: >= 0
> ==> default: Loading metadata for box 'ubuntu/bionic64'
>     default: URL: https://vagrantcloud.com/ubuntu/bionic64
> The box you're attempting to add doesn't support the provider
> you requested. Please find an alternate box or use an alternate
> provider. Double-check your requested provider to verify you didn't
> simply misspell it.
> 
> If you're adding a box from HashiCorp's Vagrant Cloud, make sure the box is
> released.
> 
> Name: ubuntu/bionic64
> Address: https://vagrantcloud.com/ubuntu/bionic64
> Requested provider: [:libvirt]
> 
> ```
> 
> You can also search for boxes on the Vagrant website. They also show
> which providers are supported:
> 
> https://app.vagrantup.com/ubuntu/boxes/bionic64
> 
> https://app.vagrantup.com/generic/boxes/ubuntu1804
> 
> I will also contact Ubuntu to ask them if they're willing to support
> Libvirt, but in the mean time I suggest to choose a different box for
> Buildroot on Vagrant using the Libvirt provider.
> 
> I will also fix the indentation as requested. This is probably due to my
> vim settings.
> 
> Best regards,
> 
> Christopher
> 
> On 13/04/2019 22:21, Thomas Petazzoni wrote:
>> Hello Christopher,
>>
>> Sorry for the very long delay in replying. I am not an expert with the
>> Vagrant stuff, so I'm adding Angelo in Cc who hopefully will be able to
>> comment further. Still, I have a few comments.
>>
>> First, the commit title should be:
>>
>> 	support/misc/Vagrantfile: add libvirt/kvm support
>>
>> On Fri, 15 Feb 2019 18:36:07 +0100
>> Christopher Peeters <christopher@lecroq.be> wrote:
>>
>>> Signed-off-by: Christopher Peeters <christopher@lecroq.be>
>>> ---
>>>  support/misc/Vagrantfile | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/support/misc/Vagrantfile b/support/misc/Vagrantfile
>>> index 1ca5edc647..48f01a5807 100644
>>> --- a/support/misc/Vagrantfile
>>> +++ b/support/misc/Vagrantfile
>>> @@ -29,6 +29,12 @@ Vagrant.configure('2') do |config|
>>>  		end
>>>  	end
>>>  
>>> +  config.vm.provider :libvirt do |v, override|
>>> +    override.vm.box = 'generic/ubuntu1804'
>> Why are you overriding the distribution being used? It seems odd that
>> depending on the virtualization technology, a different distribution
>> gets installed inside the VM.
>>
>>> +    v.memory = VM_MEMORY
>>> +    v.cpus = VM_CORES
>>> +  end 
>> The indentation is also bogus: the file uses tabs, and you used two
>> spaces. Could you fix that up ?
>>
>> Thanks,
>>
>> Thomas
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
Angelo Compagnucci April 15, 2019, 2:06 p.m. UTC | #4
On Mon, Apr 15, 2019 at 2:23 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>
>  Hi Christopher,
>
>  Plese don't top-post, but reply inline like I do below.
>
> On 15/04/2019 09:46, Christopher Peeters wrote:
> > Hi Thomas,
> >
> > Thank you for your email. I wasn't aware about the commit title
> > conventions so I will fix this.
> >
> > The reason why I selected a different distribution is the lack of
> > support for Libvirt by the original distribution.
>
>  I would prefer in that case that we always use this other distribution (which
> is actually the same distribution, right? bionic == ubuntu1804...).

I wouldn't like to use this distribution if possible, is not the
official one and not maintained by canonical. The official one is:

https://app.vagrantup.com/ubuntu/boxes/bionic64

So I think the best approach is to install the required software in
conditional provisioning section that runs only if the vm is running
on top of libvirt.

>
> > When you do `vagrant
> > up` with the original Vagrantfile and KVM/Libvirt as default vagrant
> > provider, vagrant will quit with the error that the current box can't be
> > found / isn't supported. Please check the snippet below for more
> > information. The "generic/ubuntu1804" is also a Ubuntu Bionic machine
> > which is well-supported so I selected this one to be able to use
> > Buildroot on Vagrant on Libvirt.
> >
> > ```
> >
> > $ vagrant up
> > ==> vagrant: A new version of Vagrant is available: 2.2.4!
> > ==> vagrant: To upgrade visit: https://www.vagrantup.com/downloads.html
> >
> > Bringing machine 'default' up with 'libvirt' provider...
> > ==> default: Box 'ubuntu/bionic64' could not be found. Attempting to
> > find and install...
> >     default: Box Provider: libvirt
> >     default: Box Version: >= 0
> > ==> default: Loading metadata for box 'ubuntu/bionic64'
> >     default: URL: https://vagrantcloud.com/ubuntu/bionic64
> > The box you're attempting to add doesn't support the provider
> > you requested. Please find an alternate box or use an alternate
> > provider. Double-check your requested provider to verify you didn't
> > simply misspell it.
> >
> > If you're adding a box from HashiCorp's Vagrant Cloud, make sure the box is
> > released.
> >
> > Name: ubuntu/bionic64
> > Address: https://vagrantcloud.com/ubuntu/bionic64
> > Requested provider: [:libvirt]
> >
> > ```
> >
> > You can also search for boxes on the Vagrant website. They also show
> > which providers are supported:
> >
> > https://app.vagrantup.com/ubuntu/boxes/bionic64
> >
> > https://app.vagrantup.com/generic/boxes/ubuntu1804
> >
> > I will also contact Ubuntu to ask them if they're willing to support
> > Libvirt, but in the mean time I suggest to choose a different box for
> > Buildroot on Vagrant using the Libvirt provider.
> >
> > I will also fix the indentation as requested. This is probably due to my
> > vim settings.
> >
> > Best regards,
> >
> > Christopher
> >
> > On 13/04/2019 22:21, Thomas Petazzoni wrote:
> >> Hello Christopher,
> >>
> >> Sorry for the very long delay in replying. I am not an expert with the
> >> Vagrant stuff, so I'm adding Angelo in Cc who hopefully will be able to
> >> comment further. Still, I have a few comments.
> >>
> >> First, the commit title should be:
> >>
> >>      support/misc/Vagrantfile: add libvirt/kvm support
> >>
> >> On Fri, 15 Feb 2019 18:36:07 +0100
> >> Christopher Peeters <christopher@lecroq.be> wrote:
> >>
> >>> Signed-off-by: Christopher Peeters <christopher@lecroq.be>
> >>> ---
> >>>  support/misc/Vagrantfile | 6 ++++++
> >>>  1 file changed, 6 insertions(+)
> >>>
> >>> diff --git a/support/misc/Vagrantfile b/support/misc/Vagrantfile
> >>> index 1ca5edc647..48f01a5807 100644
> >>> --- a/support/misc/Vagrantfile
> >>> +++ b/support/misc/Vagrantfile
> >>> @@ -29,6 +29,12 @@ Vagrant.configure('2') do |config|
> >>>             end
> >>>     end
> >>>
> >>> +  config.vm.provider :libvirt do |v, override|
> >>> +    override.vm.box = 'generic/ubuntu1804'
> >> Why are you overriding the distribution being used? It seems odd that
> >> depending on the virtualization technology, a different distribution
> >> gets installed inside the VM.
> >>
> >>> +    v.memory = VM_MEMORY
> >>> +    v.cpus = VM_CORES
> >>> +  end
> >> The indentation is also bogus: the file uses tabs, and you used two
> >> spaces. Could you fix that up ?
> >>
> >> Thanks,
> >>
> >> Thomas
> >>
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot@busybox.net
> >> http://lists.busybox.net/mailman/listinfo/buildroot
Christopher Peeters April 15, 2019, 2:54 p.m. UTC | #5
On 15/04/2019 16:06, Angelo Compagnucci wrote:
> On Mon, Apr 15, 2019 at 2:23 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>>  Hi Christopher,
>>
>>  Plese don't top-post, but reply inline like I do below.
>>
>> On 15/04/2019 09:46, Christopher Peeters wrote:
>>> Hi Thomas,
>>>
>>> Thank you for your email. I wasn't aware about the commit title
>>> conventions so I will fix this.
>>>
>>> The reason why I selected a different distribution is the lack of
>>> support for Libvirt by the original distribution.
>>  I would prefer in that case that we always use this other distribution (which
>> is actually the same distribution, right? bionic == ubuntu1804...).
> I wouldn't like to use this distribution if possible, is not the
> official one and not maintained by canonical. The official one is:
>
> https://app.vagrantup.com/ubuntu/boxes/bionic64

As I said before there's no support from Canonical for libvirt images.
This can only be solved by Canonical. And if I look at Launchpad, it
won't happen very soon. There's another question for LXC support open
for more then a year now.

An other option when preferring official images is to switch over to one
of the following boxes since they do understand that source projects
should support each other and therefore have support for libvirt in
their Vagrant boxes. I haven't tested them though.

- https://app.vagrantup.com/debian/boxes/stretch64

- https://app.vagrantup.com/centos/boxes/7

- https://app.vagrantup.com/fedora/boxes/29-atomic-host

- https://app.vagrantup.com/opensuse/boxes/openSUSE-15.0-x86_64

- https://app.vagrantup.com/archlinux/boxes/archlinux

>
> So I think the best approach is to install the required software in
> conditional provisioning section that runs only if the vm is running
> on top of libvirt.
I'm not quite sure whether you understand the implications of "doesn't
support libvirt". Unless I interpret your email incorrectly, I get the
impression that you believe that the vm will run until a certain point.
This is not the case. The vm won't even start because vagrant says that
libvirt isn't supported. Please check the snippet in my email from 09h46.
>>> When you do `vagrant
>>> up` with the original Vagrantfile and KVM/Libvirt as default vagrant
>>> provider, vagrant will quit with the error that the current box can't be
>>> found / isn't supported. Please check the snippet below for more
>>> information. The "generic/ubuntu1804" is also a Ubuntu Bionic machine
>>> which is well-supported so I selected this one to be able to use
>>> Buildroot on Vagrant on Libvirt.
>>>
>>> ```
>>>
>>> $ vagrant up
>>> ==> vagrant: A new version of Vagrant is available: 2.2.4!
>>> ==> vagrant: To upgrade visit: https://www.vagrantup.com/downloads.html
>>>
>>> Bringing machine 'default' up with 'libvirt' provider...
>>> ==> default: Box 'ubuntu/bionic64' could not be found. Attempting to
>>> find and install...
>>>     default: Box Provider: libvirt
>>>     default: Box Version: >= 0
>>> ==> default: Loading metadata for box 'ubuntu/bionic64'
>>>     default: URL: https://vagrantcloud.com/ubuntu/bionic64
>>> The box you're attempting to add doesn't support the provider
>>> you requested. Please find an alternate box or use an alternate
>>> provider. Double-check your requested provider to verify you didn't
>>> simply misspell it.
>>>
>>> If you're adding a box from HashiCorp's Vagrant Cloud, make sure the box is
>>> released.
>>>
>>> Name: ubuntu/bionic64
>>> Address: https://vagrantcloud.com/ubuntu/bionic64
>>> Requested provider: [:libvirt]
>>>
>>> ```
>>>
>>> You can also search for boxes on the Vagrant website. They also show
>>> which providers are supported:
>>>
>>> https://app.vagrantup.com/ubuntu/boxes/bionic64
>>>
>>> https://app.vagrantup.com/generic/boxes/ubuntu1804
>>>
>>> I will also contact Ubuntu to ask them if they're willing to support
>>> Libvirt, but in the mean time I suggest to choose a different box for
>>> Buildroot on Vagrant using the Libvirt provider.
>>>
>>> I will also fix the indentation as requested. This is probably due to my
>>> vim settings.
>>>
>>> Best regards,
>>>
>>> Christopher
>>>
>>> On 13/04/2019 22:21, Thomas Petazzoni wrote:
>>>> Hello Christopher,
>>>>
>>>> Sorry for the very long delay in replying. I am not an expert with the
>>>> Vagrant stuff, so I'm adding Angelo in Cc who hopefully will be able to
>>>> comment further. Still, I have a few comments.
>>>>
>>>> First, the commit title should be:
>>>>
>>>>      support/misc/Vagrantfile: add libvirt/kvm support
>>>>
>>>> On Fri, 15 Feb 2019 18:36:07 +0100
>>>> Christopher Peeters <christopher@lecroq.be> wrote:
>>>>
>>>>> Signed-off-by: Christopher Peeters <christopher@lecroq.be>
>>>>> ---
>>>>>  support/misc/Vagrantfile | 6 ++++++
>>>>>  1 file changed, 6 insertions(+)
>>>>>
>>>>> diff --git a/support/misc/Vagrantfile b/support/misc/Vagrantfile
>>>>> index 1ca5edc647..48f01a5807 100644
>>>>> --- a/support/misc/Vagrantfile
>>>>> +++ b/support/misc/Vagrantfile
>>>>> @@ -29,6 +29,12 @@ Vagrant.configure('2') do |config|
>>>>>             end
>>>>>     end
>>>>>
>>>>> +  config.vm.provider :libvirt do |v, override|
>>>>> +    override.vm.box = 'generic/ubuntu1804'
>>>> Why are you overriding the distribution being used? It seems odd that
>>>> depending on the virtualization technology, a different distribution
>>>> gets installed inside the VM.
>>>>
>>>>> +    v.memory = VM_MEMORY
>>>>> +    v.cpus = VM_CORES
>>>>> +  end
>>>> The indentation is also bogus: the file uses tabs, and you used two
>>>> spaces. Could you fix that up ?
>>>>
>>>> Thanks,
>>>>
>>>> Thomas
>>>>
>>>> _______________________________________________
>>>> buildroot mailing list
>>>> buildroot@busybox.net
>>>> http://lists.busybox.net/mailman/listinfo/buildroot
Christopher Peeters May 13, 2019, 11:34 a.m. UTC | #6
Hi,

Any updates on this?

Best regards,

Christopher

On 15/04/2019 16:54, Christopher Peeters wrote:
> On 15/04/2019 16:06, Angelo Compagnucci wrote:
>> On Mon, Apr 15, 2019 at 2:23 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>>>  Hi Christopher,
>>>
>>>  Plese don't top-post, but reply inline like I do below.
>>>
>>> On 15/04/2019 09:46, Christopher Peeters wrote:
>>>> Hi Thomas,
>>>>
>>>> Thank you for your email. I wasn't aware about the commit title
>>>> conventions so I will fix this.
>>>>
>>>> The reason why I selected a different distribution is the lack of
>>>> support for Libvirt by the original distribution.
>>>  I would prefer in that case that we always use this other distribution (which
>>> is actually the same distribution, right? bionic == ubuntu1804...).
>> I wouldn't like to use this distribution if possible, is not the
>> official one and not maintained by canonical. The official one is:
>>
>> https://app.vagrantup.com/ubuntu/boxes/bionic64
> As I said before there's no support from Canonical for libvirt images.
> This can only be solved by Canonical. And if I look at Launchpad, it
> won't happen very soon. There's another question for LXC support open
> for more then a year now.
>
> An other option when preferring official images is to switch over to one
> of the following boxes since they do understand that source projects
> should support each other and therefore have support for libvirt in
> their Vagrant boxes. I haven't tested them though.
>
> - https://app.vagrantup.com/debian/boxes/stretch64
>
> - https://app.vagrantup.com/centos/boxes/7
>
> - https://app.vagrantup.com/fedora/boxes/29-atomic-host
>
> - https://app.vagrantup.com/opensuse/boxes/openSUSE-15.0-x86_64
>
> - https://app.vagrantup.com/archlinux/boxes/archlinux
>
>> So I think the best approach is to install the required software in
>> conditional provisioning section that runs only if the vm is running
>> on top of libvirt.
> I'm not quite sure whether you understand the implications of "doesn't
> support libvirt". Unless I interpret your email incorrectly, I get the
> impression that you believe that the vm will run until a certain point.
> This is not the case. The vm won't even start because vagrant says that
> libvirt isn't supported. Please check the snippet in my email from 09h46.
>>>> When you do `vagrant
>>>> up` with the original Vagrantfile and KVM/Libvirt as default vagrant
>>>> provider, vagrant will quit with the error that the current box can't be
>>>> found / isn't supported. Please check the snippet below for more
>>>> information. The "generic/ubuntu1804" is also a Ubuntu Bionic machine
>>>> which is well-supported so I selected this one to be able to use
>>>> Buildroot on Vagrant on Libvirt.
>>>>
>>>> ```
>>>>
>>>> $ vagrant up
>>>> ==> vagrant: A new version of Vagrant is available: 2.2.4!
>>>> ==> vagrant: To upgrade visit: https://www.vagrantup.com/downloads.html
>>>>
>>>> Bringing machine 'default' up with 'libvirt' provider...
>>>> ==> default: Box 'ubuntu/bionic64' could not be found. Attempting to
>>>> find and install...
>>>>     default: Box Provider: libvirt
>>>>     default: Box Version: >= 0
>>>> ==> default: Loading metadata for box 'ubuntu/bionic64'
>>>>     default: URL: https://vagrantcloud.com/ubuntu/bionic64
>>>> The box you're attempting to add doesn't support the provider
>>>> you requested. Please find an alternate box or use an alternate
>>>> provider. Double-check your requested provider to verify you didn't
>>>> simply misspell it.
>>>>
>>>> If you're adding a box from HashiCorp's Vagrant Cloud, make sure the box is
>>>> released.
>>>>
>>>> Name: ubuntu/bionic64
>>>> Address: https://vagrantcloud.com/ubuntu/bionic64
>>>> Requested provider: [:libvirt]
>>>>
>>>> ```
>>>>
>>>> You can also search for boxes on the Vagrant website. They also show
>>>> which providers are supported:
>>>>
>>>> https://app.vagrantup.com/ubuntu/boxes/bionic64
>>>>
>>>> https://app.vagrantup.com/generic/boxes/ubuntu1804
>>>>
>>>> I will also contact Ubuntu to ask them if they're willing to support
>>>> Libvirt, but in the mean time I suggest to choose a different box for
>>>> Buildroot on Vagrant using the Libvirt provider.
>>>>
>>>> I will also fix the indentation as requested. This is probably due to my
>>>> vim settings.
>>>>
>>>> Best regards,
>>>>
>>>> Christopher
>>>>
>>>> On 13/04/2019 22:21, Thomas Petazzoni wrote:
>>>>> Hello Christopher,
>>>>>
>>>>> Sorry for the very long delay in replying. I am not an expert with the
>>>>> Vagrant stuff, so I'm adding Angelo in Cc who hopefully will be able to
>>>>> comment further. Still, I have a few comments.
>>>>>
>>>>> First, the commit title should be:
>>>>>
>>>>>      support/misc/Vagrantfile: add libvirt/kvm support
>>>>>
>>>>> On Fri, 15 Feb 2019 18:36:07 +0100
>>>>> Christopher Peeters <christopher@lecroq.be> wrote:
>>>>>
>>>>>> Signed-off-by: Christopher Peeters <christopher@lecroq.be>
>>>>>> ---
>>>>>>  support/misc/Vagrantfile | 6 ++++++
>>>>>>  1 file changed, 6 insertions(+)
>>>>>>
>>>>>> diff --git a/support/misc/Vagrantfile b/support/misc/Vagrantfile
>>>>>> index 1ca5edc647..48f01a5807 100644
>>>>>> --- a/support/misc/Vagrantfile
>>>>>> +++ b/support/misc/Vagrantfile
>>>>>> @@ -29,6 +29,12 @@ Vagrant.configure('2') do |config|
>>>>>>             end
>>>>>>     end
>>>>>>
>>>>>> +  config.vm.provider :libvirt do |v, override|
>>>>>> +    override.vm.box = 'generic/ubuntu1804'
>>>>> Why are you overriding the distribution being used? It seems odd that
>>>>> depending on the virtualization technology, a different distribution
>>>>> gets installed inside the VM.
>>>>>
>>>>>> +    v.memory = VM_MEMORY
>>>>>> +    v.cpus = VM_CORES
>>>>>> +  end
>>>>> The indentation is also bogus: the file uses tabs, and you used two
>>>>> spaces. Could you fix that up ?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Thomas
>>>>>
>>>>> _______________________________________________
>>>>> buildroot mailing list
>>>>> buildroot@busybox.net
>>>>> http://lists.busybox.net/mailman/listinfo/buildroot
Arnout Vandecappelle May 26, 2019, 1:21 p.m. UTC | #7
Hi Angelo, Christopher,

On 15/04/2019 16:54, Christopher Peeters wrote:
> On 15/04/2019 16:06, Angelo Compagnucci wrote:
>> On Mon, Apr 15, 2019 at 2:23 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>>>  Hi Christopher,
>>>
>>>  Plese don't top-post, but reply inline like I do below.
>>>
>>> On 15/04/2019 09:46, Christopher Peeters wrote:
>>>> Hi Thomas,
>>>>
>>>> Thank you for your email. I wasn't aware about the commit title
>>>> conventions so I will fix this.
>>>>
>>>> The reason why I selected a different distribution is the lack of
>>>> support for Libvirt by the original distribution.
>>>  I would prefer in that case that we always use this other distribution (which
>>> is actually the same distribution, right? bionic == ubuntu1804...).
>> I wouldn't like to use this distribution if possible, is not the
>> official one and not maintained by canonical. The official one is:
>>
>> https://app.vagrantup.com/ubuntu/boxes/bionic64
> As I said before there's no support from Canonical for libvirt images.
> This can only be solved by Canonical. And if I look at Launchpad, it
> won't happen very soon. There's another question for LXC support open
> for more then a year now.
> 
> An other option when preferring official images is to switch over to one
> of the following boxes since they do understand that source projects
> should support each other and therefore have support for libvirt in
> their Vagrant boxes. I haven't tested them though.
> 
> - https://app.vagrantup.com/debian/boxes/stretch64

 Without understanding all this vagrant stuff, I would say that simply switching
away from Ubuntu and to Debian sounds like the right thing to do, no? Debian
stable is definitely a distro we want to have supported at all times.

 Regards,
 Arnout

> 
> - https://app.vagrantup.com/centos/boxes/7
> 
> - https://app.vagrantup.com/fedora/boxes/29-atomic-host
> 
> - https://app.vagrantup.com/opensuse/boxes/openSUSE-15.0-x86_64
> 
> - https://app.vagrantup.com/archlinux/boxes/archlinux
>
Angelo Compagnucci May 26, 2019, 8:14 p.m. UTC | #8
On Sun, May 26, 2019 at 3:21 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>
>  Hi Angelo, Christopher,
>
> On 15/04/2019 16:54, Christopher Peeters wrote:
> > On 15/04/2019 16:06, Angelo Compagnucci wrote:
> >> On Mon, Apr 15, 2019 at 2:23 PM Arnout Vandecappelle <arnout@mind.be> wrote:
> >>>  Hi Christopher,
> >>>
> >>>  Plese don't top-post, but reply inline like I do below.
> >>>
> >>> On 15/04/2019 09:46, Christopher Peeters wrote:
> >>>> Hi Thomas,
> >>>>
> >>>> Thank you for your email. I wasn't aware about the commit title
> >>>> conventions so I will fix this.
> >>>>
> >>>> The reason why I selected a different distribution is the lack of
> >>>> support for Libvirt by the original distribution.
> >>>  I would prefer in that case that we always use this other distribution (which
> >>> is actually the same distribution, right? bionic == ubuntu1804...).
> >> I wouldn't like to use this distribution if possible, is not the
> >> official one and not maintained by canonical. The official one is:
> >>
> >> https://app.vagrantup.com/ubuntu/boxes/bionic64
> > As I said before there's no support from Canonical for libvirt images.
> > This can only be solved by Canonical. And if I look at Launchpad, it
> > won't happen very soon. There's another question for LXC support open
> > for more then a year now.
> >
> > An other option when preferring official images is to switch over to one
> > of the following boxes since they do understand that source projects
> > should support each other and therefore have support for libvirt in
> > their Vagrant boxes. I haven't tested them though.
> >
> > - https://app.vagrantup.com/debian/boxes/stretch64
>
>  Without understanding all this vagrant stuff, I would say that simply switching
> away from Ubuntu and to Debian sounds like the right thing to do, no? Debian
> stable is definitely a distro we want to have supported at all times.

The only thing that bothers me is that the debian images for vagrant
are not official and only maintained by a single person
(https://app.vagrantup.com/debian).
On the contrary, Ubuntu images are officially maintained by canonical
into their efforts for ubuntu on cloud.

Alternatively we can switch to Fedora which is officially supported
and supports libvirt, but we have to completetly rewrite the provision
section of the vagrantfile.

>
>  Regards,
>  Arnout
>
> >
> > - https://app.vagrantup.com/centos/boxes/7
> >
> > - https://app.vagrantup.com/fedora/boxes/29-atomic-host
> >
> > - https://app.vagrantup.com/opensuse/boxes/openSUSE-15.0-x86_64
> >
> > - https://app.vagrantup.com/archlinux/boxes/archlinux
> >
Arnout Vandecappelle May 26, 2019, 9:30 p.m. UTC | #9
On 26/05/2019 22:14, Angelo Compagnucci wrote:
> On Sun, May 26, 2019 at 3:21 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>>
>>  Hi Angelo, Christopher,
>>
>> On 15/04/2019 16:54, Christopher Peeters wrote:
>>> On 15/04/2019 16:06, Angelo Compagnucci wrote:
>>>> On Mon, Apr 15, 2019 at 2:23 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>>>>>  Hi Christopher,
>>>>>
>>>>>  Plese don't top-post, but reply inline like I do below.
>>>>>
>>>>> On 15/04/2019 09:46, Christopher Peeters wrote:
>>>>>> Hi Thomas,
>>>>>>
>>>>>> Thank you for your email. I wasn't aware about the commit title
>>>>>> conventions so I will fix this.
>>>>>>
>>>>>> The reason why I selected a different distribution is the lack of
>>>>>> support for Libvirt by the original distribution.
>>>>>  I would prefer in that case that we always use this other distribution (which
>>>>> is actually the same distribution, right? bionic == ubuntu1804...).
>>>> I wouldn't like to use this distribution if possible, is not the
>>>> official one and not maintained by canonical. The official one is:
>>>>
>>>> https://app.vagrantup.com/ubuntu/boxes/bionic64
>>> As I said before there's no support from Canonical for libvirt images.
>>> This can only be solved by Canonical. And if I look at Launchpad, it
>>> won't happen very soon. There's another question for LXC support open
>>> for more then a year now.
>>>
>>> An other option when preferring official images is to switch over to one
>>> of the following boxes since they do understand that source projects
>>> should support each other and therefore have support for libvirt in
>>> their Vagrant boxes. I haven't tested them though.
>>>
>>> - https://app.vagrantup.com/debian/boxes/stretch64
>>
>>  Without understanding all this vagrant stuff, I would say that simply switching
>> away from Ubuntu and to Debian sounds like the right thing to do, no? Debian
>> stable is definitely a distro we want to have supported at all times.
> 
> The only thing that bothers me is that the debian images for vagrant
> are not official

 I didn't realize that. However, it looks a lot more official than that bionic64
box. It's "almost official".

> and only maintained by a single person

 Two people, actually, according to [1]. And Lucas Nussbaum is "involved" as
well, whatever that means.

> (https://app.vagrantup.com/debian).
> On the contrary, Ubuntu images are officially maintained by canonical
> into their efforts for ubuntu on cloud.

 But apparently not usable.


> Alternatively we can switch to Fedora which is officially supported
> and supports libvirt, but we have to completetly rewrite the provision
> section of the vagrantfile.

 Yeah, but that would be a bigger change.

 I would be fine with switching to the stretch64 box.

 Regards,
 Arnout


[1] https://wiki.debian.org/Teams/Cloud/VagrantBaseBoxes

> 
>>
>>  Regards,
>>  Arnout
>>
>>>
>>> - https://app.vagrantup.com/centos/boxes/7
>>>
>>> - https://app.vagrantup.com/fedora/boxes/29-atomic-host
>>>
>>> - https://app.vagrantup.com/opensuse/boxes/openSUSE-15.0-x86_64
>>>
>>> - https://app.vagrantup.com/archlinux/boxes/archlinux
>>>
Thomas Petazzoni May 27, 2019, 7:04 a.m. UTC | #10
Hello,

On Sun, 26 May 2019 22:14:54 +0200
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:

> The only thing that bothers me is that the debian images for vagrant
> are not official and only maintained by a single person
> (https://app.vagrantup.com/debian).
> On the contrary, Ubuntu images are officially maintained by canonical
> into their efforts for ubuntu on cloud.
> 
> Alternatively we can switch to Fedora which is officially supported
> and supports libvirt, but we have to completetly rewrite the provision
> section of the vagrantfile.

Do we really need to make a choice here ?

For Docker, our intention is to have several Dockerfiles for different
distributions, in support/docker/.

What about having several Vagrantfiles, in support/vagrant/, also to
support different distributions ?

Best regards,

Thomas
Angelo Compagnucci May 27, 2019, 7:24 a.m. UTC | #11
On Mon, May 27, 2019 at 9:04 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello,
>
> On Sun, 26 May 2019 22:14:54 +0200
> Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
>
> > The only thing that bothers me is that the debian images for vagrant
> > are not official and only maintained by a single person
> > (https://app.vagrantup.com/debian).
> > On the contrary, Ubuntu images are officially maintained by canonical
> > into their efforts for ubuntu on cloud.
> >
> > Alternatively we can switch to Fedora which is officially supported
> > and supports libvirt, but we have to completetly rewrite the provision
> > section of the vagrantfile.
>
> Do we really need to make a choice here ?
>
> For Docker, our intention is to have several Dockerfiles for different
> distributions, in support/docker/.
>
> What about having several Vagrantfiles, in support/vagrant/, also to
> support different distributions ?

It's totally fine for me to have multiple vagrantfiles. We can even
add a little bit of logic to the vagrantfile (it's a ruby script after
all) to add a sort of multi distribution support.
I can try to hack something,

>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
diff mbox series

Patch

diff --git a/support/misc/Vagrantfile b/support/misc/Vagrantfile
index 1ca5edc647..48f01a5807 100644
--- a/support/misc/Vagrantfile
+++ b/support/misc/Vagrantfile
@@ -29,6 +29,12 @@  Vagrant.configure('2') do |config|
 		end
 	end
 
+  config.vm.provider :libvirt do |v, override|
+    override.vm.box = 'generic/ubuntu1804'
+    v.memory = VM_MEMORY
+    v.cpus = VM_CORES
+  end 
+
 	config.vm.provision 'shell' do |s|
 		s.inline = 'echo Setting up machine name'