Patchwork [U-Boot,5/5] USB: Set portnr so USB1.1 and 1.0 devices work on EHCI controllers

login
register
mail settings
Submitter Marek Vasut
Date July 12, 2011, 12:16 a.m.
Message ID <1310429807-23840-5-git-send-email-marek.vasut@gmail.com>
Download mbox | patch
Permalink /patch/104305/
State Accepted
Commit 01a97d45d1be79960570fb345b2c15331f79f053
Headers show

Comments

Marek Vasut - July 12, 2011, 12:16 a.m.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
 common/usb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Sergei Shtylyov - July 12, 2011, 2:56 p.m.
Hello.

Marek Vasut wrote:

> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>

    Hm... but EHCI controllers only support high speed (USB 2.0) devices...
You need a companion controller (UHCI/OHCI) to support the full/low speed devices.

WBR, Sergei
Marek Vasut - July 12, 2011, 3:09 p.m.
On Tuesday, July 12, 2011 04:56:23 PM Sergei Shtylyov wrote:
> Hello.
> 
> Marek Vasut wrote:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> 
>     Hm... but EHCI controllers only support high speed (USB 2.0) devices...
> You need a companion controller (UHCI/OHCI) to support the full/low speed
> devices.

Hi,

I have the thing past a hub with TT. So it's not a problem.
> 
> WBR, Sergei
Remy Bohmer - Aug. 8, 2011, 7:46 p.m.
Hi,

2011/7/12 Marek Vasut <marek.vasut@gmail.com>:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
>  common/usb.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/common/usb.c b/common/usb.c
> index 8e84266..a401c09 100644
> --- a/common/usb.c
> +++ b/common/usb.c
> @@ -1166,6 +1166,7 @@ void usb_hub_port_connect_change(struct usb_device *dev, int port)
>
>        dev->children[port] = usb;
>        usb->parent = dev;
> +       usb->portnr = port + 1;
>        /* Run it through the hoops (find a driver, etc) */
>        if (usb_new_device(usb)) {
>                /* Woops, disable the port */
>

Applied to u-boot-usb. Thanks.

Kind regards,

Remy

Patch

diff --git a/common/usb.c b/common/usb.c
index 8e84266..a401c09 100644
--- a/common/usb.c
+++ b/common/usb.c
@@ -1166,6 +1166,7 @@  void usb_hub_port_connect_change(struct usb_device *dev, int port)
 
 	dev->children[port] = usb;
 	usb->parent = dev;
+	usb->portnr = port + 1;
 	/* Run it through the hoops (find a driver, etc) */
 	if (usb_new_device(usb)) {
 		/* Woops, disable the port */