Patchwork [U-Boot,4/5] USB: Move USB_PRINTF() out of ifdef in usb_scan_devices()

login
register
mail settings
Submitter Marek Vasut
Date July 12, 2011, 12:16 a.m.
Message ID <1310429807-23840-4-git-send-email-marek.vasut@gmail.com>
Download mbox | patch
Permalink /patch/104304/
State Accepted
Delegated to: Remy Bohmer
Headers show

Comments

Marek Vasut - July 12, 2011, 12:16 a.m.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
 common/usb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Stefano Babic - July 13, 2011, 1:49 p.m.
On 07/12/2011 02:16 AM, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
>  common/usb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/usb.c b/common/usb.c
> index 4f7c520..8e84266 100644

Hi Marek,

this should be checked by the USB maintainer, also if it is part of the
Efikamx patchset - I set him in CC.

Best regards,
Stefano Babic
Marek Vasut - July 13, 2011, 9:23 p.m.
On Wednesday, July 13, 2011 03:49:00 PM Stefano Babic wrote:
> On 07/12/2011 02:16 AM, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > ---
> > 
> >  common/usb.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/common/usb.c b/common/usb.c
> > index 4f7c520..8e84266 100644
> 
> Hi Marek,
> 
> this should be checked by the USB maintainer, also if it is part of the
> Efikamx patchset - I set him in CC.

Yea of course ... I sent this to Remy some time ago already, got no response so 
far ...
> 
> Best regards,
> Stefano Babic
Remy Bohmer - Aug. 8, 2011, 7:53 p.m.
Hi,

2011/7/13 Marek Vasut <marek.vasut@gmail.com>:
> On Wednesday, July 13, 2011 03:49:00 PM Stefano Babic wrote:
>> On 07/12/2011 02:16 AM, Marek Vasut wrote:
>> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>> > ---
>> >
>> >  common/usb.c |    2 +-
>> >  1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/common/usb.c b/common/usb.c
>> > index 4f7c520..8e84266 100644
>>
>> Hi Marek,
>>
>> this should be checked by the USB maintainer, also if it is part of the
>> Efikamx patchset - I set him in CC.
>
> Yea of course ... I sent this to Remy some time ago already, got no response so
> far ...

Hey.. It is a holiday season... ;-)

Acked-by: Remy Bohmer <linux@bohmer.net>
(It can go with the rest of the series)

Kind regards,

Remy
Remy Bohmer - Aug. 8, 2011, 7:59 p.m.
Hi,

>> Yea of course ... I sent this to Remy some time ago already, got no response so
>> far ...
>
> Hey.. It is a holiday season... ;-)
>
> Acked-by: Remy Bohmer <linux@bohmer.net>
> (It can go with the rest of the series)

Seems that it time to go again on a next vacation...
I just pulled in 5/5 of this series, so I can pull this one in myself
as well ;-)

Applied to u-boot-usb. Thanks.

Remy

Patch

diff --git a/common/usb.c b/common/usb.c
index 4f7c520..8e84266 100644
--- a/common/usb.c
+++ b/common/usb.c
@@ -957,8 +957,8 @@  void usb_scan_devices(void)
 	/* insert "driver" if possible */
 #ifdef CONFIG_USB_KEYBOARD
 	drv_usb_kbd_init();
-	USB_PRINTF("scan end\n");
 #endif
+	USB_PRINTF("scan end\n");
 }